Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 21 11:17
    marijnh commented #1274
  • May 21 11:17
    marijnh closed #1274
  • May 21 11:16
    marijnh closed #1275
  • May 21 11:16
    marijnh commented #1275
  • May 20 21:26
    marijnh commented #1273
  • May 20 21:25
    marijnh closed #1273
  • May 20 21:24
    marijnh commented #1275
  • May 20 20:54
    ocavue edited #1274
  • May 20 20:07
    ocavue opened #1275
  • May 20 19:55
    ocavue opened #1274
  • May 20 19:04
    ocavue opened #1273
  • May 20 13:18

    marijnh on master

    Adjust for TypeScript build sys… Use absolute paths in pm.js Don't assert installed on 'pm m… (compare)

  • May 20 08:45
    mjmeintjes opened #1272
  • May 20 00:27
    kg782 commented #1270
  • May 17 13:52
    barbatus commented #1271
  • May 17 13:50
    barbatus commented #1271
  • May 17 13:39
    barbatus edited #1271
  • May 17 13:38
    barbatus edited #1271
  • May 17 13:36
    marijnh commented #1271
  • May 17 13:32
    barbatus opened #1271
André Drougge
@miphe
I'm now looking to get the link text in the mix somehow.
André Drougge
@miphe
I'm not sure I'm getting this. I feel ProseMirror is very obtuse to work with.
For the sake of flexibility and extensibility I've chosen prosemirror but using this with React, and markdown it really seems like I'm swimming against the current.
Just implementing a link feature is quite the challenge.
Does anyone know of an example where something like this has been done before? React, Markdown, Link.
André Drougge
@miphe
When I create a new link, I first prompt a form where the user can add the link text (I suppose ProseMirror calls this "title") and the URL (href). Is there a way to get the current selection in the ProseMirror editor to prefill the title field?
I'm looking through the state object but the selection is quite complicated and I can't seem to find just a simple string to prefill with.
Marijn Haverbeke
@marijnh
stat.doc.textBetween is probably useful for that
André Drougge
@miphe
Thanks, I will read about it
Andrew Kirwin
@amk221
Anybody know how I can prevent the cursor from ending up in this NodeView: https://share.getcloudapp.com/6qu8v0EB
André Drougge
@miphe

I'm aiming to use textBetween in order to create a link feature, seems it's not that straightforward.
I made a PoC in this code sandbox https://codesandbox.io/s/prosemirror-markdown-react-b4gfr?file=/src/RichEditor.js

Perhaps this illustrate my struggles more clearly? I'd appreciate any indications here..

Kees de Kooter
@kdekooter
I am well aware that prosemirror is kind of a lego-box that you need to assemble yourself. The "basic example" is very helpful. However I cannot seem to find one quite essential brick: how does one get edited content out of the editor?
Andrew Kirwin
@amk221
@kdekooter I think if you have access to the editor you can do .state.doc.toJSON(), to get the HTML is a bit more involved
Kees de Kooter
@kdekooter
Thanks @amk221 that is a good first step. I am eventually aiming for the HTML here though.
Kees de Kooter
@kdekooter
@amk221 excellent!
Andrew Kirwin
@amk221

I need to implement a 'toggle mode' feature (preview ↔ edit).
This could be done by adding a class, something like this:

.ProseMirror--edit-mode .my-node {
  border: 1px solid red;
}
Hello <div class="my-node">World</div>

...but that means all the styles are 'trapped' inside the ProseMirror 'namespace'.

An alternative approach would be to iterate through certain nodes and remove them when in preview mode:

Hello World

I don't really know where to start with the latter. Can anybody guide me? Or is there a better way?

André Drougge
@miphe
Andrew I have a similar case. I'm using a simple text area where the user writes markdown, and can switch with a toggle to ProseMirror where they see the wysiwyg
So in my case, prose mirror is the preview.
But I suppose you can do a third option as well, where you simply render the HTML (or in my case markdown) with certain styles, to preview.
I simply pass on the state (html or markdown) to outside prosemirror and keep it up to date, at that point you can do what you will with it
Andrew Kirwin
@amk221

Ty.

Another question.. how expensive is this:

this.html = DOMSerializer
      .fromSchema(this.schema)
      .serializeFragment(this.state.doc.content)

Could it be run on an update cycle for example?

Marijn Haverbeke
@marijnh
@amk221 Depends on document size. It's going to build up a whole new DOM structure for the document. Should be fine for small ones, you'll have to benchmark with what you expect your users will be editing.
Andrew Kirwin
@amk221
@marijnh ok thank you. I think I can use on blur instead actually.
Andrew Kirwin
@amk221

I need to apply some changes to a document, strip out some nodes and whatnot.... but I want to leave the editor untouched.

But I'm a bit confused, because dispatch'ing is bound to a view. But in this case, I don't need a view.

Here's a pseudocode example:

toHTML() {
  let schema = this.view.schema;
  let content = this.view.state.doc.content;

  content.descendants((node, pos) => {
    // Find and change some stuff, without affecting the view
  });

  // ...in order to be able to produce an HTML preview

  let div = document.createElement('div');
  let fragment = DOMSerializer.fromSchema(schema).serializeFragment(content);
  div.appendChild(fragment);
  return div.innerHTML;
}

Do I need to juggle two EditorState's?

Andrew Kirwin
@amk221
Or two views for that matter? 🤔
Andrew Kirwin
@amk221
Never mind, it's clicked now... I can use state.apply, instead of dispatch to get a new state, leaving the view intact.
Andrew Kirwin
@amk221

But that leads me to another question....
in a content.descendants loop, how can you batch up operations, and then dispatch the transaction (at the end)?

Say for example you were looping through and replacing nodes by using insertText. This has a knock on effect for the next transaction, because all the positions will have changed.

Andrew Kirwin
@amk221

for example,

function replaceNodesWithTextContent(state, nodeTypes) {
  const tr = state.tr;

  state.doc.content.descendants((node, pos) => {
    if (nodeTypes.includes(node.type)) {
      const from = pos;
      const to = from + node.nodeSize;
      const text = node.textContent;

      tr.insertText(text, from, to);
    }

    return true;
  });

  return state.apply(tr);
}

this gives me an out of range error

Nicholas Vella
@vella-nicholas
Hello, in prosemirror, is one able to create custom html element like <mylist count="#"></mylist>? I do not need to put anything into it, but I need it to exist in a document
Andrew Kirwin
@amk221
@vella-nicholas yes very easy to do that.
Marijn Haverbeke
@marijnh
@amk221 You can either sort the changes in reverse order and apply them in that way, or map changes forward through previous steps before applying them
1 reply
Andrew Kirwin
@amk221
@marijnh Interesting thanks
Nicholas Vella
@vella-nicholas
@amk221 Thank you very much. I will re-read well the documentation. Thanks!
Andrew Kirwin
@amk221

If write this into Gmail compose: (don't copy from here)

Line 1

Line 3

And paste it into ProseMirror, you will get two <br> (Where line2 is)

I realised ProseMirror puts in <br> for empty paragraphs to maintain vertical rhythm but this feels like an issue?

Andrew Kirwin
@amk221
If that message wasn't clear, the output is:
Line 1


Line 3
marek-baranowski
@marek-baranowski:matrix.org
[m]

I need to implement opening in editor .docx file so that it's editable, after finishing edit it should be possible to export to .docx. Possibly with minimal losses in consistency between next conversions.

Are there any examples available so I can take a look? Do you think converting .docx to HTML (end from HTML to .docx after editing) will work ok?

marek-baranowski
@marek-baranowski:matrix.org
[m]
there are couple converters so should be doable in theory. Does anyone have an expierience in such use case?
https://pandoc.org
(not sure yet how this excactly works) http://archieml.org/
https://github.com/Novlr/DOCX.js
https://xsweet.org/
Andrew Kirwin
@amk221
Can any body shed light on why handleDOMEvents is separate from handleClick?
Marijn Haverbeke
@marijnh
You can handle clicks through handleDOMEvents, it's just that handleClick provides some additional conveniences that are specific to clicks
Andrew Kirwin
@amk221
ty
Michael Rutter
@m-rutter
Hi, trying to design something that allows users to to author a snippet which gets serialised to a database somewhere, and then allows users to apply that snippet to existing documents. I'm just trying to navigate the data types of prosemirror to identify what I likely need. If I had to guess I would need to either serialise/deserialise a Tranactions, Transform, or EditorState, and then somehow apply that to an existing document via the Editorstate apply/applytractions methods
Marijn Haverbeke
@marijnh
You probably want to serialize a Slice, and use Transaction.replace or Transaction.replaceSelection to insert it.
Michael Rutter
@m-rutter
@marijnh thanks
Michael Rutter
@m-rutter
Say I have a Slice that has nodes tied to a specific schema
and I want to replace all of those nodes with something else, what would I need to do? It doesn't seem like I can perform a transaction on Slice
I can get a flat list of the nodes via descendents callback on the Fragment content on the slice, but I'm not sure how to replace content
for some context, I have a tool that allows authors to create snippets for later insertation into another document that need to be serialized to the database. Some of the custom nodes on the document are essentially variables that I want to identify and replace
effectively, I'm creating a template
Marijn Haverbeke
@marijnh
A recursive function that runs through the slice's fragment, building up a new tree and returning that, seems like the way to do that.