These are chat archives for ProtoDef-io/node-protodef

8th
May 2016
Hans Elias J.
@hansihe
May 08 2016 12:39
the documentation is still not updated though
Romain Beaumont
@rom1504
May 08 2016 12:39
it is
Hans Elias J.
@hansihe
May 08 2016 12:39
it would be a lot easier for me to update elixir-protodef if it was
is it?
Romain Beaumont
@rom1504
May 08 2016 12:39
ProtoDef-io/ProtoDef@03b7ea4
Hans Elias J.
@hansihe
May 08 2016 12:39
oh, 8 minutes ago
Romain Beaumont
@rom1504
May 08 2016 12:40
yeah well I did the changes and the merging together
I was kind of waiting for roblabla to do it, but I hate PR that hang there forever ^^
Hans Elias J.
@hansihe
May 08 2016 12:45
i actually don't need to make any changes i think
Romain Beaumont
@rom1504
May 08 2016 12:45
well I added 2 tests
they wouldn't have worked in node-protodef previously
if they work in elixir-protodef then I guess it works
I mean, these 2 tests don't test everything
but it's something
Hans Elias J.
@hansihe
May 08 2016 12:46
yep, they work
so it's at least ballpark working then
i should try to implement mapper
it's not implemented at the moment
Romain Beaumont
@rom1504
May 08 2016 12:50
is it not similar to switch ?
I mean the implementation
Hans Elias J.
@hansihe
May 08 2016 12:51
yeah, it should be
the problem is i need to figure out when i can use atoms
also, the fact that the keys are always strings in json
that means that in the case where the mapper maps a number to something, i need to convert the key to a number
but i can't do it every time, in case a string is mapped to something
if i do some kind of type inference though, would let me remove javascript_eq
Romain Beaumont
@rom1504
May 08 2016 13:13
ah yeah