These are chat archives for ProtoDef-io/node-protodef

26th
Feb 2017
Romain Beaumont
@rom1504
Feb 26 2017 17:27
so
apparently what is in types is not ordered
because it can be circular
I thought it couldn't
or it wouldn't be fun
that means I need to 1) add a not_validate option for addType 2) make addTypes add everything before validating
Romain Beaumont
@rom1504
Feb 26 2017 17:50
so many unrelated consequences...
somehow this is making the packets tests in nmp slow
why
they have 0 link to the validator
Romain Beaumont
@rom1504
Feb 26 2017 17:56
ok it's recreating the protocol at every damn packet test
just why
ah I see
we are recreating the protocol at each state change
great idea
Romain Beaumont
@rom1504
Feb 26 2017 18:34
ok works for nmp
let's release this
Romain Beaumont
@rom1504
Feb 26 2017 18:41
oh
I guess I broke everything
greenkeeper will be mad
Robin Lambertz
@roblabla
Feb 26 2017 18:41
xD
Romain Beaumont
@rom1504
Feb 26 2017 18:42
it's not really breaking but actually it caught a few errors in nmp, so it actually breaks it
(and I published protodef as minor)
hence greenkeeper will say it's evil for nmp, mineflayer and flying-squid I think
except if I publish a new nmp version fast enough :d
oh and protodef still needs babel because we use ...
Robin Lambertz
@roblabla
Feb 26 2017 18:45
... still isn't stable ?
:(
firefox reached 100% es6 compat iirc
Romain Beaumont
@rom1504
Feb 26 2017 18:49
... is not part of es2015
Robin Lambertz
@roblabla
Feb 26 2017 18:49
oh. I thought it was.
not sure
it definitely doesn't work with node6
let's move nmp to node6 anyway
because protodef-validator requires it
Romain Beaumont
@rom1504
Feb 26 2017 19:18
oh well
p-chunk is broken too apparently
oh ok
buffer schema is indeed incomplete
Romain Beaumont
@rom1504
Feb 26 2017 19:23
or is it
wtf is countTypeArgs
we're using that
Robin Lambertz
@roblabla
Feb 26 2017 19:23
args to give to countTYpe
because countType used to be a string
and the args had to be given separately
IIRC
Romain Beaumont
@rom1504
Feb 26 2017 19:25
right
yeah I see that in node-protodef code
that's not in the schemas
Robin Lambertz
@roblabla
Feb 26 2017 19:25
it should be removed tbh
countType should be a type
Romain Beaumont
@rom1504
Feb 26 2017 19:26
it's not in protodef doc either
yeah that might be better
well
actually that's what the schema and the doc already say
let's see if the implementation already handle it, that would be convenient
so this afternoon I thought "oh I can finish this in 20 minutes, let's just release it". 10 bugs later... it's been quite a few hours :p
Robin Lambertz
@roblabla
Feb 26 2017 19:28
xD
Romain Beaumont
@rom1504
Feb 26 2017 19:28
but it's actually catching errors so that's useful
yeah well the implementation doesn't handle it...
oh well
Robin Lambertz
@roblabla
Feb 26 2017 19:29
should be a 5 lines fix no ?
Romain Beaumont
@rom1504
Feb 26 2017 19:30
got to fix array and buffer
same for buffer
ah no not the second link
ok so it's not buffer/array specific
it can be fixed in the count functions
countTypeArgs should be removed
then countType should be split using the thingy we use elsewhere
ah yeah getFieldInfo
ok doing it
Robin Lambertz
@roblabla
Feb 26 2017 19:34
getCount, sendCount and calcCount need to be changed
Romain Beaumont
@rom1504
Feb 26 2017 19:36
yeah done and published
Romain Beaumont
@rom1504
Feb 26 2017 19:58
pchunk fixed
now ['i32',[]] is not accepted obviously
and we use it because no-alias
let's implemented aliases...
(to fix mineflayer)
Romain Beaumont
@rom1504
Feb 26 2017 20:11
gosh
| in chanel names is a meta character in schemas
whatever
that's why people don't use types and schemas. So you can safely ignore all errors and problems :D
Romain Beaumont
@rom1504
Feb 26 2017 21:36
ok let's fix this before people start to complain
Romain Beaumont
@rom1504
Feb 26 2017 22:39
that meta thing is really annoying
ah
I guess it's just in refs
Romain Beaumont
@rom1504
Feb 26 2017 22:59
ok mineflayer fixed
fs works
now raknet
Romain Beaumont
@rom1504
Feb 26 2017 23:22
fixed
ok all dependents working, finally
Romain Beaumont
@rom1504
Feb 26 2017 23:39
well
all of these issues could easily be resolved once node-protodef becomes a compiler
so that's the next step