Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 12 10:08
    SuperOP535 closed #92
  • Jan 13 21:26
    rom1504 commented #95
  • Jan 13 18:12
    rom1504 opened #96
  • Jan 13 18:11
    rom1504 opened #95
  • Nov 29 2018 20:42

    rom1504 on master

    Change some functions to arrow … (compare)

  • Nov 29 2018 20:42
    rom1504 closed #94
  • Nov 29 2018 20:33
    SuperOP535 synchronize #94
  • Nov 29 2018 20:31
    SuperOP535 synchronize #94
  • Nov 29 2018 20:29
    SuperOP535 opened #94
  • Nov 29 2018 18:31
    SuperOP535 closed #93
  • Nov 29 2018 08:56
    SuperOP535 opened #93
  • Nov 25 2018 15:53

    rom1504 on master

    update chat badges (compare)

  • Nov 15 2018 13:29
    SuperOP535 opened #92
  • Nov 15 2018 13:23
    SuperOP535 commented #75
  • Nov 15 2018 11:18
    rom1504 commented #75
  • Nov 15 2018 10:18
    SuperOP535 commented #75
  • Nov 13 2018 01:17
    rom1504 commented #75
  • Nov 12 2018 23:19
    rom1504 closed #85
  • Nov 12 2018 23:19
    rom1504 commented #85
  • Nov 12 2018 23:19

    rom1504 on master

    Added LICENSE file (compare)

mhsjlw
@mhsjlw
@chibill we want your feedback, what do you suggest ?
Hans Elias J.
@hansihe
that's the mathematically correct naming
mhsjlw
@mhsjlw
with the constructive criticism that we've explained
William Gaylord
@wgaylord
Also one problem... having two types like one of the things has won't work....
Hans Elias J.
@hansihe
right, yeah
William Gaylord
@wgaylord
And what does prop mean?
Hans Elias J.
@hansihe
that's because I changed the format on the spot, it is not decided yet
Robin Lambertz
@roblabla
I think, it was supposed to be ["virtual", { ref, data, type }]
Right ?
William Gaylord
@wgaylord
if prop means property what does that mean in this case.
Hans Elias J.
@hansihe
prop is a (standardized) way to access a property of another field
Robin Lambertz
@roblabla
prop is the type of reference the virtual is
Hans Elias J.
@hansihe
in this case the "tag" field of the union
so what happens is
Robin Lambertz
@roblabla
(tag, count, ???)
Hans Elias J.
@hansihe
when writing the type out
the virtual field will get it's value from the tag of the union
William Gaylord
@wgaylord
so I will rest my case you your making the Json its own thing that will take a while to learn.
Hans Elias J.
@hansihe
when reading the type, the union will get its value from the virtual field
Robin Lambertz
@roblabla
erm, I meant { ref, prop, type } up there
@chibill we're adding new concepts to protodef. It's obvious that will go in the JSON as well.
William Gaylord
@wgaylord
also you seem to be making the JSON files bigger with out adding anything new to them. Just changing how they work....
Robin Lambertz
@roblabla
The whole idea of the JSON is that it's easier to work with because you don't have to write your own parser and w/e
Hans Elias J.
@hansihe
chibill: what I did was remove hacks that only worked for some special cases and replaced them with more general and expandable mechanisms
case in point, mapper and switch
William Gaylord
@wgaylord
I have no idea why mapper ever existed when you could have just used a switch to do that same job...
Hans Elias J.
@hansihe
both of which were relatively specific, only used in some cases, interacted with each other in a complex way
you can't
that's the point
union is more flexible
it replaces them both
Robin Lambertz
@roblabla
@chibill we needed to put a string in the container to get the name of the packet
We already had switch
The idea was that mapper takes the packet ID and turns it into a packet name
Hans Elias J.
@hansihe
same with the count mechanism in array and buffer
Robin Lambertz
@roblabla
while switch takes the packet ID and figures out what packet type to read from it
Hans Elias J.
@hansihe
that could work in 3 different ways, depending on what arguments you give it
those 3 ways has been replaced with a single way which manages to be generic and not much more verbose
William Gaylord
@wgaylord
switch takes a type and compares it to decide what to do. Mapper takes a type and compares it to decide what to output sounds exactly the same....
waht ever.
Hans Elias J.
@hansihe
yeah. what ever.
it's not though
William Gaylord
@wgaylord
the fact that everything I was working on will be trash pisses me off.
Robin Lambertz
@roblabla
eeh, actually he does have a point. We might've been able to make something better by just creating a "const" type
Hans Elias J.
@hansihe
well, the point of mapper is that it's two way
that's the whole trick of it, if I remember right
William Gaylord
@wgaylord
mapper is one way according to the docs.
Robin Lambertz
@roblabla
@hansihe so for arrays, we could do
def("test") => container(virtual: "true") {
    virtual_field("count", ref: "data", prop: "count") => u64;
    field("data") => array(type: "u8")
}
or something like that ?