Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 24 16:35
    rom1504 commented #97
  • Aug 24 16:33

    rom1504 on master

    Release 1.6.10 (compare)

  • Aug 24 16:31

    rom1504 on master

    add gitpod and fix gitmodules (compare)

  • Aug 24 16:29
    rom1504 closed #65
  • Aug 24 16:29
    rom1504 commented #65
  • Aug 24 16:28
    rom1504 closed #53
  • Aug 24 16:28
    rom1504 commented #53
  • Aug 24 16:28
    rom1504 closed #52
  • Aug 24 16:28
    rom1504 commented #52
  • Aug 24 16:27
    rom1504 closed #51
  • Aug 24 16:27
    rom1504 commented #51
  • Aug 24 16:26

    rom1504 on master

    Fixed issue #97 Merge pull request #97 from mrc… (compare)

  • Aug 24 16:26
    rom1504 closed #97
  • Aug 24 15:58
    mrcrille commented #97
  • Aug 24 15:23
    mrcrille commented #97
  • Aug 24 15:20
    mrcrille commented #97
  • Aug 24 15:18
    mrcrille opened #97
  • Aug 24 15:11
    rom1504 commented #97
  • Aug 24 15:06
    mrcrille opened #97
  • Mar 12 10:08
    SuperOP535 closed #92
Hans Elias J.
@hansihe
union is more flexible
it replaces them both
Robin Lambertz
@roblabla
@chibill we needed to put a string in the container to get the name of the packet
We already had switch
The idea was that mapper takes the packet ID and turns it into a packet name
Hans Elias J.
@hansihe
same with the count mechanism in array and buffer
Robin Lambertz
@roblabla
while switch takes the packet ID and figures out what packet type to read from it
Hans Elias J.
@hansihe
that could work in 3 different ways, depending on what arguments you give it
those 3 ways has been replaced with a single way which manages to be generic and not much more verbose
William Gaylord
@wgaylord
switch takes a type and compares it to decide what to do. Mapper takes a type and compares it to decide what to output sounds exactly the same....
waht ever.
Hans Elias J.
@hansihe
yeah. what ever.
it's not though
William Gaylord
@wgaylord
the fact that everything I was working on will be trash pisses me off.
Robin Lambertz
@roblabla
eeh, actually he does have a point. We might've been able to make something better by just creating a "const" type
Hans Elias J.
@hansihe
well, the point of mapper is that it's two way
that's the whole trick of it, if I remember right
William Gaylord
@wgaylord
mapper is one way according to the docs.
Robin Lambertz
@roblabla
@hansihe so for arrays, we could do
def("test") => container(virtual: "true") {
    virtual_field("count", ref: "data", prop: "count") => u64;
    field("data") => array(type: "u8")
}
or something like that ?
Also, what does virtual really do on container ?
William Gaylord
@wgaylord
But I have learned to not trust the docs but this time the Node version agrees.
Hans Elias J.
@hansihe
sorry, I don't quite understand
what do you intend the type: "u8" to do here?
Robin Lambertz
@roblabla
the array's content
This would create an array of bytes
William Gaylord
@wgaylord
what about the array's size?
ohh nvm
Robin Lambertz
@roblabla
that's what the virtual_field does
Hans Elias J.
@hansihe
roblabla: I fail to see why you would specify the inner type like that
William Gaylord
@wgaylord
because you have to...
Hans Elias J.
@hansihe
why not field("data") => array() => u8
no
Robin Lambertz
@roblabla
oh
true, my bad
I'm thinking in terms of the old json format XD
Hans Elias J.
@hansihe
so what you mean is that the array should resolve the reference the other way automatically?
William Gaylord
@wgaylord
I will just say this again.
Hans Elias J.
@hansihe
I opted to mark it manually because I usually like making things explicit
over implicit
William Gaylord
@wgaylord
mapper is one way according to the docs.
But I have learned to not trust the docs but this time the Node version agrees.
as no one said anything.
Robin Lambertz
@roblabla
@chibill IDK. No one knows. I don't remember how mapper works, I'd need to dig into the source code of the mapper datatype. And I'm not too interested in knowing.
Mapper sucks and should die :P
@hansihe aaah I see. I missed the ref somehow
Makes sense now
Hans Elias J.
@hansihe
chibill: mapper is two way. it maps a string to a constant
Robin Lambertz
@roblabla
Last question : what does virtual do in containers ? Is it to signify that it contains virtual fields ?
William Gaylord
@wgaylord
so why is it not that way in the impl? or is JS goofy syntax messing me up......
Hans Elias J.
@hansihe
so when reading it could take 0 and map it to something like "packet_read"