Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 24 16:35
    rom1504 commented #97
  • Aug 24 16:33

    rom1504 on master

    Release 1.6.10 (compare)

  • Aug 24 16:31

    rom1504 on master

    add gitpod and fix gitmodules (compare)

  • Aug 24 16:29
    rom1504 closed #65
  • Aug 24 16:29
    rom1504 commented #65
  • Aug 24 16:28
    rom1504 closed #53
  • Aug 24 16:28
    rom1504 commented #53
  • Aug 24 16:28
    rom1504 closed #52
  • Aug 24 16:28
    rom1504 commented #52
  • Aug 24 16:27
    rom1504 closed #51
  • Aug 24 16:27
    rom1504 commented #51
  • Aug 24 16:26

    rom1504 on master

    Fixed issue #97 Merge pull request #97 from mrc… (compare)

  • Aug 24 16:26
    rom1504 closed #97
  • Aug 24 15:58
    mrcrille commented #97
  • Aug 24 15:23
    mrcrille commented #97
  • Aug 24 15:20
    mrcrille commented #97
  • Aug 24 15:18
    mrcrille opened #97
  • Aug 24 15:11
    rom1504 commented #97
  • Aug 24 15:06
    mrcrille opened #97
  • Mar 12 10:08
    SuperOP535 closed #92
Hans Elias J.
@hansihe
so when reading it could take 0 and map it to something like "packet_read"
when writing it would take "packet_read" and map it to 0
switch is not capable of doing that
Robin Lambertz
@roblabla
It could
NVM
it can't.
My brain is not working
Hans Elias J.
@hansihe
roblabla: when a container only has a single non-virtual field in it, you can mark the container as virtual
that removes the container from the output, the single non-virtual field replaces it in the serialized/deserialized data
Robin Lambertz
@roblabla
ah, so it's like the old anon ?
William Gaylord
@wgaylord
but would the non-virtual field not then be virtual? Unless there is a non-virtual tag or something on the field....
Robin Lambertz
@roblabla
kinda sorta
Hans Elias J.
@hansihe
no, not really
well, the other way around kinda
Robin Lambertz
@roblabla
hmm, yeah I get it
Hans Elias J.
@hansihe
it's a way of defining something like a length prefixed array type without specific built in language features
William Gaylord
@wgaylord
how does it know that the field is not virtual along with the container?
Hans Elias J.
@hansihe
it just helps with composability really
Robin Lambertz
@roblabla
@chibill virtual just means you don't provide it data directly
instead it is derived from another field.
Hans Elias J.
@hansihe
chibill: notice that there are fields and there are virtual_fields? fields are not virtual, virtual_fields are virtual
Robin Lambertz
@roblabla
E.G. when writing, you don't have to specify the length of an array yourself. That's because "count" is a virtual field.
William Gaylord
@wgaylord
so why not have virtual_container?
Robin Lambertz
@roblabla
valid question.
Hans Elias J.
@hansihe
because the container has the exact same semantics when specifying types wither it is virtual or not
William Gaylord
@wgaylord
Also I did not notice virtual_field because its not in the example.
Hans Elias J.
@hansihe
but yeah, that's a design decision
Robin Lambertz
@roblabla
@chibill it is
in the pds
Hans Elias J.
@hansihe
yep
look for it
it's there
Robin Lambertz
@roblabla
virtual_field is just "virtual" in the JSON
which is interesting...
William Gaylord
@wgaylord
so why not just add virtual into the type args... As thats what it will be in the json...
why make a new type?
Robin Lambertz
@roblabla
It's not really a new type
it replaces count
and makes it more generic
William Gaylord
@wgaylord
virtual_field is a new type if you look how the pds is. Each type is defined by a syntax like <type>()
But its a type that only exists in the pds
Robin Lambertz
@roblabla
virtual_field is not a type in the pds, but it's a type in the JSON actually
in the pds, there are two kinds container fields. field and virtual_field.
In the JSON, field is just a pass-through, while virtual_field transforms into a type
Hans Elias J.
@hansihe
Question, if you think protodef is so stupid in every single way, why don't you just design your own version/use something else? If you come up with something better I would definitely use it.
William Gaylord
@wgaylord
I have never said it was stupid.
I am just questioning the questionable stuff that does not make sense.
Hans Elias J.
@hansihe
It would help a lot if you could come up with alternative solutions instead of JUST criticizing. We are aware there is a lot of complexity in some places, but it's that way because we believe it to be necessary
Robin Lambertz
@roblabla
Of all the points you gave, only one was valid : the new version make the semantics of container in the JSON dirtier