Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 06 2020 08:52
    rahulrakida opened #95
  • Jan 03 2020 15:11
    Excaling opened #94
  • May 14 2019 10:56
    cybercatgurrl commented #71
  • May 31 2018 18:12
    JoonatanPartanen commented #66
  • Jan 19 2018 18:47
    farid-fari commented #77
  • Dec 02 2017 10:31
    andrew-mi opened #93
  • Nov 29 2017 22:23
    flipflop97 opened #92
  • Oct 23 2017 16:52
    Dunspa opened #91
  • Aug 28 2017 14:36
    sylveon closed #86
  • Jun 04 2017 13:57
    XtremePlayzCODE opened #90
  • May 16 2017 09:36
    jakkaj opened #89
  • May 14 2017 10:49
    jakkaj commented #88
  • May 14 2017 05:57
    jakkaj opened #88
  • Feb 22 2017 20:07
    charlesmilette commented #86
  • Feb 22 2017 20:07
    charlesmilette synchronize #86
  • Feb 22 2017 19:59
    mconnew commented #86
  • Feb 18 2017 01:41
    mconnew commented #87
  • Feb 18 2017 01:38
    mconnew opened #87
  • Feb 16 2017 23:06
    Mercurial commented #86
  • Feb 16 2017 23:04
    charlesmilette opened #86
Quinn Damerell
@QuinnDamerell
Welcome To Baconit For Windows 10!
Joey Foo
@joeyfoo
Hi Quinn, is this chat active/in use?
Quinn Damerell
@QuinnDamerell
Yeah! I am not on it 24 / 7 but I do want to start having conversations on it!
Thai Nguyen
@qtoncoding
I ran through the app and looked at memory usage, there seems to be no cleaning up of comments when navigated from a subreddit view. However there are sudden drops in memory usage in what I think is GC, but it's not deterministic and personally I think when an user navigates from a subreddit view, it's safe to clean up the comments loaded in that subreddit.
I'll take on reducing the memory footprint
Quinn Damerell
@QuinnDamerell
That would be awesome, it is something that really needs to be done and I haven't had time to look at. Thanks!
Thai Nguyen
@qtoncoding
Though I'd like to discuss what should be the appropriate cleanup behavior
I have some ideas, will write them down properly ok when I get home
jonthegiant
@jonthegiant
Pretty wild that I find my old college roommate
while browsing github's trending repos.
doh, didn't mean to hit enter :(
Quinn Damerell
@QuinnDamerell
Hey Jon! That's awesome! How have you been? Want to help out on Baconit? :P
@qtoncoding sure thing, send your ideas to me when you have them ready!
Matt Connew
@mconnew
Hi Quinn. I did a little more profiling of the app and there's one more area I think peak memory usage can be improved. Every single comment get's allocated it's own event handler class instance. You have declared a static event handler in managed code, but the WinRT wrappers create a new RT style wrapper for each usage. To fix this, you would need to basically do the same thing that the framework wrappers are doing and reuse the created objects.
Quinn Damerell
@QuinnDamerell
I saw that in the profiler but didn't understand what it was exactly. I am not following exactly what your saying, are you talking about the PropertyChanged stuff in the Comment.cs class? Or are you talking about something else? I'm also not sure what the 'WinRT' wrapper way of doing it would be, are there any examples that you know of you can link me to?
Matt Connew
@mconnew
There is some compiler generated code created around adding/removing event handlers. This is the class used to do this: https://msdn.microsoft.com/en-us/library/hh138484(v=vs.110).aspx
Basically it looks like although a single instance could be used everywhere, the framework automatic glue is allocating lots of objects.
I don't know if there's a way to directly fix this because I suspect the event handlers are being created in code you don't own. Gui stuff isn't my strong point, but I remember there being a concept in XAML where it would search up the ui tree to find a ui component which could handle the event. Maybe that would help.
Matt Connew
@mconnew
lonestarwanderer
@lonestarwanderer
Hey Quinn, can you walk me through on rebuilding Baconit in debug mode?
Quinn Damerell
@QuinnDamerell
Quick and dirty, I just wrote this. I will go back and clean it up later.
Let me know if something doesn't work correctly :)
Alexander
@Sigmanor
Is there any version for wp 8.1?
Quinn Damerell
@QuinnDamerell
Yup! The original version of Baconit was for WP 8.1. But it hasn't gotten an update in quite some time. Most of my effort is now focused on the Win10 version, I just don't have enough time to work on them both. :(
James Purkiss
@rubberloki

Hey Quinn, still getting issues bringing up the project in my version of visual studio. Pretty sure I'm missing some stuff for visual studio though (just replaced my laptop).

Edit: project, not repo

James Purkiss
@rubberloki
alrighty, got it up and running.
Quick question: for the gui, did you use winforms or WPF?
Connor Uhlman
@Conrad2134
Opened up a PR (#60) for issue #57. Wasn't sure the procedure is for contributing, but I started by going from Conrad2134:develop to QuinnDamerell:develop, which included a merge from master into develop (because I'm trying to equate develop to what would be a "release" branch in my organization, but that might be wrong). There's comments and questions about that in the PR though.
thorhop
@thorhop
Where can I find the keyboard shortcuts in the code? Also, what are the instructions to build?