@dnicolodi , without profiling the code you I can make a guess, if you create you build your list of triples as an iterator such as a list-comprehension, you can do a bulk insert into the graph using addN: https://rdflib.readthedocs.io/en/stable/apidocs/rdflib.html#rdflib.graph.Graph.addN
We've had the discussion about linting many times in the past. The crux of the matter is we want to keep the barrier to contribution as low as possible for users of RDFLib. And the kinds of people who use RDFLib are not necessarily software engineers. We want researchers, academics, scientists, semantic extereprts, ontology experts, etc to be able to contribute to RDFLib. I don't like to stereotype or put people into categories, but in my experience a lot of experts do not want to deal with jumping through hoops to make their code compliant.
@ashleysommer thanks for the reply, and valid points. I was thinking PEP8, specifically autopep8, I guess I read right past it, but when I ran autopep8 on the codebase there were many warnings, so I guess I just assumed it was not being used, but I guess it makes sense to only apply it to pull requests.
so I am looking at this, to add tests for transitive_objects and transitive_subjects: https://github.com/RDFLib/rdflib/blob/master/examples/transitive.py
Actually sorry, this: https://github.com/RDFLib/rdflib/blob/master/rdflib/graph.py#L882
nvm, I get it I think
Any suggestions on tests here would be appreciated: RDFLib/rdflib#1291
And if not can I look at it?
As I see it, we have merged some breaking changes already so we will head for 6.x
but I guess if there is no big pressure it is not needed, if 6.x is not to far on the horizon it makes sense
Have you considered enabling the GitLab Community features?
So there is a place to ask questions like that without making issues
If I were in control of universities I would get people to make PRs for things like this instead of dumb coding assignments
@aucampia: you are right, there is a lot to do in the rdflib. We try our best in maintaining it and are happy about contributions to improve it.
Also there is some activity in improving the performance of th rdflib
recommendation of rdf4j and jena is not meant to be disparaging of rdflib, I also use rdflib mostly because most of the time I don't want to struggle with JVM and JVM does not have pip, pipx, etc - just don't want people to not use RDF because of a performance concern of rdflib
rdflib is awesome for what it is
but if I were to build something production grade that needs good performance I would use Jena or RDF4J
I think the best hope is to find more commercial applications for RDF
The more commercial use the more funding and more contributions
But if universities were better actors in the ecosystem it would help, if they instead direct resources to maintaining existing stuff instead of making yet another research project that will be abandoned it would be very beneificial
I am going to submit a fix for tox this weekend, and then also submit changes to add mypy to CI pipeline (and eventually to tox) - hope it is well received. I will also try and make CONTRIBUTING.md similar to this: https://github.com/pallets/click/blob/main/CONTRIBUTING.rst
better to have that in Repo IMO
@aucampia: If you are planning to invest more time in performing big changes or something alike, we can also try to schedule a call with @ashleysommer and Nicholas to so how we can best organize this.
I am open to it, I want to help where I can but I don't really have dedicated time for it. For me it is easier to navigate the code base with type annotations. Besides this I am just looking at small issues to try and get a better understanding of the code base. I will look at the backlog for 6.0.0 where I can, some of it looks quite complicated, the RDF 1.1. test suite looks like a decent thing to try do and not that complicated, but I have not quite built up the courage for starting on that. Actual bug I will look at next is RDFLib/rdflib#1228
But I think that is the case, or have no reason to think it is not the case
1 reply
If there are any PRs you want me to review I can have a look, I keep an eye out for small and easy ones where I have some knowledge about the implementation but the more complex ones I won't necessarily review unless someone makes an explicit request
bridge works well
Thanks for review BTW
