Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 01 18:31
    RIAEvangelist deleted #130
  • Jul 01 18:31
    RIAEvangelist commented #130
  • Jul 01 18:30
    RIAEvangelist commented #130
  • Jul 01 18:24
    KristN1 closed #130
  • Jul 01 18:18
    KristN1 opened #130
  • Jun 25 21:13

    dependabot[bot] on npm_and_yarn

    (compare)

  • Jun 25 21:13
    dependabot[bot] closed #127
  • Jun 25 21:13
    dependabot[bot] commented #127
  • Jun 25 21:13
    dependabot[bot] labeled #129
  • Jun 25 21:13
    dependabot[bot] opened #129
  • Jun 25 21:13

    dependabot[bot] on npm_and_yarn

    Bump node-fetch from 2.6.1 to 2… (compare)

  • May 06 01:29
    odog2454 commented #122
  • May 05 04:24
    RIAEvangelist commented #122
  • May 05 02:08
    odog2454 commented #122
  • May 05 00:45
    odog2454 commented #122
  • May 04 23:45
    odog2454 commented #122
  • May 04 23:45
    odog2454 commented #122
  • May 04 23:40
    odog2454 commented #122
  • Mar 14 03:45
    ElijahPepe commented #128
  • Mar 14 02:47
    ElijahPepe commented #128
Madeline Cameron
@madelinecameron
I should probably just use this one from now on.
Brandon Nozaki Miller
@RIAEvangelist
In the pi branch or the pi repo?
Madeline Cameron
@madelinecameron
Repo
Brandon Nozaki Miller
@RIAEvangelist
Ohh.
I wonder if we went about it the same way?
Will be interesting to see.
Madeline Cameron
@madelinecameron
Yeah I was wondering that too. You may have a more intuitive solution than me. I was mostly hacking to get it working because I was in a rush to get out the door.
Part of it on my repo is commented out, that part does work. I just commented out because my terminal was getting flooded.
I don't know if you have found it already but Store is broken. The ID is never set (the Store 'object' initializor has no parameters.
Sorry about my stuff being really hack-ish. You caught me off guard last night, I never meant for it to be pulled back in so I was just finishing it as I needed the functionality.
Brandon Nozaki Miller
@RIAEvangelist
Lol. K just finished.
That's good. I mean this is how open source stuff gets better.
If any member finds something hackish they can clean it up.
Like you did with my stuff ;)
Madeline Cameron
@madelinecameron
Yeah, definitely. (Didn't want to say that. ;D)
Brandon Nozaki Miller
@RIAEvangelist
Otherwise at least there is something there
K pushed.
Once we get to a stable release we should switch to working on a branch instead of master. My bad.
Brandon Nozaki Miller
@RIAEvangelist
Did a last post on pci compliance in case anyone gets there via Google.
Madeline Cameron
@madelinecameron

Nah, you pretty much summed it up. Stripe does have 'solution' you can implement for your site for exactly what you mentioned (as far as I know). Basically the issue arises when you transmit credit card information to your server, I believe. Or at least that was my understanding. That as long as the transmission is user -> Stripe, it's okay but user -> server -> Stripe is no go.

But that makes me wonder if even user -> Stripe is "breaking" PCI rules. I didn't study deeply into PCI-DSS, just that it costs a bunch of money, is a hassle and using a third-party (like Stripe) alleviates that issue as long as you never transmit CC info to your server.

You are right though that it doesn't entirely belong as a default feature.

I believe my implementation was using tokens but I'd have to check because I have a couple projects that use Stripe and this was the first one I attempted.
Brandon Nozaki Miller
@RIAEvangelist
if it goes user -> anything you wrote even javascript-> stripe
it puts you into the loop. bleck.
When trying to be compliant I usually just push to the processor site and then have the processor push to one of my URLS like a url callback if you will.
Went through a year long audit for PCI compliance with one company. Was a nightmare. They litteraly went to every office and went through all of the files etc. nuts.
Madeline Cameron
@madelinecameron
Interesting, I wasn't aware of that but it does makes sense that any JS you write makes you liable, even client-side. In short, Stripe integration is out either way, haha. :)
Brandon Nozaki Miller
@RIAEvangelist
I'm gonna make some modifications to the read me examples to show object initialization for some like Store etc. Will make it a bit clearer for more jr. devs.
Madeline Cameron
@madelinecameron
Definitely. My README was a huge hack together and was just adapting yours to my changes.
Brandon Nozaki Miller
@RIAEvangelist
Also, I would like to put the package quality up in the read me, hopefully after your next publish, the git link going to our repo will bump up the rating. you can see it here : http://packagequality.com/#?package=pizzapi
dominos was 4.5 stars I think this one should get there as well.
Madeline Cameron
@madelinecameron
Oh yikes, that rating. What determines the rating?
Brandon Nozaki Miller
@RIAEvangelist
some of it has to do with contributors, issues, some responsiveness to issues. the git repo, and versioning.
versioning is pretty big.
Madeline Cameron
@madelinecameron
Ahh okay, so just having an active repo is what gets your rating up. What do you mean by versioning?
Like how does that factor in? Having a higher version is better? Or just having frequent 'releases' is good?
Higher version = better would be super weird, haha
Brandon Nozaki Miller
@RIAEvangelist
There are some rules to versioning, like when to itterate certain numbers, backwards compatibility etc.
Madeline Cameron
@madelinecameron
Oh okay. That's cool. So just handling versioning correctly.
Brandon Nozaki Miller
@RIAEvangelist
lol no not related to higher version, but if say you released version 0.1.1 and then 0.0.5 in that order
that would have a major impact.
Once this next build is ready and we do a review, I think I would be good to going to v 1. however many 0s you used.
yeah, just proper versioning
Madeline Cameron
@madelinecameron
major.minor.patch is what I used, I believe. But yeah, if I can get tests for everything working and passing, I'd be cool with declaring it 1.0.0.
Brandon Nozaki Miller
@RIAEvangelist
nice!
Brandon Nozaki Miller
@RIAEvangelist
UGK! Just did a rebase in PizzaPI branch to get us all on the same branch. Worst experience ever.
Make sure to do a git pull!
Brandon Nozaki Miller
@RIAEvangelist
If you dont have the gitter app for your phone you should get it.
Some of the tests are failing, should we create issues to address each one so we can split the load of addressing them?
Brandon Nozaki Miller
@RIAEvangelist
Whats the diff between tests and test dirs?
Madeline Cameron
@madelinecameron
Ahh sorry, I just noticed your messages on GitHub. I'll put it on tonight. My phone is really bad so it wouldn't matter anyway. My phone can barely keep a charge.
The 'test' directory should be the one the tests are in. The difference is that mocha looks for the 'test' directory automatically if I recall correctly.
Brandon Nozaki Miller
@RIAEvangelist
K so I can remove the tests dir then?
Madeline Cameron
@madelinecameron
Sure, wasn't even aware it had kept it there. Forget that Git doesn't keep track of directory / file name changes (like when it didn't realize I had changed file name cases)