Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 06 01:29
    odog2454 commented #122
  • May 05 04:24
    RIAEvangelist commented #122
  • May 05 02:08
    odog2454 commented #122
  • May 05 00:45
    odog2454 commented #122
  • May 04 23:45
    odog2454 commented #122
  • May 04 23:45
    odog2454 commented #122
  • May 04 23:40
    odog2454 commented #122
  • Mar 14 03:45
    ElijahPepe commented #128
  • Mar 14 02:47
    ElijahPepe commented #128
  • Mar 14 02:41
    ElijahPepe commented #128
  • Feb 28 18:47
    RIAEvangelist commented #76
  • Feb 28 18:40
    brybalicious commented #76
  • Feb 24 12:35
    brybalicious commented #76
  • Feb 23 03:36
    Nestrixx opened #128
  • Feb 22 03:50
    RIAEvangelist commented #76
  • Feb 17 12:24
    brybalicious commented #76
  • Feb 17 12:24
    brybalicious commented #76
  • Feb 15 08:08
    RIAEvangelist commented #76
  • Feb 15 08:07
    RIAEvangelist commented #76
  • Feb 14 00:46
    brybalicious commented #76
Madeline Cameron
@madelinecameron
Definitely. My README was a huge hack together and was just adapting yours to my changes.
Brandon Nozaki Miller
@RIAEvangelist
Also, I would like to put the package quality up in the read me, hopefully after your next publish, the git link going to our repo will bump up the rating. you can see it here : http://packagequality.com/#?package=pizzapi
dominos was 4.5 stars I think this one should get there as well.
Madeline Cameron
@madelinecameron
Oh yikes, that rating. What determines the rating?
Brandon Nozaki Miller
@RIAEvangelist
some of it has to do with contributors, issues, some responsiveness to issues. the git repo, and versioning.
versioning is pretty big.
Madeline Cameron
@madelinecameron
Ahh okay, so just having an active repo is what gets your rating up. What do you mean by versioning?
Like how does that factor in? Having a higher version is better? Or just having frequent 'releases' is good?
Higher version = better would be super weird, haha
Brandon Nozaki Miller
@RIAEvangelist
There are some rules to versioning, like when to itterate certain numbers, backwards compatibility etc.
Madeline Cameron
@madelinecameron
Oh okay. That's cool. So just handling versioning correctly.
Brandon Nozaki Miller
@RIAEvangelist
lol no not related to higher version, but if say you released version 0.1.1 and then 0.0.5 in that order
that would have a major impact.
Once this next build is ready and we do a review, I think I would be good to going to v 1. however many 0s you used.
yeah, just proper versioning
Madeline Cameron
@madelinecameron
major.minor.patch is what I used, I believe. But yeah, if I can get tests for everything working and passing, I'd be cool with declaring it 1.0.0.
Brandon Nozaki Miller
@RIAEvangelist
nice!
Brandon Nozaki Miller
@RIAEvangelist
UGK! Just did a rebase in PizzaPI branch to get us all on the same branch. Worst experience ever.
Make sure to do a git pull!
Brandon Nozaki Miller
@RIAEvangelist
If you dont have the gitter app for your phone you should get it.
Some of the tests are failing, should we create issues to address each one so we can split the load of addressing them?
Brandon Nozaki Miller
@RIAEvangelist
Whats the diff between tests and test dirs?
Madeline Cameron
@madelinecameron
Ahh sorry, I just noticed your messages on GitHub. I'll put it on tonight. My phone is really bad so it wouldn't matter anyway. My phone can barely keep a charge.
The 'test' directory should be the one the tests are in. The difference is that mocha looks for the 'test' directory automatically if I recall correctly.
Brandon Nozaki Miller
@RIAEvangelist
K so I can remove the tests dir then?
Madeline Cameron
@madelinecameron
Sure, wasn't even aware it had kept it there. Forget that Git doesn't keep track of directory / file name changes (like when it didn't realize I had changed file name cases)
Worst case, we can add or remove an 's'.
Brandon Nozaki Miller
@RIAEvangelist
kl
Madeline Cameron
@madelinecameron
And I have all of the tests locally.
Brandon Nozaki Miller
@RIAEvangelist
you camn force it to track such changes by using git add -A
I'll remove now
Madeline Cameron
@madelinecameron
Hmm. I'll have to look into that. I am a bit of a newb at Git and still use an app.
Brandon Nozaki Miller
@RIAEvangelist
no biggy my ide does that stuff for me manually. I used to be hard core terminal only. I use brackets now.
Madeline Cameron
@madelinecameron
Oh that looks really awesome. I use Atom pretty exclusively. I used to use IDEs but I just didn't care or need them enough to justify spending money on a nice one.
Brandon Nozaki Miller
@RIAEvangelist
Yeah, I have never paid for one.
Madeline Cameron
@madelinecameron
Brackets seems like a bit of a step-up from Atom. Atom is sort of clunky and weird in my opinion but it works as a text editor.
Brandon Nozaki Miller
@RIAEvangelist
Some of the guys I worked with forced me from vim to netbeansd then I went to cloud nine, and back to netbeans and now Ive been on brackets for a wile.
yeah, I tried atom for a week but preferred brackets
I actually tried atom twice just to give it a fair shake.
brackets plugins are the bomb.
git, term etc.
Madeline Cameron
@madelinecameron
Brackets is for windows as well?
Brandon Nozaki Miller
@RIAEvangelist
FYI im debugging the Address test.
Madeline Cameron
@madelinecameron
They don't do a great job at advertising it... but it is giving me an .msi
Oh okay.
It works on my machine. The test that is failing for me is pricing.
Let me know what is going wrong with it because I wrestled with two of those tests for a while to get working.
Brandon Nozaki Miller
@RIAEvangelist

can you make sure you have pushed the most recent tests?

I'm thinking moving away from prototypical objects to oop defined Class objects might be really good.

I will convert the Address.js Class and then we can discuss.

Madeline Cameron
@madelinecameron
The issue I found and this is a total guess / assumption is Javascript is weird about concatenating strings together so those strings aren't equal. Or it is mocha.
Brandon Nozaki Miller
@RIAEvangelist
That cool with you?