Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 02:21
    RIAEvangelist closed #126
  • 02:20
    RIAEvangelist commented #126
  • Jan 19 04:20
    bobmartins79 edited #126
  • Jan 19 04:16
    bobmartins79 opened #126
  • Jan 15 03:49
    RIAEvangelist commented #122
  • Jan 15 03:44

    RIAEvangelist on 3.3.1

    (compare)

  • Jan 15 03:41
    RIAEvangelist labeled #125
  • Jan 15 03:41
    RIAEvangelist assigned #125
  • Jan 15 03:41
    RIAEvangelist opened #125
  • Jan 15 03:33

    RIAEvangelist on master

    updated contributors added @ro… (compare)

  • Jan 15 03:29
    dependabot[bot] labeled #124
  • Jan 15 03:29
    dependabot[bot] opened #124
  • Jan 15 03:29

    dependabot[bot] on npm_and_yarn

    Bump ansi-regex from 5.0.0 to 5… (compare)

  • Jan 15 03:28

    RIAEvangelist on master

    Expose utils/urls as an export … Merge pull request #123 from ro… (compare)

  • Jan 15 03:28
    RIAEvangelist closed #123
  • Jan 15 03:28
    RIAEvangelist closed #120
  • Jan 12 19:34
    robbieaverill opened #123
  • Jan 06 17:06
    That-Half-Dead-Skeleton opened #122
  • Jan 05 06:31
    RIAEvangelist commented #121
  • Dec 14 2021 20:14
    RIAEvangelist commented #121
Brandon Nozaki Miller
@RIAEvangelist
UGK! Just did a rebase in PizzaPI branch to get us all on the same branch. Worst experience ever.
Make sure to do a git pull!
Brandon Nozaki Miller
@RIAEvangelist
If you dont have the gitter app for your phone you should get it.
Some of the tests are failing, should we create issues to address each one so we can split the load of addressing them?
Brandon Nozaki Miller
@RIAEvangelist
Whats the diff between tests and test dirs?
Madeline Cameron
@madelinecameron
Ahh sorry, I just noticed your messages on GitHub. I'll put it on tonight. My phone is really bad so it wouldn't matter anyway. My phone can barely keep a charge.
The 'test' directory should be the one the tests are in. The difference is that mocha looks for the 'test' directory automatically if I recall correctly.
Brandon Nozaki Miller
@RIAEvangelist
K so I can remove the tests dir then?
Madeline Cameron
@madelinecameron
Sure, wasn't even aware it had kept it there. Forget that Git doesn't keep track of directory / file name changes (like when it didn't realize I had changed file name cases)
Worst case, we can add or remove an 's'.
Brandon Nozaki Miller
@RIAEvangelist
kl
Madeline Cameron
@madelinecameron
And I have all of the tests locally.
Brandon Nozaki Miller
@RIAEvangelist
you camn force it to track such changes by using git add -A
I'll remove now
Madeline Cameron
@madelinecameron
Hmm. I'll have to look into that. I am a bit of a newb at Git and still use an app.
Brandon Nozaki Miller
@RIAEvangelist
no biggy my ide does that stuff for me manually. I used to be hard core terminal only. I use brackets now.
Madeline Cameron
@madelinecameron
Oh that looks really awesome. I use Atom pretty exclusively. I used to use IDEs but I just didn't care or need them enough to justify spending money on a nice one.
Brandon Nozaki Miller
@RIAEvangelist
Yeah, I have never paid for one.
Madeline Cameron
@madelinecameron
Brackets seems like a bit of a step-up from Atom. Atom is sort of clunky and weird in my opinion but it works as a text editor.
Brandon Nozaki Miller
@RIAEvangelist
Some of the guys I worked with forced me from vim to netbeansd then I went to cloud nine, and back to netbeans and now Ive been on brackets for a wile.
yeah, I tried atom for a week but preferred brackets
I actually tried atom twice just to give it a fair shake.
brackets plugins are the bomb.
git, term etc.
Madeline Cameron
@madelinecameron
Brackets is for windows as well?
Brandon Nozaki Miller
@RIAEvangelist
FYI im debugging the Address test.
Madeline Cameron
@madelinecameron
They don't do a great job at advertising it... but it is giving me an .msi
Oh okay.
It works on my machine. The test that is failing for me is pricing.
Let me know what is going wrong with it because I wrestled with two of those tests for a while to get working.
Brandon Nozaki Miller
@RIAEvangelist

can you make sure you have pushed the most recent tests?

I'm thinking moving away from prototypical objects to oop defined Class objects might be really good.

I will convert the Address.js Class and then we can discuss.

Madeline Cameron
@madelinecameron
The issue I found and this is a total guess / assumption is Javascript is weird about concatenating strings together so those strings aren't equal. Or it is mocha.
Brandon Nozaki Miller
@RIAEvangelist
That cool with you?
Madeline Cameron
@madelinecameron
Besides not using prototype.
Uhh, I hope this isn't a dumb question but isn't prototype + function basically oop. I looked in 'oop javascript' and prototypes seemed like the way to go. What I am asking is what will be the difference?
And my message is going to be weirdly ordered, I think.
Yeppp
'function'
Brandon Nozaki Miller
@RIAEvangelist
I'm not a big fan of prototype, its only one way to do oop, but it can obfuscate the shit out of stuff for jr devs. especially with inheritance.
I'll just do one Class and then we can discuss
I'll do it in one commit so if you don't like it we can revert.
Madeline Cameron
@madelinecameron
Yeah definitely. I am interested. I wasn't entirely aware that Javascript had inheritance. I was under the impression that Javascript was sort of faux oop. That a lot of traditional oop things weren't actually present in Javascript.
Brandon Nozaki Miller
@RIAEvangelist
Pretty much thats correct. Primary reason for doing this is that the way the prototypical objects are set up now is fucking with the scope of 'this'
Madeline Cameron
@madelinecameron
Ahh okay. Yeah, change away. I am interested to see if it can make things a bit more sane, especially as additional features get added.
Brandon Nozaki Miller
@RIAEvangelist
Pretty sane, though I don't know many other devs who have gone this route. I LOVE it. it defines stuff clearly.
Madeline Cameron
@madelinecameron
oop in general or the new method we might change to?
Brandon Nozaki Miller
@RIAEvangelist
new method
Madeline Cameron
@madelinecameron
Oh okay
Brandon Nozaki Miller
@RIAEvangelist
K if you do a git pull on the PI branch you will see the new Address Class.
Tell me what you think.