Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Göran Lundberg
@ageir
Will try to learn how it works for the next pull request. :)
Danilo Bargen
@dbrgn
no problem.
it's good practice to create a new branch for every feature or fix, then they can be handled independently.
also, it allows you to update your master to the same state as upstream master without affecting any of your commits.
Göran Lundberg
@ageir
ah, thanks. will look at it.
Göran Lundberg
@ageir
What is the standard i2c address of the PCF8574?
Adding it as an example in the tests.
Makes it easy to copy paste.
Danilo Bargen
@dbrgn
probably depends on the module, it can be configured. but I'll look up the address I used...
0x27
Göran Lundberg
@ageir
ok, thanks
Göran Lundberg
@ageir
I'm not happy with the name of the tests. I started with only "charmap" and "format" but "charmap" is also an option so its confusing. Any suggestions? Should be an easy standard naming.
Also the name of the test directory "lcdtests" should maybe be renamed to "lcdtest-modules" or similar. Any ideas?
Danilo Bargen
@dbrgn
I think the directory name is fine.
Also, what about "show_charmap" and "testsuite"?
Göran Lundberg
@ageir
Okay let's go with lcdtests
Testsuite works!
Also, I think that test name maybe should go before i2c/gpio.
lcdtest.py show_charmap i2c expander=MCP23017......
Danilo Bargen
@dbrgn
depends. showing help by just writing "lcdtest.py i2c" is nice
I think the numbering mode should go before the pins though.
(in the examples)
Göran Lundberg
@ageir
True.
Göran Lundberg
@ageir
@dbrgn I just pushed a lot of new changes. Can you have a look when you have the chance. Some things I'm not so happy about how I solved it, but could't find a better solution. Mainly the error checking. Hope you have some ideas.
Göran Lundberg
@ageir
I added some comments to the code.
Göran Lundberg
@ageir
@paulenuta Please add support in the tests for your display size when the new test system is in the main branch :)
Danilo Bargen
@dbrgn
@GoranLundberg I left 4 more comments.
we can always improve later :)
Göran Lundberg
@ageir
Ah, I'll take a look.
Göran Lundberg
@ageir
Fixed!
Göran Lundberg
@ageir
Found some more to fix :P Sorry
Sorry about the 'all fixes in one' pull request. Will try to make a new PR for each in the future.
Göran Lundberg
@ageir
@dbrgn I got some PCF8574 backpacks from Ali yesterday. :) How do I connect these? Do I need a level shifter to connect it to the Pi? or just feed it with 5v/GND/SDA/SCL directly from the Pi?
Paul
@paulenuta
@GoranLundberg - using a level shifter is the correct and safest way! But I have done some short test the way you said and also by providing 3.3V instead of 5V (display won't look really good and you need to adjust contrast) whis is safer for the Pi. Also on Adafruit MCP23008 I cut the power pin from MCP to add 2 x 1N4148 diodes between 5V rail and MCP power pin and I removed the pull-up's on I2C from the backpack.
Göran Lundberg
@ageir
That's what I thought. I'm using a level shifter with the adafruit backpack.
Danilo Bargen
@dbrgn
I got some new displays (a 20 cm wide 20x4 LCD and a 2x40 LCD), will try the current code version with that when I find some time.
Göran Lundberg
@ageir
Cool. I got a big 20x4 as well :)
Danilo Bargen
@dbrgn
Danilo Bargen
@dbrgn
@GoranLundberg just merged your branch - finally :)
Danilo Bargen
@dbrgn
I'll do a release tonight. I'm AFK for around 2-3 hours, will do it afterwards. Let me know if you tink something's missing that should go into the release.
By the way, I plan to make this a 1.0.0 release.
(And yes, CI is currently broken, I'll fix that before the release.)
Danilo Bargen
@dbrgn
I'll also remove enums in this release. Makes it easier to port to MicroPython.
Danilo Bargen
@dbrgn
1.0.0 is released :sparkles:
Danilo Bargen
@dbrgn
Göran Lundberg
@ageir
Cool! Have to check it out!
You got a typing error on the reddit post. Says mcp23014 instead of mcp23017
Also in the changelog