I would like to contirbute to RxJs, and I know the dtslint test need to be improve.
My simple question - do dtslint test should have tests with Generic?
Another question, but I know it's complicated to find out, but still, what operators is outdated in the dtslint tests? I asume thats some that is not being updated about a year.
FooEvents. I want to continuely call/update
ListFoosuntil a user selects one. Then I want to make repeated calls to
FooEventswith an (offset,maxEvents) creating a new stream of events`
Another quick question -- if I have a subject (a state subject, for example) should I be completing and/or unsubscribing from it directly when I want to destroy it? Or is unsubbing all subscribers sufficient?
Unsubscribe and complete have different effects. Compete would terminate all other subscribers too, but if your subscribers have inner streams (like inside a switchMap), those might keep going for a bit longer.
There is also a third option to use
takeUntil to unsubscribe.
No need to do both. Either complete it to let it shut down gracefully or unsubscribe to put an instant stop to the stream. (It wont terminate anything, but operators will no longer call their followup, ignoring a few exceptions like
finalize). (Doing both wont harm but it's not needed either.)