I think I figured out when I have time to pop over to the valley from san francisco.
seems I only have Ben's email, so will shoot there with details and hope he can connect us, would be very nice to meet even if just for a short coffee :)
Has anyone been following Jacob's reactive socket Go impl? https://github.com/jakewins/reactivesocket-go
It seems like he's gotten a bunch of TCK tests passing
I'm going to assume, based on this, that you're a good bet for asking this: What is the message the
Responder should send to cancel the remote stream in a channel?
@jakewins I am assuming you are asking about the cancellation of response Publisher?
Since the response is subscribed to by the Requester, cancellations flow from the Requester as a Cancel frame.Responder may send Reject error frame if it does not want to process the request any further.
This section: https://github.com/ReactiveSocket/reactivesocket/blob/master/Protocol.md#request-response explains some interactions.
Eg:
Requester sends RequestChannel[..], opening two streams, one sending events Responder->Requester the same way a regular RequestStream would, and the other sending events Requester->Responder
Lets say, on the
Responder side, application code does something like: function handleRequestChannel(in) {
in.subscribe({
onSubscribe:(subscription) {
subscription.cancel()
}
})
}
Eg. on the responder side, I cancel the publisher I got from the requester - does that translate to a
Cancel frame as well?
There's plenty of TODOs in there, and an overall problem I didn't (as a novice Go developer) anticipate - Go does not deal very comfortably with the Reactive Streams API
As in - it implements it just fine, but async programming is strictly frowned upon; since go threads are mega cheap, blocking code is idiomatic (and, performance wise, what the compiler optimizes for)
Which is all to say - as I learn more about Go, I'm likely to go back and change the API approach. For now though, this is enough for what I needed
But, hmmm... maybe porting rs would be a good first step :)
@yschimke I want to use rsocket-java and I am still getting familiar with the concepts here.
I one question that currently bothers me is that according to the spec (https://github.com/rsocket/rsocket/blob/master/Protocol.md#negotiation) a server should
be able to reject a setup which should result in sending REJECTED_SETUP error sent to the client.
I would expect this to happen if the
I one question that currently bothers me is that according to the spec (https://github.com/rsocket/rsocket/blob/master/Protocol.md#negotiation) a server should
be able to reject a setup which should result in sending REJECTED_SETUP error sent to the client.
I would expect this to happen if the
SocketAcceptor returns Mono.error, but currently this is not the case.
I saw you raised a bug, I'm not sure, but I wouldn't be surprised if it's missing. I think a lot of usage now is with specific knowledge of both client and server. Ideally it should be possible to reject, and it should be possible for the client to interpret the failure and renegotiate down. But I'm not surprised if it doesn't seem currently possible.
...and never closes them
We have a change proposal for RequestChannel function
we are planning to make the first payload in a channel a specific setup payload, that is delivered before and separate from the Flowable of requests.
As like requestStream(payload setupPayload), RequestChannel(payload setupPayload, Flowable input)
I think potentially we can make it just as efficient with some other tweaks e.g. if we allow presending following request frames in some form, then we could have a fast start with everything coming in the first network packet.
Hey,
I am trying to use rsocket-websocket-client and rsocket-core from https://github.com/rsocket/rsocket-js
It's a nightmare to configure flow, did anybody had experience with it?
Thanks in adavance
cc @lexs who works on rsocket-js
It's not helping me to much
I meant configure https://flow.org/
I getting:
Error: src/scalecube-transport/provider/RSocketProvider.js:2
2: import RSocketWebSocketClient from 'rsocket-websocket-client';
^^^^^^^^^^^^^^^^^^^^^^^^^^ rsocket-websocket-client. Required module not found
Error: src/scalecube-transport/provider/RSocketProvider.js:4
4: import { JsonSerializers, RSocketClient } from 'rsocket-core';
^^^^^^^^^^^^^^ rsocket-core. Required module not foundI tried flow-typed, those packages not there
I also tried to use the .js.flow files in the project, but I wasn't able to config it to work without // $FlowFixMe
They are referenced in both the demo project and facebook/flipper e.g. https://github.com/yschimke/rsocket-demo/blob/master/package.json#L16-L17 and https://github.com/facebook/flipper/blob/master/package.json#L70-L71
