Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 24 02:06
    smaldini opened #262
  • Nov 26 2018 17:21

    robertroeser on master

    Routing (#254) This change add… (compare)

  • Nov 26 2018 17:21
    robertroeser closed #254
  • Nov 26 2018 16:55
    nebhale synchronize #254
  • Nov 21 2018 04:19
    robertroeser commented #261
  • Nov 21 2018 01:45
    yangjun opened #261
  • Nov 20 2018 01:48
    spencergibb commented #254
  • Nov 16 2018 18:40

    robertroeser on master

    fix typo (#260) (compare)

  • Nov 16 2018 18:40
    robertroeser closed #260
  • Nov 15 2018 23:17
    OlegDokuka opened #260
  • Nov 13 2018 22:17

    robertroeser on master

    64-bit Trace Id (#259) Previou… (compare)

  • Nov 13 2018 22:17
    robertroeser closed #259
  • Nov 05 2018 19:12
    szihai commented #254
  • Nov 05 2018 18:53
    nebhale synchronize #259
  • Nov 05 2018 17:37
    nebhale review_requested #259
  • Nov 05 2018 17:37
    nebhale review_requested #259
  • Nov 05 2018 17:37
    nebhale opened #259
  • Nov 05 2018 17:37
    nebhale assigned #259
  • Nov 05 2018 17:17
    nebhale commented #256
  • Nov 04 2018 00:08
    adriancole commented #256
Konrad `ktoso` Malawski
@ktoso
oh great, so see you at the summit as well :)
I think I figured out when I have time to pop over to the valley from san francisco.
seems I only have Ben's email, so will shoot there with details and hope he can connect us, would be very nice to meet even if just for a short coffee :)
Martin
@xytosis
Has anyone been following Jacob's reactive socket Go impl? https://github.com/jakewins/reactivesocket-go
It seems like he's gotten a bunch of TCK tests passing
Jacob Hansson
@jakewins
Not much to see there yet until I get some docs up; but it's getting closer I think, the Java Client TCK runs and completes with just a few minor complaints now
Jacob Hansson
@jakewins
@tmontgomery in Requester.java#640 there's some code that git says you wrote that deals with cancelling the "local" outbound stream in a channel, from the Requester pov
I'm going to assume, based on this, that you're a good bet for asking this: What is the message the Responder should send to cancel the remote stream in a channel?
Nitesh Kant
@NiteshKant

@jakewins I am assuming you are asking about the cancellation of response Publisher?
Since the response is subscribed to by the Requester, cancellations flow from the Requester as a Cancel frame.
Responder may send Reject error frame if it does not want to process the request any further.

This section: https://github.com/ReactiveSocket/reactivesocket/blob/master/Protocol.md#request-response explains some interactions.

Jacob Hansson
@jakewins
I think (though I'm admittedly tripping myself up with the directionality a bit) I mean the opposite
Eg: Requester sends RequestChannel[..], opening two streams, one sending events Responder->Requester the same way a regular RequestStream would, and the other sending events Requester->Responder
Lets say, on the Responder side, application code does something like:
function handleRequestChannel(in) {
  in.subscribe({
    onSubscribe:(subscription) {
      subscription.cancel()
    }
  })
}
Eg. on the responder side, I cancel the publisher I got from the requester - does that translate to a Cancel frame as well?
Jacob Hansson
@jakewins
Doh, I see it now, it's clearly stated in the section you linked to, thanks @NiteshKant
Nitesh Kant
@NiteshKant
@jakewins Yes for request-channel, cancellations can flow both ways!
Jacob Hansson
@jakewins
Happy to say the little Go implementation I've been working on now passes all the tests in the TCK, for both server and client implementation :) I've updated the README to include some examples for Gophers wanting to use ReactiveSocket
There's plenty of TODOs in there, and an overall problem I didn't (as a novice Go developer) anticipate - Go does not deal very comfortably with the Reactive Streams API
As in - it implements it just fine, but async programming is strictly frowned upon; since go threads are mega cheap, blocking code is idiomatic (and, performance wise, what the compiler optimizes for)
Which is all to say - as I learn more about Go, I'm likely to go back and change the API approach. For now though, this is enough for what I needed
Todd L. Montgomery
@tmontgomery
@jakewins congrats! nice work!
Nitesh Kant
@NiteshKant
@jakewins nice!!!
David Hooker
@dudehook
Any C#/.NET implementation of reactivesockets?
Ben Christensen
@benjchristensen
Not that I'm aware of. If you're interested in tackling it we can start a repo for you?
David Hooker
@dudehook
Actually, looking to bridge some middleware (akka) between JVM/.NET, and reactivesockets looks like a good pipe
But, hmmm... maybe porting rs would be a good first step :)
David Hooker
@dudehook
I'll run this by my .NET folks, see if they have an appetite to take on a port of this.
Vladimir Tsanev
@tsachev
I see tha rsocket-cli has http2 streams client. But is there any server I can try it against?
Yuri Schimke
@yschimke
@tsachev Nope - I wouldn't consider it an official definition of rsocket over http2 yet. It's currently just a proprietary approach using RSocket TCP stream over a HTTP/2 stream. In contrast you could have an approach where each RSocket frame is a HTTP/2 frame.
Vladimir Tsanev
@tsachev
I see
@yschimke I want to use rsocket-java and I am still getting familiar with the concepts here.
I one question that currently bothers me is that according to the spec (https://github.com/rsocket/rsocket/blob/master/Protocol.md#negotiation) a server should
be able to reject a setup which should result in sending REJECTED_SETUP error sent to the client.
I would expect this to happen if the SocketAcceptor returns Mono.error, but currently this is not the case.
Vladimir Tsanev
@tsachev
Is it currently possible to reject a setup?
Yuri Schimke
@yschimke
I saw you raised a bug, I'm not sure, but I wouldn't be surprised if it's missing. I think a lot of usage now is with specific knowledge of both client and server. Ideally it should be possible to reject, and it should be possible for the client to interpret the failure and renegotiate down. But I'm not surprised if it doesn't seem currently possible.
Vladimir Tsanev
@tsachev
thanks. I need a way to detect something is wrong with the setup request on the client side, but I do not see a way to detect that now am I missing something. i.e. detect a situation where server accept connections but never responds to them.
...and never closes them
Fuat Geleri
@phoad
Hi, I am Fuat Geleri. I work at Facebook, mainly on RSocket cpp library.
We have a change proposal for RequestChannel function
we are planning to make the first payload in a channel a specific setup payload, that is delivered before and separate from the Flowable of requests.
As like requestStream(payload setupPayload), RequestChannel(payload setupPayload, Flowable input)
Yuri Schimke
@yschimke
I suggest we make the same change for the rsocket-java library because it seems like a common pattern, using the first frame of the channel for routing & setup.
I think potentially we can make it just as efficient with some other tweaks e.g. if we allow presending following request frames in some form, then we could have a fast start with everything coming in the first network packet.
Fuat Geleri
@phoad
Let me send an initial attempt to demonstrate the change on the rsocket-java.
Fuat Geleri
@phoad
rsocket/rsocket-java#465 - created an issue to further discuss it there too. thanks @yschimke
Idan Levin
@idanilt

Hey,
I am trying to use rsocket-websocket-client and rsocket-core from https://github.com/rsocket/rsocket-js
It's a nightmare to configure flow, did anybody had experience with it?

Thanks in adavance

Yuri Schimke
@yschimke
@idanilt not sure if still relevant, I'm using it here https://github.com/yschimke/rsocket-demo
cc @lexs who works on rsocket-js
Idan Levin
@idanilt
Thanks @yschimke I will check it
Idan Levin
@idanilt

It's not helping me to much
I meant configure https://flow.org/
I getting:

Error: src/scalecube-transport/provider/RSocketProvider.js:2
  2: import RSocketWebSocketClient from 'rsocket-websocket-client';
                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ rsocket-websocket-client. Required module not found

Error: src/scalecube-transport/provider/RSocketProvider.js:4
  4: import { JsonSerializers, RSocketClient } from 'rsocket-core';
                                                    ^^^^^^^^^^^^^^ rsocket-core. Required module not found

I tried flow-typed, those packages not there
I also tried to use the .js.flow files in the project, but I wasn't able to config it to work without // $FlowFixMe

Yuri Schimke
@yschimke
Konstantin Bläsi
@konstantinblaesi
are there examples of rsocket with graphql?