i.e. the text box appeared under a different line than clicked
I didn't play with changing diffs
offset was constant
something like 10 lines above
in a file which was almost completely rewritten in this PR
side-by-side diff, with one-file-at-a-time enabled
didn't try different sides
unfortunately this was a priority fix, so I didn't experiment too much and just reloaded and finished the review
ok, I managed to repro this again
so, it happens only on the right side of the diff, left is fine
the first few lines of the file works
and then the further in the file I place it the bigger the drift is
I checked a few more files with the same diff range and they work fine (but they have much less changes, the one where this got triggered was almost completely rewritten)
other diff ranges in this particular file are also broken
basically, it seems that somehow it get the lines number from the left file and the puts the comment at this line in the right file
what's interesting, is that the revision number at the comment seems correct - it's placed at the revision which is shown on the right, but, it's displayed in red, not in blue
despite being the newest existing
also, this "r??" at the top is worrying :)
(ah, maybe not, because other file have different ranges selected)
let's go to priv maybe, to not spam here
?
I am begin to work in this tool.
Hi @felipe636, our onboarding flow isn't great yet, but there's contextual help throughout the app (just hit F1 or
h), and there's a full user manual at https://docs.reviewable.io.
Hi @pkaminski quick question. I see the following user https://github.com/NixDevXMP in the review, but I don't see him in Github dashboard of the PR and this is internal repo so It couldn't be someone from outside, any idea?
@esakal If you let me know which PR this is I can check our database to find out why this user got pulled. Often it's because they got accidentally @-mentioned -- Reviewable is pretty naïve about parsing things that look like mentions. In any case, there's no need to worry about leaking information, as both GitHub and Reviewable will enforce your repo's permissions, and Reviewable doesn't send any notifications of its own.
Only if you put a discussion on it ATM. The larger issue of how to address arbitrary lines is still outstanding: Reviewable/Reviewable#147
The vanishing comments issue stopped happening, or so it seems. It wasn't very frequent to begin with, and now I haven't seen it for quite a while.
@pkaminski I think the entire
reviewable.io is down.
@feldgendler Yeah, there was a Firebase Hosting issue earlier that was resulting in 503 errors. Everything should be ok now -- sorry for the inconvenience!
https://status.firebase.google.com/incidents/CwDdn12D5GF6nXewEvUu
https://status.firebase.google.com/incidents/CwDdn12D5GF6nXewEvUu
Hi! I filed Reviewable/Reviewable#841 but I'm afraid the problematic PR might not stay long in its current state.
OK, captured as well. Hopefully we won't need anything more to debug.
Hello. I think I have a quite simple question: How do I add reviewers to my PR from within the reviewable interface?
1 reply