Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 16 13:57
    Server build 3000 deployed
  • Apr 15 15:03
    Client build 4731 deployed
  • Apr 15 14:09
    Server build 2999 deployed
  • Apr 15 06:44
    pkaminski closed #690
  • Apr 15 06:44
    pkaminski commented #690
  • Apr 15 03:05
    Client build 4729 deployed
  • Apr 14 17:13
    Client build 4728 deployed
  • Apr 14 17:08
    Server build 2997 deployed
  • Apr 14 16:35
    Client build 4727 deployed
  • Apr 14 14:36
    Server build 2996 deployed
  • Apr 14 14:25
    Client build 4726 deployed
  • Apr 12 23:06
    anthonykawa assigned #825
  • Apr 12 11:52
    Server build 2990 deployed
  • Apr 12 11:43
    Client build 4719 deployed
  • Apr 08 11:56
    Server build 2988 deployed
  • Apr 07 15:53
    pkaminski edited #798
  • Apr 07 15:53
    pkaminski commented #798
  • Apr 07 15:52
    pkaminski closed #804
  • Apr 06 03:08
    pkaminski commented #507
  • Apr 06 03:04
    pkaminski labeled #827
Piotr Kaminski
@pkaminski
Um. So GitHub isn't returning any PRs for us to display.
For that request, can you find the query being issued (as the q0 variable) and see what running it directly in GitHub's search box gives you?
It should be something like involves:pkaminski org:reviewable type:pr state:open.
Amir Hardon
@amirh
Interesting, the query is: involves:amirh org:robust intelligence type:pr state:open and our org name is RobustIntelligence
when I manually search for that I get nothing as well
Piotr Kaminski
@pkaminski
OMG, you can have spaces in an org name!?
Amir Hardon
@amirh
if I edit the query and remove the space it finds PRs
we don't have spaces!
Piotr Kaminski
@pkaminski
That looks like a bug on our side then. We're probably grabbing the wrong string -- one has spaces, one doesn't.
Amir Hardon
@amirh
yeah
It worked well last week so probably something fairly new?
Piotr Kaminski
@pkaminski
Nope, no recent changes pushed there from our side. Perhaps GitHub got fancy and started segmenting camelcase org names itself.
Amir Hardon
@amirh
interesting
Piotr Kaminski
@pkaminski
Does it show with a space in the dropdown at the top of the page?
Amir Hardon
@amirh
BTW is there some trick to quickly start a review in reviewable? I'm a new user, and my flow so far was to go to that reviews tab in reviewable.io and find the PR I want to review... though ideally I'd want to have a reviewable review one click a way from the GitHub PR page
it does
Piotr Kaminski
@pkaminski
If you connect the repo to Reviewable then a link should get inserted into the PR description automatically. (Only a repo admin can configure this, though.)
Amir Hardon
@amirh
I only saw that link for PRs for which we already started a reviewable review...
Piotr Kaminski
@pkaminski
If the repo is connected the reviews will start automatically. Look on the https://reviewable.io/repositories page and make sure the toggle for the desired repo(s) is green.
Amir Hardon
@amirh
Also I'm not sure I'll want that button on all PRs by default, we're kind of trying out reviewable, at this stage (and probably for some time) reviewable is going to be opt-in so people who prefer GitHub PR UI can keep using that
Piotr Kaminski
@pkaminski
Ah, then clicking through from the dashboard is your best bet. I'm working on a bugfix right now.
Amir Hardon
@amirh
thanks!
I was hoping for some JS bookmark thingy that will open the current PR in reviewable :) I guess I'll stick with the dashboard for now
Piotr Kaminski
@pkaminski
I mean, you can easily make one -- as you've noticed, the URL is quite straightforward. But most users just connect the repo.
Amir Hardon
@amirh
:thumbsup:
Piotr Kaminski
@pkaminski
@amirh OK, bugfix candidate pushed, can you reload the page and see if it helped?
Amir Hardon
@amirh
Doesn't seem to work, something did happen to the org name in the drop down box - it's all lower case now (still with the space) and the icon is not showing, search results are still empty
ohh actually
I have the org twice in the drop down
one of them works and the other doesn't
ok the issue does not reproduce anymore...
thanks!
Piotr Kaminski
@pkaminski
Yeah, you were still at the old URL so it was trying to shoehorn that broken org into the list. Once you click on the correct one you should be fine going forward.
Thanks for verifying!
Piotr Kaminski
@pkaminski
@sgp Post is finally up -- sorry, it's been a slightly crazy night. :) https://headwayapp.co/reviewable-changes/reverted-files-in-custom-review-completion-conditions-191987
Amir Hardon
@amirh
thanks @pkaminski !
Scott Parkerson
@sgp
Thanks, @pkaminski!
Amir Hardon
@amirh
I don't have repro steps but on a few occasions we ran into cases where a PR update is not fully reflected in reviewable, essentially for some of the files the latest version is not showing (it does show in the "snapshots list" only that the newest snapshot doesn't show a diff from the previous snapshot), it's can of transient in that after playing with the snapshot selection a little bit suddenly the change is showing.
Is that an issue you're aware of?
Dan Halperin
@dhalperi
FYI my connection to Firebase is down, but internet is up, github is fine, ...
Dan Halperin
@dhalperi
And in fact same for 3 others on my team
Amir Hardon
@amirh
same here
I gotta say, I was really hoping that reviewable will rescue me from the GitHub review UI which I feel is pretty bad.
I'm evaluating it for about 2 weeks now, and I was planning to push it across my company but I'm starting to have doubts regarding the maturity, running into 2 bugs in 2 weeks, one that can lead to missing parts of the change in a review (above), and now this:
image.png
Dan Halperin
@dhalperi
I'll say as a customer that we've been using reviewable for 4 years pretty happily. Firebase outage hasn't happened in a long time, and last time it did I think it was a Google outage not a Reviewable one :).
You may have been having bad luck :/
Yeah twitter seems to think Google Firebase itself is down: https://twitter.com/DayBackStatus/status/1383196877777117184
Amir Hardon
@amirh
I'll give it another chance, I really want this thing to work as I think the UI is so much better than GitHub, but the signals I'm getting so far makes me worry it will be causing lost of productivity
Piotr Kaminski
@pkaminski
@amirh Yeah, Firebase had a rare 35-40 minute outage last night: https://status.firebase.google.com/incident/Realtime%20Database/21003#21003001. They really don't happen very often at all these days, though Google's dashboard only extends to 30 days and I don't have a better chart to show you. You can expect a short outage once or twice a year, which is still better than GitHub itself. :p
As for delayed updates, if you still haven't connected the repo then you're subject to the limitations documented here, the major one being that a sync with GitHub will only be triggered once you visit the review and will take 5-10 seconds to update stuff. I'm not aware of any issues with diffs themselves -- I'd be happy to take a look if you can record a short screencast of this happening, but it's pretty core functionality that has been stable for years.
Amir Hardon
@amirh
Connected the repo fingers crossed things will be smooth now. Thanks.