Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

Reviewable/Reviewable

Support for Reviewable

People

Repo info

Activity

07:04

gaborvolczer opened #769
Aug 05 19:38

Server build 2411 deployed
Aug 05 19:27

Server build 2409 deployed
Aug 05 19:14

jwnimmer-tri commented #763
Aug 05 19:07

pkaminski commented #763
Aug 05 19:00

Server build 2407 deployed
Aug 05 18:54

pkaminski labeled #765
Aug 05 14:30

jwnimmer-tri commented #763
Aug 05 06:41

Server build 2405 deployed
Aug 05 06:29

Server build 2404 deployment failed
Aug 05 05:35

Server build 2402 deployed
Aug 04 15:54

dhbradshaw commented #768
Aug 04 15:51

dhbradshaw commented #767
Aug 04 15:07

dhbradshaw commented #767
Aug 04 15:05

dhbradshaw commented #767
Aug 04 14:20

dhbradshaw commented #767
Aug 03 12:14

N-Kass opened #768
Aug 03 12:00

N-Kass opened #767
Jul 31 12:56

Server build 2400 deployed
Jul 30 18:35

pkaminski commented #348

Belden Lyman

@belden

@pkaminski sent via email

Piotr Kaminski

@pkaminski

@belden Thanks. That's a pretty big PR, with a lot of additions/deletions. Chances are that Reviewable is just working hard to figure out what files got renamed -- this happens on the client. I'd recommend loading the page then walking away for lunch and chances are that it'll resolve itself. Once computed, the mapping is stored for all other clients to use.

Belden Lyman

@belden

@pkaminski weird, we've loaded much larger PRs in reviewable in the past without any issue -- the diff stat there is 20 files changed, 594 insertions(+), 41 deletions(-) which doesn't seem unduly large

Thanks for the "be patient" suggestion, I'll give it a whirl!

Piotr Kaminski

@pkaminski

It's the +594 / -41 that's killing Reviewable I think -- the algorithm is O(m*n).

7 replies

Though I dunno, it looks like there are 15 filemaps stored and 15 commits, so perhaps something else is going on. What does the status display say?

28 replies

Dan Halperin

@dhalperi

AFAICT there's no way to get reviewable to tag a github team? E.g., pushing {username: 'org/team-name'} into requiredReviewers?

Piotr Kaminski

@pkaminski

You mean pendingReviewers? No, these can only be individuals at this time.

Dan Halperin

@dhalperi

yeah that's what i meant. thanks.

Piotr Kaminski

@pkaminski

I think this discussion is related: Reviewable/Reviewable#348

AlonStark

@AlonStark

Hey, is anyone else having an issue with the Reviewable UI being too pale? I didn't have any problem with it before but today I can barely see any outlines our highlights on my reviews and it makes it incredibly hard to work with.

3 replies

Haihong Wang

@haihongwang

Hi, I am trying to find out what Reviewable can do vs. other reciew tools, like phabricator. This page https://stackshare.io/stackups/phabricator-vs-reviewable seems to have some comparison summary of the two tools. Is this complete? Anything else Reviewable can do that other tools can not do?

11 replies

Eric Romrell

@romrell4

I've had a number of PRs recently that say that they're out of date with the target branch, but if I got to the PR in github, they look fine. Thoughts?

7 replies

Screen Shot 2020-06-30 at 10.24.34 AM.png

Screen Shot 2020-06-30 at 10.24.20 AM.png

Dan Halperin

@dhalperi

Anything down with Reviewable? GitHub mentions 28 minutes of downtime earlier today but no outages; reviewable has not yellow or red github badge. Will not publish comments or pick up new PRs. "Request queued but server did not respond". Is there a way I can figure out on my own which server did not respond? Console doesn't have anything seemingly relevant.

Douglas H. Bradshaw

@dhbradshaw

Reviewable has been down for about 10+ minutes. I'm trying to understand what's going on. Github authorization seems to be failing for us and our servers are going haywire in response.

Douglas H. Bradshaw

@dhbradshaw

And we're back

Dan Halperin

@dhalperi

hmm, I am able to load reviews now but I still cannot publish comments

Piotr Kaminski

@pkaminski

Things broke again. Anything that requires the server to speak to GitHub is timing out.

But it looks like it's fixed again as of a minute ago.

Something is flapping but I'm pretty sure it's out of our control. :(

Dan Halperin

@dhalperi

ack

Dan Halperin

@dhalperi

Another one of our GitHub services - Buildkite - went down at the same time and they deployed a fix to get back up. Not sure if it's a coincidence, or maybe github changed something on their end?

Piotr Kaminski

@pkaminski

I'm leaning towards that hypothesis as well. It looks a bit like each of our servers is fine when it's first brought up, and then after a few requests GitHub just goes AWOL.

Any idea what Buildkite did to work around, by any chance?

Dan Halperin

@dhalperi

No, I asked on their support channel

but no response

they're in australia so maybe only ops team is up

Dan Halperin

@dhalperi

I got a response:

hmm, I don’t think that issue is related to what we just experienced, it was all on our end

Piotr Kaminski

@pkaminski

Do they run in GCS by any chance?

Dan Halperin

@dhalperi

no, aws

Piotr Kaminski

@pkaminski

OK, thanks.

Douglas H. Bradshaw

@dhbradshaw

github it warning of temporarily degraded performance

linjc0

@linjc0

Piotr Kaminski

@pkaminski

@linjc0 Sorry about that -- there's nothing obviously wrong on our end, and no recent Firebase outages. Are you still having trouble?

linjc0

@linjc0

when i open "https://reviewable.io/", first it's ok, after about 10 seconds ,it responses blow message O F F L I N E
We'll get you reconnected as soon as possible.
Check @reviewableio for outage announcements.

Reason: no connection to Firebase

i want to know how to install the Reviewable code review tool, but the package i down from github can't find any install readme.

Piotr Kaminski

@pkaminski

@linjc0, Reviewable is a web-based app, so there's nothing to install. Are you running any extensions in your browser, particularly any that might block connections to "third party" sites? If so, you'll need to poke some holes in the firewall for Reviewable to work.

Alexey Feldgendler

@feldgendler

Hi! Reviewable seems to screw up certain character sequences in the diffs.

For example, the line line.AppendByte(']')

looks like

line.AppendByte(']')

35 replies

No. It's Go code. Those are ordinary apostrophes.

Emanuele Gaspari

@inmarelibero

hi all, the "Request Changes" under "PUBLISH" menu is disabled. I'd like to be available for everyone, regardless of users' permissions

how can I do?

Piotr Kaminski

@pkaminski

Hi Emanuele -- this ties into GitHub's approval functionality, and hence must respect its permissions. GitHub only allows collaborators to request changes or approve a PR.

Emanuele Gaspari

@inmarelibero

I'm admin of the repo, and created the PR

Piotr Kaminski

@pkaminski

You can't request changes on your own PR (another GitHub rule).

Alex Fedoseev

@alexfedoseev

Hi everyone! qq: if PR has 2 reviewers and one of the reviewers marks file X as reviewed. Will it be marked as reviewed for the second reviewer as well? Or it marked as reviewed exclusively for the reviewer who performed the action?

4 replies