Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 04 23:34
    feldgendler commented #886
  • Dec 04 23:33
    feldgendler commented #886
  • Dec 04 20:00
    pkaminski commented #886
  • Dec 04 10:38
    feldgendler commented #886
  • Dec 04 05:07
    pkaminski commented #886
  • Dec 03 22:49
    feldgendler commented #886
  • Dec 03 22:41
    pkaminski commented #887
  • Dec 03 22:18
    cgiroux86 commented #887
  • Dec 03 21:34
    pkaminski labeled #887
  • Dec 03 21:34
    pkaminski opened #887
  • Dec 03 21:23
    pkaminski labeled #886
  • Dec 03 20:56
    cgiroux86 commented #886
  • Dec 02 23:57
    pkaminski assigned #886
  • Dec 02 23:22
    feldgendler commented #886
  • Dec 01 19:11
    pkaminski commented #886
  • Dec 01 16:18
    feldgendler commented #886
  • Dec 01 07:36
    Server build 3354 deployed
  • Dec 01 07:25
    Server build 3353 deployed
  • Dec 01 07:18
    Server build 3352 deployed
  • Nov 30 23:57
    jwnimmer-tri commented #866
Alexey Feldgendler
@feldgendler
Hi! As of today, I noticed some PRs occasionally missing from “My Rewiews” that should be there. For example, an open PR that I created today.
It's fluctuating between showing up in “Awaiting my action” and not showing up anywhere at all.
Alexey Feldgendler
@feldgendler
I'm also occasionally getting “The list may be incomplete because GitHub returned partial results” above the list, but sometimes the PR is missing even though that message isn't showing.
Piotr Kaminski
@pkaminski
@feldgendler This appears to be a more widespread isssue -- please follow along in Reviewable/Reviewable#877.
MathewProkossonos
@MathewProkossonos
Quick question.. Can you add tags to reviews in reviewable? We have some actions that are based on tags.
Piotr Kaminski
@pkaminski
@MathewProkossonos Do you mean labels? You can add those by typing +<label name> into any comment and the label will be added when the comment is published.
MathewProkossonos
@MathewProkossonos
Yes labels
Then can you remove labels with -<label name> in another comment?
MathewProkossonos
@MathewProkossonos
But even with all this is there a way to see the status of all the labels on the PR? Its a reviewable item for us currently.
Piotr Kaminski
@pkaminski
Yup, - works as you'd expect. You can batch any number of those in a single comment, including mixed in with actual prose. Current labels are shown below the main discussion.
Sasha Sobol
@sasha-s
image.png
I am trying reviewable (after long gap when I could not use it) again, on a large PR (private repo).
I see Sorry, you've run out of GitHub API quota. when I try to view anything.
Piotr Kaminski
@pkaminski
Are you signed in @sasha-s? Just how large is the PR?
Sasha Sobol
@sasha-s
yes, signed in. 20+ files, 20+ commits
Piotr Kaminski
@pkaminski
That's not terribly large unless the "+" is really significant. Let me look up your current rate limit info on GH.
Your current quota levels look fine, are you still having issues? Did you do anything else that might have used up lots of quota in the hour where you were seeing the errors? (e.g., connect a repo with a lot of open PRs to Reviewable, set up some other GH tool that uses your account, etc.)
Sasha Sobol
@sasha-s

agree, not terribly large and the "+" is just couple thousand lines.
still having issues.

connect a repo with a lot of open PRs to Reviewable - a few hundred?

set up some other GH tool that uses your account: not that i know

Piotr Kaminski
@pkaminski
Hmm, that doesn't make sense then since you have plenty of quota left. Perhaps Reviewable is mis-reporting the error. Could you try loading the page with ?debug=workers and find one of the failed fetches in the network debugging panel to see what the actual response is?
Sasha Sobol
@sasha-s
ah. { "message": "Resource protected by organization SAML enforcement. You must grant your OAuth token access to this organization.", "documentation_url": "https://docs.github.com/articles/authenticating-to-a-github-organization-with-saml-single-sign-on/" }
Piotr Kaminski
@pkaminski
Ah, you need to sign out and back in. But Reviewable is supposed to pattern-match this error message and provide clearer instructions... :(
Sasha Sobol
@sasha-s
thanks, it worked
Alexander Sidorov
@salexspb
Hi! Is there a way to see a list of comments I just posted or a list of comments that are blocking a PR that I left?
Piotr Kaminski
@pkaminski
Hey @salexspb, not exactly, but: You can see what comments you posted on GitHub, as everything you publish gets written to an issue-level comment there. As for blocking comments, you can see a grey count in the toolbar once you've replied to everything and the red count goes away. You can cycle between them by clicking on the counter or with the corresponding shortcut keys.
Jake Biesinger
@jakebiesinger

Hey @pkaminski it appears Reviewable is down... Reason: no connection to Firebase

Logging out and back in yields Google's broken robot and a 503 during the OAuth flow

3 replies
Misha Gusarov
@misha-ridge
Hi @pkaminski. Could you have a look at PR https://reviewable.io/reviews/ridge/tectonic/12854 ? Reviewable UI says it's blocked on feldgendler only, but review completion function (correctly) returns pendingReviewers: [ { username: 'feldgendler' }, { username: 'misha-ridge' } ]
Misha Gusarov
@misha-ridge
It might be related to the particular combination of comments though: I have left a "working" comment, and published the review.
Piotr Kaminski
@pkaminski
Hey @misha-ridge, looks I took too long to get to this since the review is now blocking just on misha-ridge. While we generally pass pendingReviewers straight through, there's one exception: if you condition doesn't reference review.pendingReviewers or review.deferringReviewers then we'll remove review.deferringReviewers from your function's output. We do this to account for legacy / simplistic conditions that don't account for the somewhat recently introduced review deferral feature. Could it be that's what's happened in this case?
Misha Gusarov
@misha-ridge

@pkaminski Looks like it.

Is it enough to refer to review.deferringReviewers somewhere in the completion function (e.g. by assigning it to an unused variable) to disable this postprocessing?

Alexey Feldgendler
@feldgendler
@misha-ridge I had looked into it when this feature was introduced, decided not to do it. Deferring seems to be useful.
But I'm not deferring PR ridge/tectonic#13854!
Misha Gusarov
@misha-ridge
@feldgendler I do, and yesterday morning (before you reviewed it) this caused you to be the sole blocker.
Alexey Feldgendler
@feldgendler
@misha-ridge I don't understand why I was the blocker while you were deferring.
Piotr Kaminski
@pkaminski
@misha-ridge Yes, we literally look for the string review.deferringReviewers (or review.pendingReviewers), so you could even put it in a comment. @feldgendler If both people were blockers (per your condition logic), and one was deferring, then the remaining person would become the sole blocker. Reviewable will never add extra pending reviewers. (If the sole pending reviewer is deferring then there will be no blockers.)
Misha Gusarov
@misha-ridge
@pkaminski Thanks
Alexey Feldgendler
@feldgendler
Hello! Today I started seeing loading spinners for diffs of individual files that never stop spinning. Reloading the page doesn't help, the same diff never finishes loading.
Looking at it more closly, it seems like it's a diff that I shouldn't be seeing at all. According to the file matrix, that file is not affected by the revision I'm looking at.
Perhaps Reviewable was trying to show me that file because it has open comments. Not sure if it does.
Piotr Kaminski
@pkaminski
Sorry about that @feldgendler. I couldn't repro but knowing the area where I made recent changes I fortified it against corner cases that might result in this outcome. Could you give it another try?
Alexey Feldgendler
@feldgendler
@pkaminski I can't get that PR back into the state it was in, but I'll be on the lookout. It kept happening on random PRs throughout the day, so I'll notice whether it stops or continues. Thanks!
dogspeed
@dogspeed:matrix.org
[m]
image.png
image.png
for roughly the past week I have not been able to use reviewable due to it thinking I'm offline, I've tried logging out and back in as well as clearing my reviewable.io cookies to no avail -- has anyone else seen this before? Clearly I am online
Piotr Kaminski
@pkaminski
@dogspeed:matrix.org Looks like you might have connectivity issues specifically with Firebase. Are you able to ping reviewable.firebaseio.com? If so, try loading Reviewable with ?debug=workers and look in the Network debugging pane for any errors related to firebaseio.com, perhaps there will be more hints there.
dogspeed
@dogspeed:matrix.org
[m]
I am able to successfully ping reviewable.firebaseio.com and when I add that query string I'm seeing "WebSocket is closed before the connection is established." on requests to wss://s-usc1c-nss-365.firebaseio.com/.ws?v=5&ns=reviewable
After digging a little deeper it seems like this is an issue with my company's VPN, so I think I'm all set here for now. I appreciate the help.
Piotr Kaminski
@pkaminski
Yep, looks like some kind of proxy is messing with the websocket. Feel free to point IT folks my way for troubleshooting if it would help.
dogspeed
@dogspeed:matrix.org
[m]
Thanks so much Piotr!
Alexey Feldgendler
@feldgendler
Hello! How are the reviews in My Reviews sorted withing each section, and can I change that?
Alexey Feldgendler
@feldgendler
@pkaminski Unrelated to the above: filed Reviewable/Reviewable#886, WDYT?
Piotr Kaminski
@pkaminski
@feldgendler Review sorting is chronological within each section, except that in the top section they're first sorted by "blocking on just me vs me and others". There's no way to change this. Get your old reviews finished!
Your issue makes a fair point I think. We'll discuss it internally and follow up in the issue.