I just tried out simul-unsubscribing and -reviewer on batfish/batfish#6974
I can't remove myself from the reviewers list, oddly.
It does generate its own "pending reviewers" list but this is not communicated to GitHub, and won't cause any GitHub notifications. (It would cause Reviewable notifications but you're probably not using those.)
@pkaminski Do you mean this, which definitely notifies me on github? - every action anyone takes on the review IIUC
webhookset, but I'm guessing not). That's why I was asking about
syncRequestedReviewersand the corresponding toggle under Publish since that will cause Reviewable to sync pending reviewers with GitHub's requested reviewers, leading to notifications. So we should dig into that side, and also figure out why Reviewable keeps putting you on the pending reviewers list (which isn't affected by unsubscription, though it can be impacted by requested reviewers -- there may be a race condition of sorts there since there's a potential dependency cycle).
disableGitHubApprovals: trueto the result. Does that sound right?
-reviewers:meand then immediately unsubscribe from github issue, it might work. It's just a tetchy pattern to get right.