Starting seeing errors when trying to publish reviews this morning. The error is: Failed to publish: GitHub error on POST https://api.github.com/repos/repo-name/pulls/1234/reviews: 500. KI?
2 replies
Hi. Is there a way to disable unreviewed commit messages from blocking a merge?
We have a bot that automatically merges pull requests by squashing all commits and using the pull request description as the commit message when they are ready. This kind of breaks our workflow because now we manually need to accept the merge commit in reviewable.
We have a bot that automatically merges pull requests by squashing all commits and using the pull request description as the commit message when they are ready. This kind of breaks our workflow because now we manually need to accept the merge commit in reviewable.
2 replies
The only way I can seem to see the rest of the comments is to comment something else on those two that it's highlighting, but make sure I don't accidentally mark it as resolved (since they're still problems that need to be fixed.)
What's worse is that the people that left the comment for me then can't see the rest of the comments until they comment something to clear that thread from their stuff, so we're just commenting back and forth "need to comment to see other stuff"
Having a hard time seeing the end of comments in a top-level comment with code block.
latest chrome, latest macosx non-beta, animations off
the expanded
<p> in devtools on rhs is the paragraph you can kinda-sorta-see-just-the-top-of below the code block
this is at no zoom; if I play around with CMD-+ and CMD-- I can sometimes see the line.
Survives refresh
With a subsequent comment to test, visible.
I believe this is Reviewable/Reviewable#858. It's a bit weird, because it sounds like a recent regression but I don't believe we messed with anything in that area.
Are there images in the thread?
OK, that still fits #858 then. I'm guessing something must've changed recently in how Chrome loads images and/or fires the
load event. @cgiroux86 will look into this issue next!
anybody else seeing these errors when trying to access Reviewable? our entire dev team is getting this error message "Oops, we couldn’t get Reviewable loaded
There’s something really weird going on with your browser — it looks like it failed to execute all of the code needed to initialize the page. Could you please get in touch with us so we can figure out what’s going on? Thanks!“
There’s something really weird going on with your browser — it looks like it failed to execute all of the code needed to initialize the page. Could you please get in touch with us so we can figure out what’s going on? Thanks!“
Chances are that a bunch of files got reverted partway through. If so, you should find them in a special "Reverted" group in the file matrix, and if you collapse the group you can mark them all as reviewed with one click. Once you do that, they'll be treated as "obsolete" and hidden by default.
that was it thanks, two for two I appreciate your help
Cannot set reactive property on undefined, null, or primitive value: { "+1": "https://github.githubassets.com/images/icons/emoji/unicode/1f44d.png?v8", "-1": "https://github.githubassets.com/images/icons/emoji/unicode/1f44e.png?v8", "100": "htt...
Is the error in the dialog
@sergey-zakharov Reviewable doesn't return 403's itself so this looks more like Google is getting in the way of your requests (and blocking the connection to Firebase). Where are you located? Have you tried initiating the connection from a different network (e.g., office vs cell phone)?
Although, now I'm thinking I should have RTFMd before asking :)
@rfagen No API, sorry. We have custom review completion conditions for some stuff, and for the rest we only ingest data from GitHub. GitHub Annotations is probably what you're looking for but Reviewable doesn't surface those yet. This is something we could add for sure, though.
