Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 18 20:43
    Server build 3063 deployed
  • Jun 18 19:40
    Server build 3062 deployed
  • Jun 18 00:04
    Server build 3059 deployed
  • Jun 17 23:55
    Client build 4836 deployed
  • Jun 15 18:46
    pkaminski commented #770
  • Jun 14 17:38
    Server build 3049 deployed
  • Jun 14 17:30
    Server build 3048 deployed
  • Jun 14 17:19
    Server build 3047 deployment failed
  • Jun 14 16:13
    pkaminski labeled #838
  • Jun 14 00:23
    Server build 3046 deployed
  • Jun 12 07:21
    Client build 4825 deployed
  • Jun 12 05:50
    Client build 4824 deployed
  • Jun 11 17:59
    ludazhao commented #838
  • Jun 11 17:26
    pkaminski commented #841
  • Jun 11 17:12
    pkaminski commented #838
  • Jun 11 17:11
    cgiroux86 assigned #841
  • Jun 11 17:03
    pkaminski closed #839
  • Jun 11 17:03
    pkaminski commented #839
  • Jun 11 17:03
    pkaminski labeled #839
  • Jun 11 17:03
    pkaminski unlabeled #839
Michał Kowalczyk
@mkow
before hard reload all the comments I tried to add were misplaced
i.e. the text box appeared under a different line than clicked
Piotr Kaminski
@pkaminski
Before reload, was the line offset behavior consistent across files? Across diffs? Was the line offset consistent or random/arbitrary? Was it a side-by-side diff, and if so did the behavior affect both sides?
Michał Kowalczyk
@mkow
it triggered only in one file, but I checked only 2 others
I didn't play with changing diffs
offset was constant
something like 10 lines above
in a file which was almost completely rewritten in this PR
side-by-side diff, with one-file-at-a-time enabled
didn't try different sides
unfortunately this was a priority fix, so I didn't experiment too much and just reloaded and finished the review
ok, I managed to repro this again
so, it happens only on the right side of the diff, left is fine
Michał Kowalczyk
@mkow
the right side start to drift only after a line where there was more line deleted on one side than the other
the first few lines of the file works
and then the further in the file I place it the bigger the drift is
I checked a few more files with the same diff range and they work fine (but they have much less changes, the one where this got triggered was almost completely rewritten)
other diff ranges in this particular file are also broken
basically, it seems that somehow it get the lines number from the left file and the puts the comment at this line in the right file
what's interesting, is that the revision number at the comment seems correct - it's placed at the revision which is shown on the right, but, it's displayed in red, not in blue
despite being the newest existing
Michał Kowalczyk
@mkow
image.png
also, this "r??" at the top is worrying :)
(ah, maybe not, because other file have different ranges selected)
Piotr Kaminski
@pkaminski
Wow. A new comment should always be placed precisely -- no idea what's going on here. Does it still go away after a hard reload? If so, how did you manage to repro it again?
Michał Kowalczyk
@mkow
not sure how I reproed, just opened the same PR again
Piotr Kaminski
@pkaminski
Can you inspect one of the lines where you get a misplaced comment and see what its data-line-number attribute is?
Michał Kowalczyk
@mkow
sure, sec
let's go to priv maybe, to not spam here
Piotr Kaminski
@pkaminski
OK
MIDCS
@felipe636
Hi, how to use the tool reviewable
?
I am begin to work in this tool.
Piotr Kaminski
@pkaminski
Hi @felipe636, our onboarding flow isn't great yet, but there's contextual help throughout the app (just hit F1 or h), and there's a full user manual at https://docs.reviewable.io.
Eran Sakal
@esakal
Hi @pkaminski quick question. I see the following user https://github.com/NixDevXMP in the review, but I don't see him in Github dashboard of the PR and this is internal repo so It couldn't be someone from outside, any idea?
CleanShot 2021-05-31 at 16.18.08@2x.jpg
Piotr Kaminski
@pkaminski
@esakal If you let me know which PR this is I can check our database to find out why this user got pulled. Often it's because they got accidentally @-mentioned -- Reviewable is pretty naïve about parsing things that look like mentions. In any case, there's no need to worry about leaking information, as both GitHub and Reviewable will enforce your repo's permissions, and Reviewable doesn't send any notifications of its own.
Devin Ekins
@BlackVegetable
Hey, is it possible to get a link to a line of code from the GUI in reviewable?
Piotr Kaminski
@pkaminski
Only if you put a discussion on it ATM. The larger issue of how to address arbitrary lines is still outstanding: Reviewable/Reviewable#147
Alexey Feldgendler
@feldgendler
503 Service Unavailable :-(
Alexey Feldgendler
@feldgendler
@pkaminski Sorry, I keep missing my mentions in this chat.
The vanishing comments issue stopped happening, or so it seems. It wasn't very frequent to begin with, and now I haven't seen it for quite a while.
@pkaminski I think the entire reviewable.io is down.
Alexey Feldgendler
@feldgendler
Ah yes, Fastly CDN is having issues.
Chris Giroux
@cgiroux86
@feldgendler Yeah, there was a Firebase Hosting issue earlier that was resulting in 503 errors. Everything should be ok now -- sorry for the inconvenience!
https://status.firebase.google.com/incidents/CwDdn12D5GF6nXewEvUu
Alexey Feldgendler
@feldgendler
Hi! I filed Reviewable/Reviewable#841 but I'm afraid the problematic PR might not stay long in its current state.
Piotr Kaminski
@pkaminski
Thanks @feldgendler, I captured the state from Reviewable's side and will grab all the data from GitHub in a sec.
OK, captured as well. Hopefully we won't need anything more to debug.
rglebov81
@rglebov81:matrix.org
[m]
Hello. I think I have a quite simple question: How do I add reviewers to my PR from within the reviewable interface?
1 reply
rglebov81
@rglebov81:matrix.org
[m]
@pkaminski: Thanks!