before hard reload all the comments I tried to add were misplaced
i.e. the text box appeared under a different line than clicked
Before reload, was the line offset behavior consistent across files? Across diffs? Was the line offset consistent or random/arbitrary? Was it a side-by-side diff, and if so did the behavior affect both sides?
it triggered only in one file, but I checked only 2 others
I didn't play with changing diffs
offset was constant
something like 10 lines above
in a file which was almost completely rewritten in this PR
side-by-side diff, with one-file-at-a-time enabled
didn't try different sides
unfortunately this was a priority fix, so I didn't experiment too much and just reloaded and finished the review
ok, I managed to repro this again
so, it happens only on the right side of the diff, left is fine
the right side start to drift only after a line where there was more line deleted on one side than the other
the first few lines of the file works
and then the further in the file I place it the bigger the drift is
I checked a few more files with the same diff range and they work fine (but they have much less changes, the one where this got triggered was almost completely rewritten)
other diff ranges in this particular file are also broken
basically, it seems that somehow it get the lines number from the left file and the puts the comment at this line in the right file
what's interesting, is that the revision number at the comment seems correct - it's placed at the revision which is shown on the right, but, it's displayed in red, not in blue
despite being the newest existing
also, this "r??" at the top is worrying :)
(ah, maybe not, because other file have different ranges selected)
Wow. A new comment should always be placed precisely -- no idea what's going on here. Does it still go away after a hard reload? If so, how did you manage to repro it again?
not sure how I reproed, just opened the same PR again
Can you inspect one of the lines where you get a misplaced comment and see what its data-line-number attribute is?
let's go to priv maybe, to not spam here
Hi, how to use the tool reviewable
I am begin to work in this tool.
Hi @felipe636, our onboarding flow isn't great yet, but there's contextual help throughout the app (just hit F1 or h), and there's a full user manual at https://docs.reviewable.io.
Hi @pkaminski quick question. I see the following user https://github.com/NixDevXMP in the review, but I don't see him in Github dashboard of the PR and this is internal repo so It couldn't be someone from outside, any idea?
@esakal If you let me know which PR this is I can check our database to find out why this user got pulled. Often it's because they got accidentally @-mentioned -- Reviewable is pretty naïve about parsing things that look like mentions. In any case, there's no need to worry about leaking information, as both GitHub and Reviewable will enforce your repo's permissions, and Reviewable doesn't send any notifications of its own.
Hey, is it possible to get a link to a line of code from the GUI in reviewable?
Only if you put a discussion on it ATM. The larger issue of how to address arbitrary lines is still outstanding: Reviewable/Reviewable#147
503 Service Unavailable :-(
@pkaminski Sorry, I keep missing my mentions in this chat.
The vanishing comments issue stopped happening, or so it seems. It wasn't very frequent to begin with, and now I haven't seen it for quite a while.
@pkaminski I think the entire reviewable.io is down.