Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 27 22:42
    Client build 5027 deployed
  • Sep 27 21:21
    Client build 5026 deployed
  • Sep 27 21:05
    pkaminski closed #749
  • Sep 27 21:05
    pkaminski commented #749
  • Sep 27 21:05
    pkaminski labeled #749
  • Sep 27 07:02
    misha-ridge commented #749
  • Sep 25 21:08
    pkaminski opened #873
  • Sep 25 21:08
    pkaminski labeled #873
  • Sep 25 21:08
    pkaminski labeled #873
  • Sep 25 04:13
    Server build 3249 deployed
  • Sep 25 04:11
    pkaminski closed #870
  • Sep 25 04:11
    pkaminski commented #870
  • Sep 25 04:10
    pkaminski commented #872
  • Sep 25 04:10
    Client build 5023 deployed
  • Sep 24 17:48
    pkaminski closed #872
  • Sep 24 06:01
    msagarpatel commented #862
  • Sep 23 22:58
    pkaminski assigned #872
  • Sep 23 22:57
    pkaminski unassigned #441
  • Sep 23 03:45
    Server build 3235 deployed
  • Sep 23 00:16
    pkaminski opened #872
tmr-storyhealth
@tmr-storyhealth
Starting seeing errors when trying to publish reviews this morning. The error is: Failed to publish: GitHub error on POST https://api.github.com/repos/repo-name/pulls/1234/reviews: 500. KI?
2 replies
Dominik Roos
@oncilla
Hi. Is there a way to disable unreviewed commit messages from blocking a merge?
We have a bot that automatically merges pull requests by squashing all commits and using the pull request description as the commit message when they are ready. This kind of breaks our workflow because now we manually need to accept the merge commit in reviewable.
2 replies
Rex Morgan
@RexMorgan

Is there a way to see all of the comments left on a review?

Currently it's highlighting that I have two responses to a couple of my comments, but I can't see any of the other comments I left, so I can't really tell what all is outstanding on a review.

Rex Morgan
@RexMorgan

The only way I can seem to see the rest of the comments is to comment something else on those two that it's highlighting, but make sure I don't accidentally mark it as resolved (since they're still problems that need to be fixed.)

What's worse is that the people that left the comment for me then can't see the rest of the comments until they comment something to clear that thread from their stuff, so we're just commenting back and forth "need to comment to see other stuff"

Rex Morgan
@RexMorgan
I just found the "mark as read" label that pops up when you hover over the yellow "new comment" notification. That's what I needed :)
Piotr Kaminski
@pkaminski
Glad to hear you solved your issue! IIUC, the problem was that you wanted to navigate through all unresolved discussion while still having some unreplied ones left?
2 replies
Dan Halperin
@dhalperi
Screen Shot 2021-08-18 at 4.51.22 PM.png
Having a hard time seeing the end of comments in a top-level comment with code block.
latest chrome, latest macosx non-beta, animations off
the expanded <p> in devtools on rhs is the paragraph you can kinda-sorta-see-just-the-top-of below the code block
this is at no zoom; if I play around with CMD-+ and CMD-- I can sometimes see the line.
Survives refresh
With a subsequent comment to test, visible.
Screen Shot 2021-08-18 at 4.55.01 PM.png
Piotr Kaminski
@pkaminski
I believe this is Reviewable/Reviewable#858. It's a bit weird, because it sounds like a recent regression but I don't believe we messed with anything in that area.
Are there images in the thread?
Dan Halperin
@dhalperi
Yes, there is an image in the thread several comments above
Piotr Kaminski
@pkaminski
OK, that still fits #858 then. I'm guessing something must've changed recently in how Chrome loads images and/or fires the load event. @cgiroux86 will look into this issue next!
Sahil Takiar
@sahilTakiar
Screen Shot 2021-08-23 at 11.59.10 AM.png
anybody else seeing these errors when trying to access Reviewable? our entire dev team is getting this error message "Oops, we couldn’t get Reviewable loaded
There’s something really weird going on with your browser — it looks like it failed to execute all of the code needed to initialize the page. Could you please get in touch with us so we can figure out what’s going on? Thanks!“
Sahil Takiar
@sahilTakiar
@pkaminski any ideas? Reviewable is down for our entire team, so no one can do code reviews.
Piotr Kaminski
@pkaminski
@sahilTakiar Is it working now?
Sahil Takiar
@sahilTakiar
all good now, thanks!
Barrett Sonntag
@barretts
I have two reviews that don't get the [Reviewable] button. It looks like it is only my recent PRs of the organization. Unable to create review: Request queued but server did not respond I already revoked all access and reauthenticated while trying to troubleshoot.
Piotr Kaminski
@pkaminski
(Following up on this by email.)
Barrett Sonntag
@barretts
@pkaminski thanks for your help!
Piotr Kaminski
@pkaminski
NP, thanks for helping me find a couple bugs!
Barrett Sonntag
@barretts
Is there a way to bump or restart a PR review? I've got one that says there are 224 files to be reviewed but GitHub only reports 15 files.
Piotr Kaminski
@pkaminski
Chances are that a bunch of files got reverted partway through. If so, you should find them in a special "Reverted" group in the file matrix, and if you collapse the group you can mark them all as reviewed with one click. Once you do that, they'll be treated as "obsolete" and hidden by default.
Barrett Sonntag
@barretts
tyvm!
that was it thanks, two for two I appreciate your help
Piotr Kaminski
@pkaminski
:+1:
Dan Halperin
@dhalperi
Getting a crash loading the page, and noticing there was a client build deployed 10m ago...
Cannot set reactive property on undefined, null, or primitive value: { "+1": "https://github.githubassets.com/images/icons/emoji/unicode/1f44d.png?v8", "-1": "https://github.githubassets.com/images/icons/emoji/unicode/1f44e.png?v8", "100": "htt...
Is the error in the dialog
Chris Giroux
@cgiroux86
@dhalperi Yeah we're aware -- thanks for letting us know!
Dan Halperin
@dhalperi
:+1:
Chris Giroux
@cgiroux86
@dhalperi We just rolled back, should be good now.
Serge
@sergey-zakharov
Hi @pkaminski, we've got the issue with login for 2 days already, tried hard refresh and so on. Also the service goes to "offline" after a while
Desktop screensh.png
Reviewable.png
Piotr Kaminski
@pkaminski
@sergey-zakharov Reviewable doesn't return 403's itself so this looks more like Google is getting in the way of your requests (and blocking the connection to Firebase). Where are you located? Have you tried initiating the connection from a different network (e.g., office vs cell phone)?
rfagen
@rfagen

Hey @pkaminski, someone over here was wondering "does Reviewable have an API? e.g. for leaving comments on a PR at a specific source file/line?"

I thought that might be question of more general interest, so asking here instead of email.

Although, now I'm thinking I should have RTFMd before asking :)
Piotr Kaminski
@pkaminski
@rfagen No API, sorry. We have custom review completion conditions for some stuff, and for the rest we only ingest data from GitHub. GitHub Annotations is probably what you're looking for but Reviewable doesn't surface those yet. This is something we could add for sure, though.
rfagen
@rfagen
Thanks!
Eric Hallström
@erichall
Hi! Is it possible to filter out comments based on a regex pattern or something?
Piotr Kaminski
@pkaminski
Sorry @erichall, there's no comment filter / visibility controls at this point. I'm curious, what's the use case for filtering by regex pattern? Most people want to filter by state, author, or disposition...
Eric Hallström
@erichall
Thanks for your answer @pkaminski ! We do our deployments to different environment by making a comment on a PR. Sometimes a PR can contain a bunch of those comments. So it would be nice to ignore them :)
Piotr Kaminski
@pkaminski
Ah, got it. One workaround would be to open a new top-level discussion for these comments (and only these comments) so you can easily acknowledge them en masse.