Hi team, first post here.
I’m trying to enable more and more Github’s branch protections so we have enforcement of some of our policies around code review. I’m having trouble with the Github branch protection described as, “Require conversation resolution before merging”.
For folks using Github's review system, this works fine. However, for folks using Reivewable's review system, it doesn't appear that discussions/comment disposition makes its way into Github's system of record (what I'm calling the place where Github squirrels away all the data under the hood like review status, open discussions).
I think I see what is going on: Reviewable is sync'ing discussions sourced from Reviewable's UI into Github as general comments, as opposed to review comments. The distinction is a general comment does not need acknowledge/resolution from anywhere.
In Github's UI, you create these general comments by navigating to the bottom of a PR and punching in some text to input form there, and push the green "comment" button. In Github's UI, you create a review comment by first navigating to "Start a Review", and then leaving a comment this way.
Has anyone else experienced this and has a solution that would cause Reviewable sourced discussions to show up as Github review comments instead of general comments? I think if you could do this, Github's branch protections would work fine.
.? Dunno, not sure that would fit more people's workflows than the current approach. You can fake it with a compound keyboard shortcut if you want, though, just bind to
r3is considered obsolete and
r2is the latest revision -- I believe that should get things unstuck.