if you like the idea I can file an issue for further discussion ;)
So basically a combination of
x and .? Dunno, not sure that would fit more people's workflows than the current approach. You can fake it with a compound keyboard shortcut if you want, though, just bind to toggleCurrentFileReviewed(true); nextChangedFileOrUnrepliedDiscussion().
and it's IMO unintuitive that it actually skips some of the updates
so, as the effect, I often resort back to just page up/down
Personally, I think pgup/pgdn is a more natural UI anyway, since we do our best not to show anything irrelevant on the page. The "mark and next file" button is more for when you get stuck in single-file mode, in which case skipping over a file isn't as big a deal and you just do a sweep for any remaining discussions at the end.
I dunno, I think it we went all-in on the "next item" style navigation it would make sense, but given that right now we emphasize cycling files vs discussions separately it's reasonable to keep this button file-specific. That said, should you open an issue it would allow other people to chime in and give me an opportunity to change my mind. :)
anyways, this isn't a big issue for me
just a small cumbersomeness, i.e. no perfect way to read everything I want without scrolling through things which didn't change ;)
@pkaminski can I quote you in the issue? especially that "I think it we went all-in on the "next item" style navigation it would make sense, but given that right now we emphasize cycling files vs discussions separately it's reasonable to keep this button file-specific.", which sounds like a good argument against this change
I'll create the issue as I'm curious what other people will say :)
I actually wonder how many different flows do people have to go through the reviews
Thanks @arran-fathom! You can't use a raw content link directly because it doesn't serve with the correct content type, but all you need to do is go to https://raw.githack.com/ and paste in the raw link to get a usable one.
@pkaminski Hello Piotr. ridge/tectonic#15318 says: "code-review/reviewable Expected — Waiting for status to be reported ". However the review there was finished 15:01 UTC
So Reviewable shows the big green button "ready to merge", but our bot that watches the checks status does not want to merge the PR.
Here's the proximate culprit, now to dig to root cause: "Dropping mergeability due to last revision commit mismatch for ridge/tectonic#15318"
I know it's a messy branch. Sorry about that :)
At this point, Reviewable is stuck because it sees that all commits have been captured, yet the last revision isn't at the current head. However we got there this is a situation we need to be able to recover from -- let me think about it a bit after my upcoming meeting, and I'll endeavor to push out a fix later today.
Thanks
Hey @misha-ridge, a proper fix will take some thinking as it gets to an underlying design question we've been struggling with for years. In the meantime, I manually adjusted the review so that
r3 is considered obsolete and r2 is the latest revision -- I believe that should get things unstuck.
Is there a way to get a github link from an arbitrary file? I know reviewable does this for large files, and maybe images, but I'd like it for an arbitrary file. In this case (https://reviewable.io/reviews/batfish/pybatfish/837/jupyter_notebooks/Pandas%20Examples.ipynb#-) I want to review GitHub's Jupyter notebook preview.
I have tried to recreate the app secret token and re authorize my session with github (im user 24)
Hey. Is there a way to "see myself out" out of a discussion thread in Reviewable? I commented on a thread in a long-running PR, and every day there is a new comment there, and it pops up in my "things to look at", even though I really don't want to look at it anymore.
I know it's a bad idea to have long-running PRs, but we have them from time to time.
Hi Everyone
I'm facing issues in accessing reviewable. It keeps on showing the
resume session message But doesn't load the page. Look like issue with the session since i'm able to access it from the incognito. I tried logging out of github so that oauth can reset the session but no luck.
Is there a way to reset the site data so that it behaves in proper way
I'm facing issues in accessing reviewable. It keeps on showing the
resume session message But doesn't load the page. Look like issue with the session since i'm able to access it from the incognito. I tried logging out of github so that oauth can reset the session but no luck.
Is there a way to reset the site data so that it behaves in proper way
@pkaminski when you get a chance to take a look at Reviewable/Reviewable#950
it's currently preventing me and some of my colleagues from reviewing some PRs
it's currently preventing me and some of my colleagues from reviewing some PRs