These are chat archives for Ruhrpottpatriot/GW2.NET

17th
Sep 2015
Steven Liekens
@StevenLiekens
Sep 17 2015 14:49
btw what's the holdup for v1.1 / v1.2?
I don't know if I'm stressing this enough but our 1.0.1 packages are broken
Robert Logiewa
@Ruhrpottpatriot
Sep 17 2015 17:39
I had an important talk with my Analysis Professor today. I'll upload the packages ASAP.
Robert Logiewa
@Ruhrpottpatriot
Sep 17 2015 18:10
small thing: The current assembly version is set to 2.0, however we are releasing only 1.2, what is the reason for this?
Steven Liekens
@StevenLiekens
Sep 17 2015 20:42
master branch is only for new developments -> 2.0
when you need to make changes to 1.x then you can create a new branch from the last v1.x.x tag and make your changes on there
bugfixes for v1 get merged back into master afterwards
but let's not write any new code for v1
we could, but that's gonna get confusing and difficult to merge
Steven Liekens
@StevenLiekens
Sep 17 2015 21:08
oh anddddd
the informational version contains a hyphen, indicating that it is prerelease
it's set to 2.0.0-0 (read as version 2.0.0, prerelease version 0)
should change it to 2.0.0-CI{build} in appveyor
so that it's like 2.0.0-CI1, 2.0.0-CI2, 2.0.0-CI3, ..., 2.0.0-CI100
Robert Logiewa
@Ruhrpottpatriot
Sep 17 2015 21:30
If I understood you correctly, I need to build the NuGet Packages from the "Maintenance-1.0" branch?
Steven Liekens
@StevenLiekens
Sep 17 2015 21:30
or any branch
as long as its based on tag v1.2.0
you can created branches from tags if you didn't know already
Steven Liekens
@StevenLiekens
Sep 17 2015 21:46
that moment when you notice spelling mistakes after 5 minutes have passed and you're not allowed to edit
Steven Liekens
@StevenLiekens
Sep 17 2015 21:58
so the main idea is to tag a commit when it is ready to publish
and only publish tagged commits
and when a release breaks, start a new branch from the tag that it was published from