These are chat archives for Ruhrpottpatriot/GW2.NET

28th
Sep 2015
Robert Logiewa
@Ruhrpottpatriot
Sep 28 2015 10:38
maybe you should look at IClassFixture<T> and ICollectionFixture<T>
Steven Liekens
@StevenLiekens
Sep 28 2015 10:43
I was wondering about that
right now I'm using [MemberDataAttribute("Discover")]
and I'm wondering how often the test runner calls the Discover() method
I know that fixtures are cached, but what about MemberData?
Steven Liekens
@StevenLiekens
Sep 28 2015 10:49
public static IEnumerable<object[]> Discover()
{
    return repository.Discover().Select(o => new object[] { o });
}

[Theory]
[MemberData("Discover")]
public void FindAll(int identifier)
{
    var result = repository.Find(identifier);
    Assert.NotNull(result);
}
is there a better way?
using fixtures?
Steven Liekens
@StevenLiekens
Sep 28 2015 11:17
I'm at work right now so I can't really do anything, but I'll try to send that PR today
there will be some new tests that always fail, but I want to reintegrate my changes back to master before attempting to fix the errors
Robert Logiewa
@Ruhrpottpatriot
Sep 28 2015 13:04
I think we should seriously considering mocking the responses.
With that we are independent of the ANet servers
Steven Liekens
@StevenLiekens
Sep 28 2015 13:08
that's the next step
right now I just want to have a set of end-to-end tests that show how reliable the library is as a whole
so no mocking of any sort