These are chat archives for Ruhrpottpatriot/GW2.NET

1st
Oct 2015
Steven Liekens
@StevenLiekens
Oct 01 2015 11:16
can we do something about the huge number of warnings about missing comments?
I don't think they belong in a build log
Steven Liekens
@StevenLiekens
Oct 01 2015 11:26
for CI builds anyway
Robert Logiewa
@Ruhrpottpatriot
Oct 01 2015 11:52
currently we can't. That's the way Stylecop works. When I got the move to the new Roslyn based Stylecop.Analyzers done we can set the output to a different level so they won't show up in a log.
Steven Liekens
@StevenLiekens
Oct 01 2015 11:52
they're actually not stylecop messages
Steven Liekens
@StevenLiekens
Oct 01 2015 12:10
"To disable in 'Project properties' go to Project properties -> Build > "Errors and warnings" (section), Suppress Warnings (textbox), add 1591 (comma separated list) –"
Steven Liekens
@StevenLiekens
Oct 01 2015 12:19
we can make this property conditional
Robert Logiewa
@Ruhrpottpatriot
Oct 01 2015 12:19
Don't do that yet
there is a better way
Steven Liekens
@StevenLiekens
Oct 01 2015 12:20
you mean add the missing comments?
:)
Robert Logiewa
@Ruhrpottpatriot
Oct 01 2015 12:20
I'm currently looking into the PR you sent
after I merged it I'm going to replace the old Stylecop
Steven Liekens
@StevenLiekens
Oct 01 2015 12:20
ok
Robert Logiewa
@Ruhrpottpatriot
Oct 01 2015 12:21
And there I'll set the level of warning to "Info", so it'll be shown in the output window, but under the category messages
Steven Liekens
@StevenLiekens
Oct 01 2015 12:26
but the messages in appveyor are not stylecop messages
it's a compiler switch
/doc
without it, you don't get CS1591 missing comments warnings
with /doc, you get the warnings unless you suppress CS1591
Steven Liekens
@StevenLiekens
Oct 01 2015 12:53
add this parameter to the build: /p:NoWarn=1591
in appveyor.yml
that way you still get all the warnings in visual studio
Robert Logiewa
@Ruhrpottpatriot
Oct 01 2015 17:37
With the new Stylecop.Analyzers it does not matter where the message originates from, all get routed through the compiler.
That is the reason why with the new Stylecop.Analyzers can even fix some errors themselves
Steven Liekens
@StevenLiekens
Oct 01 2015 17:48
What a time to live in
Robert Logiewa
@Ruhrpottpatriot
Oct 01 2015 17:48
Yup
In my other project, which I moved yesterday to get aquainted to the new analyzer, I had around 200 warnings, 150 of them were trailing spaces. The analyzer removed them all by itself
Damn that was cool
Steven Liekens
@StevenLiekens
Oct 01 2015 17:51
Have you ever used structural search & replace in resharper?
Robert Logiewa
@Ruhrpottpatriot
Oct 01 2015 17:52
no
but I know it's awesome
Steven Liekens
@StevenLiekens
Oct 01 2015 17:53
It's one of those tools that look like a lot of effort but when you start using them then you start to wonder how you ever lived without
Robert Logiewa
@Ruhrpottpatriot
Oct 01 2015 17:53
yeah
Steven Liekens
@StevenLiekens
Oct 01 2015 17:54
Same with msbuild script and powershell and T4 templates