These are chat archives for Ruhrpottpatriot/GW2.NET

2nd
Oct 2015
Steven Liekens
@StevenLiekens
Oct 02 2015 08:52 UTC
how come our nuget downloads are skyrocketing?
120 downloads of 1.2.0 in just the last two weeks
compared to only 277 downloads in the past 5 months
must be because we're on github now
right?
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 11:02 UTC
I really don't know.
@/all I merged the PR. Now I'll move from the old Stylecop to Stylcop.Analyzers
Steven Liekens
@StevenLiekens
Oct 02 2015 12:06 UTC
what do we have to install for that?
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 12:10 UTC
I'll write a wiki site for that too
However everything runs via NuGet packages
Steven Liekens
@StevenLiekens
Oct 02 2015 12:12 UTC
nice :)
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 12:12 UTC
yup
but since Roslyn has a bug I now have to edit all csproj files
by hand
sigh here I go
Steven Liekens
@StevenLiekens
Oct 02 2015 12:13 UTC
use powershell
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 12:13 UTC
I'm not very good with PS scripts
Steven Liekens
@StevenLiekens
Oct 02 2015 12:16 UTC
you can read csproj files as XML and manipulate them that way
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 12:16 UTC
I need to add <CodeAnalysisRuleSet>..\..\GW2NET.ruleset</CodeAnalysisRuleSet> to each build config, and replace <None Include="stylecop.json" / with <AdditionalFiles Include="..\..\stylecop.json" />
yeah, but I'm not good with PS scripts at all
that is my problem
Steven Liekens
@StevenLiekens
Oct 02 2015 12:38 UTC
Use variables instead of relative paths
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 12:38 UTC
What would be the variable for the solution root?
because that is where the files are residing
Steven Liekens
@StevenLiekens
Oct 02 2015 12:38 UTC
$(SolutionDir) for the dir that contains the currently loaded sln file
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 12:38 UTC
ah good
will do that after I checked that everything is in order
so, ..\..\GW2NET.ruleset would become $(SolutionDir)\GW2NET.ruleset?
Or do variables have trailing slashes?
Steven Liekens
@StevenLiekens
Oct 02 2015 12:50 UTC
they have trailing slashes
but it doesn't hurt
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:27 UTC
Holy crap: The new analysers find over 3000 warnings xD
Steven Liekens
@StevenLiekens
Oct 02 2015 13:28 UTC
I'm not surprised
lots of missing comments probably
or empty comments
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:28 UTC
I already changed missing comments from warning to info
so that is not included
Steven Liekens
@StevenLiekens
Oct 02 2015 13:29 UTC
what are the other 3000 warnings about?
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:30 UTC
many are coming from auto generated files, since Roslyn doesn't offer metadata about these files, we have to decorate these files by ourself
I'm doing that currently
Steven Liekens
@StevenLiekens
Oct 02 2015 13:51 UTC
can we do a bugfix release on the side?
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:51 UTC
Sure we can
Steven Liekens
@StevenLiekens
Oct 02 2015 13:51 UTC
I found some things that need to be backported to v1
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:51 UTC
chage it , and do a PR
I finally have a method to batch upload Nuget pacakges
that makes many things easier
damn... the new analysers are fast
Steven Liekens
@StevenLiekens
Oct 02 2015 13:52 UTC
powershell oneliner:
Get-ChildItem *.nupkg | %{ nuget.exe push $_.FullPath }
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:53 UTC
yeah, taht is the most simple
but there is a small problem
Steven Liekens
@StevenLiekens
Oct 02 2015 13:53 UTC
:c
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:53 UTC
much better solution
that can be run from inside VS :smile:
Steven Liekens
@StevenLiekens
Oct 02 2015 13:55 UTC
I really wish they would let us delete packages instead of only unlisting them
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:55 UTC
yeah
I can understand their reasoning, but I don't agree with it
Steven Liekens
@StevenLiekens
Oct 02 2015 13:57 UTC
their advice is good, I just don't like that they enforce it
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:57 UTC
yeah
btw
I'm going to enable xml output for each project and documentation
Steven Liekens
@StevenLiekens
Oct 02 2015 13:57 UTC
it wasn't already?
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:57 UTC
no
Steven Liekens
@StevenLiekens
Oct 02 2015 13:57 UTC
oh my bad
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:58 UTC
many projects have it in debug, but not in release or vice versa
Steven Liekens
@StevenLiekens
Oct 02 2015 13:58 UTC
oh weird
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:58 UTC
yep
But so far, everything works just fine
Analyzers are much faster than before
just the indicators in the code window take some time to show up
but I think that is partially R# fault
Steven Liekens
@StevenLiekens
Oct 02 2015 13:59 UTC
one thing concerns me
I added tests that fail in my PR, but the build succeeded
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:59 UTC
huh?
ok...
We need to look at that
Steven Liekens
@StevenLiekens
Oct 02 2015 13:59 UTC
shouldn't the build fail when unit tests fail?
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 13:59 UTC
the build? No
why should a build fail when a Test fails?
the build only verifies semantic validity
but the CI should still fail
I'll look at the CI log
Steven Liekens
@StevenLiekens
Oct 02 2015 14:02 UTC
it doesn't find the tests project
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 14:02 UTC
hm...
that one is never run
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 14:03 UTC
huh
Steven Liekens
@StevenLiekens
Oct 02 2015 14:04 UTC
appveyor's default behavior is to fail the build when a test fails
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 14:04 UTC
yeah I know
Steven Liekens
@StevenLiekens
Oct 02 2015 14:05 UTC
which makes sense because you don't want to release code that you know contains bugs
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 14:05 UTC
yep
A small tutorial for converting
for existing projects you needn't do anything I'm currently doing it
Steven Liekens
@StevenLiekens
Oct 02 2015 14:18 UTC
I wasn't going to :)
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 14:18 UTC
@StevenLiekens If you want to add a PS script, you are free to do it
Steven Liekens
@StevenLiekens
Oct 02 2015 14:18 UTC
lazy friday
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 14:18 UTC
^^
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 14:39 UTC
@StevenLiekens What is the reason for the test projects anyway? In my oppinion we should only have one test project.
besides, most of our current tests are located in the main test project
so we could safely delete the other test projects
Steven Liekens
@StevenLiekens
Oct 02 2015 14:40 UTC
those are placeholder projects
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 14:41 UTC
do we really need them?
Steven Liekens
@StevenLiekens
Oct 02 2015 14:41 UTC
yes
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 14:41 UTC
for what? Why can't we just have the tests in one project?
Steven Liekens
@StevenLiekens
Oct 02 2015 14:42 UTC
having only a single test project that references all DLLs is not a great idea
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 14:42 UTC
but why?
Steven Liekens
@StevenLiekens
Oct 02 2015 14:42 UTC
usually it's one test project per assembly under test
because with a single test project, you can't isolate tests
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 14:42 UTC
ah
Steven Liekens
@StevenLiekens
Oct 02 2015 14:42 UTC
say you only want to build and test V2.Colors
now you can't do that because the test project requires you to build all tests
I mean all projects under tests
Steven Liekens
@StevenLiekens
Oct 02 2015 15:36 UTC
$xmlns = "http://schemas.microsoft.com/developer/msbuild/2003"
Get-ChildItem *.csproj -Recursive | %{
  $xml = [Xml](Get-Content $_)
  $nsmgr = [Xml.XmlNamespaceManager]$xml.NameTable
  $nsmgr.AddNamespace('x', $xmlns)

  $styleCop = $xml.SelectSingleNode('//x:AdditionalFiles[@Include="$(SolutionDir)stylecop.json"]', $nsmgr)
  if ($styleCop -ne $null)
  {
    return
  }

  $itemGroup = $xml.CreateElement('ItemGroup', $xmlns)
  $itemGroup = $xml.Project.AppendChild($itemGroup)

  $styleCop = $xml.CreateElement('AdditionalFiles', $xmlns)
  $styleCop.SetAttribute('Include', '$(SolutionDir)stylecop.json')
  $styleCop = $itemGroup.AppendChild($styleCop)

  $xml.Save($_)
}
if you run this in the root of the repository, it will add the stylecop reference to all *.csproj files
CodeAnalysisRuleSet looks trickier
anyway I'm going home now
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 15:37 UTC
kk
Steven Liekens
@StevenLiekens
Oct 02 2015 18:13 UTC
okay I'm gonna work on #15 for v1.3
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:14 UTC
ok
Steven Liekens
@StevenLiekens
Oct 02 2015 18:14 UTC
and then somehow merge it into the master branch
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:14 UTC
Analyzer Move is a real headache
somehow I always get a mscorlib not found error
Steven Liekens
@StevenLiekens
Oct 02 2015 18:14 UTC
that's PCL for ya
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:14 UTC
yeah that sucks a bit
Steven Liekens
@StevenLiekens
Oct 02 2015 18:14 UTC
I had the same problem with System.Runtime not found
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:15 UTC
somehow it only shows up, when a certain file is in one certain position
Steven Liekens
@StevenLiekens
Oct 02 2015 18:15 UTC
developing for xplat is a bitch
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:15 UTC
but it has to be there
Steven Liekens
@StevenLiekens
Oct 02 2015 18:17 UTC
oh my
steel ingots skyrocketed
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:19 UTC
I think I'll start over with the changes
sucks to throw away a afternoon of work, but I simply can't fix the problem
Steven Liekens
@StevenLiekens
Oct 02 2015 18:20 UTC
send it to me
I wanna see
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:24 UTC
w8 a sec
publishing the branch
oh 8
commits are missing
now
this is how far I got
Steven Liekens
@StevenLiekens
Oct 02 2015 18:27 UTC
I like how you spelled analyzers
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:27 UTC
yeah
missed an a
:smile:
Steven Liekens
@StevenLiekens
Oct 02 2015 18:32 UTC
I think the beta weekend starts soon
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:32 UTC
can be, I havn't played GW2 in a few months
Steven Liekens
@StevenLiekens
Oct 02 2015 18:32 UTC
I play off and on
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:32 UTC
need to do it again sometime in the future
Steven Liekens
@StevenLiekens
Oct 02 2015 18:32 UTC
Most days I only log in to claim my dailies
and to check my tp listings
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:34 UTC
you know what's funny? If a case insensitive search doesn't return any results, but the case sensitive search of the same term returns results
Steven Liekens
@StevenLiekens
Oct 02 2015 18:34 UTC
hmm
okay so I got the stylecop branch
what do I need to do?
it builds fine on my pc
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:35 UTC
right click on the solution and select "analyze solution"
Steven Liekens
@StevenLiekens
Oct 02 2015 18:36 UTC
same as "run code analysis on solution"?
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:36 UTC
yep
there should be two errors
one generic, which is on the line of "code analysis has found some errors"
and the second is the mscorlib
Steven Liekens
@StevenLiekens
Oct 02 2015 18:38 UTC
yep
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:38 UTC
and I cannot reproduce thje error
if you select "Current Project" in the error list, the generic error comes from the main project
but the second is nowhere to be found
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:46 UTC
I mean, we could ignore the error, since it is not hampering the build process.
I'll let you look at it for some more time
while I'll fetch me something to eat
Steven Liekens
@StevenLiekens
Oct 02 2015 18:58 UTC
I ran the same command from the command line instead of visual studio
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:59 UTC
and?
Steven Liekens
@StevenLiekens
Oct 02 2015 18:59 UTC
it's more detailed
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:59 UTC
ah
what's it say
Steven Liekens
@StevenLiekens
Oct 02 2015 18:59 UTC
"D:\src\GW2.NET\GW2.NET.sln" (default target) (1) ->
"D:\src\GW2.NET\Testing\GW2.NET.Tests\GW2NET.Tests.csproj" (default target) (2) ->
"D:\src\GW2.NET\src\GW2NET\GW2NET.csproj" (default target) (6) ->
(RunCodeAnalysis target) -> 
  MSBUILD : error : CA0001 : Could not resolve reference to mscorlib, Version=2.0.5.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e, Retargetable=Yes. [D:\src\GW2.NET\src\GW2NET\GW2NET.csproj]
  MSBUILD : error : Code Analysis detected errors.  See Code Analysis results window or log file for details. [D:\src\GW2.NET\src\GW2NET\GW2NET.csproj]
so it's actually the GW2NET.Tests.csproj that fails
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 18:59 UTC
ah
then in probably know what the problem is
the tests project is not portable
Steven Liekens
@StevenLiekens
Oct 02 2015 19:00 UTC
yea
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:00 UTC
that'd mean they actually reference the same mscorlib
Steven Liekens
@StevenLiekens
Oct 02 2015 19:00 UTC
I think that could be it
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:00 UTC
but they don't see it that way
lemme change the type of the library
Steven Liekens
@StevenLiekens
Oct 02 2015 19:03 UTC
Aren't we excluding test projects from code analysis?
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:03 UTC
it get's done automatically
but the Stylecop analyzers thing still should run, since strictly speaking it's more code style
and tests should have the same style as the normal projects
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:13 UTC
hm
if I unload the project, the same error appears
Steven Liekens
@StevenLiekens
Oct 02 2015 19:15 UTC
And if you remove it from the solution?
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:15 UTC
checking that right now
same error
Steven Liekens
@StevenLiekens
Oct 02 2015 19:15 UTC
I know that some tools ignore loaded/unloaded state
Hm
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:15 UTC
hm
Steven Liekens
@StevenLiekens
Oct 02 2015 19:15 UTC
Weird
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:15 UTC
can you check it on your side, if you remove it?
Steven Liekens
@StevenLiekens
Oct 02 2015 19:17 UTC
Yeah hold on
Taking pizza out of the oven
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:17 UTC
kk
Steven Liekens
@StevenLiekens
Oct 02 2015 19:23 UTC
Unified primary reference "mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089". (TaskId:710)
62> Using this version instead of original version "2.0.0.0" in "D:\src\GW2.NET\packages\xunit.abstractions.2.0.0\lib\net35\xunit.abstractions.dll" because there is a more recent version of this framework file. (TaskId:710)
62> Resolved file path is "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework.NETFramework\v4.5.2\mscorlib.dll". (TaskId:710)
62> Reference found at search path location "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework.NETFramework\v4.5.2\mscorlib.dll". (TaskId:710)
62> This reference is not "CopyLocal" because it's a prerequisite file. (TaskId:710)
62> The ImageRuntimeVersion for this reference is "v4.0.30319". (TaskId:710)
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:23 UTC
so xUnit.
hm
It's latest version
I'll try something
Steven Liekens
@StevenLiekens
Oct 02 2015 19:26 UTC
wait
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:26 UTC
hm?
Steven Liekens
@StevenLiekens
Oct 02 2015 19:26 UTC
it did work
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:26 UTC
ok, what'd you do
Steven Liekens
@StevenLiekens
Oct 02 2015 19:26 UTC
the command line build succeeded after i removed the test project
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:26 UTC
huh
Steven Liekens
@StevenLiekens
Oct 02 2015 19:26 UTC
VS didn't though
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:26 UTC
hm
ok
this means we can safely ignore the error
Steven Liekens
@StevenLiekens
Oct 02 2015 19:28 UTC
msbuild /p:RunCodeAnalysis=true /v:diag
is what I use
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:28 UTC
from powershell?
Steven Liekens
@StevenLiekens
Oct 02 2015 19:28 UTC
developer command prompt
uhm
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:30 UTC
hm?
Steven Liekens
@StevenLiekens
Oct 02 2015 19:31 UTC
what is visual studio doing that msbuild doesn't when I run that command?
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:33 UTC
I don't know what flags the compiler gets passed
But I think we can agree, that we can ignore the errors
however, it seems that because there are these two errors. Fixes don't get applied automatically
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:39 UTC
w8
I get the same error when I run it from the command line
Steven Liekens
@StevenLiekens
Oct 02 2015 19:40 UTC
let me check what's in the csproj file
Steven Liekens
@StevenLiekens
Oct 02 2015 19:46 UTC
hey maybe this isn't even a stylecop thing
AutoMapper/AutoMapper#711
these guys have it too
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:46 UTC
I found that one, too
Steven Liekens
@StevenLiekens
Oct 02 2015 19:46 UTC
and they don't use the stylecop analyzers
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:46 UTC
Let me open the project in VS 2013
Steven Liekens
@StevenLiekens
Oct 02 2015 19:48 UTC
I'm running code analysis in VS2015 on the master branch
ha
whaddayaknow
CA0001
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 19:57 UTC
ah
ok
so it's a vs 2015 compiler error
just running it in Vs 2013 to confirm it
Steven Liekens
@StevenLiekens
Oct 02 2015 20:01 UTC
I think the problem might solve itself if we retarget for win8.1
PCL Profile151
wait what
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:03 UTC
can you check it?
Steven Liekens
@StevenLiekens
Oct 02 2015 20:04 UTC
in the UI, it says .NET Framework 4.5.1
but when I save and open the csproj file in notepad
<TargetFrameworkVersion>v4.6</TargetFrameworkVersion>
what's up with that :/
oh well I really don't care right now
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:08 UTC
where does it say that?
the tests project?
Steven Liekens
@StevenLiekens
Oct 02 2015 20:09 UTC
PCL
any PCL
right now they target profile 111 (win8+net45+wp81)
you can retarget them to profile 151 (win81+net451+wp81)
but when you do that, it actually changes the target framework version to 4.6
which is questionable as fuck
I think this is close to home
Steven Liekens
@StevenLiekens
Oct 02 2015 20:29 UTC
I got it to go away somehow
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:29 UTC
I'm trying something right now
Steven Liekens
@StevenLiekens
Oct 02 2015 20:30 UTC
me too
you know what solved it for me?
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:35 UTC
pray tell
Steven Liekens
@StevenLiekens
Oct 02 2015 20:39 UTC

<TargetFrameworkProfile>Profile151</TargetFrameworkProfile>

<TargetFrameworkVersion>v4.6</TargetFrameworkVersion>

and then
open a package manager console
Update-Package -Reinstall
that makes VS2015 happy
if I only reinstall packages without changing the target framework, I get very strange errors in Json.NET
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:42 UTC
but won't that make the library incompatible with Win Vista?
or can they use .net 4.6?
Steven Liekens
@StevenLiekens
Oct 02 2015 20:43 UTC
yeah
but only with SP2
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:43 UTC
ah ok
if someone does not have that, then he is stupid
Steven Liekens
@StevenLiekens
Oct 02 2015 20:43 UTC
true
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:44 UTC
shouldn't we retarget the whole project to 4.6?
Steven Liekens
@StevenLiekens
Oct 02 2015 20:45 UTC
maybe we should
I'm trying to come up with a reason not to
but,, nothing
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:46 UTC
ok
I'll incorporate that into the branch
Steven Liekens
@StevenLiekens
Oct 02 2015 20:46 UTC
well there is one thing
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:46 UTC
which is?
Steven Liekens
@StevenLiekens
Oct 02 2015 20:46 UTC
can't develop for 4.6 in VS2012
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:46 UTC
ok...
Steven Liekens
@StevenLiekens
Oct 02 2015 20:46 UTC
but there are community editions available
for 2013 and 2015
so yea...
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:46 UTC
yeah
ok, no real reason
I'll change that in the branch
Steven Liekens
@StevenLiekens
Oct 02 2015 20:47 UTC
I can send a PR
I already did it locally
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:47 UTC
into the branch would be perfect
Steven Liekens
@StevenLiekens
Oct 02 2015 20:52 UTC
okay so I changed these lines for all projects
<TargetFrameworkProfile>Profile151</TargetFrameworkProfile>
<TargetFrameworkVersion>v4.6</TargetFrameworkVersion>
<MinimumVisualStudioVersion>12.0</MinimumVisualStudioVersion>
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:52 UTC
merged PR
Steven Liekens
@StevenLiekens
Oct 02 2015 20:53 UTC
where 12.0 is VS2013
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:53 UTC
what would be the best to get it into the branch? I guess a rebase, isn't it?
Steven Liekens
@StevenLiekens
Oct 02 2015 20:53 UTC
yeah
git.exe rebase master
after pulling, of course
I wish visual studio would try to rebase before it tries to merge
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:54 UTC
did you install the git tools for Vs 2015?
Steven Liekens
@StevenLiekens
Oct 02 2015 20:55 UTC
yep
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:55 UTC
ah ok
and what about the github tools?
Steven Liekens
@StevenLiekens
Oct 02 2015 20:55 UTC
my biggest annoyance - when your local branch diverges from the origin branch
visual studio tries to merge the upstream branch into your local branch, instead of trying to rebase the local branch on the upstream branch
makes for messy commit history
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:56 UTC
that's why I almost never use the VS tools, except for simple commits
Steven Liekens
@StevenLiekens
Oct 02 2015 20:56 UTC
I installed the github tools but I haven't used them
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:57 UTC
is there a force switch for rebase?
Steven Liekens
@StevenLiekens
Oct 02 2015 20:58 UTC
if it finds merge conflicts then you have to fix them manually and then type git rebase --continue
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 20:58 UTC
ah ok
Steven Liekens
@StevenLiekens
Oct 02 2015 20:59 UTC
or if you want to go back to where you started then type git rebase --abort
Steven Liekens
@StevenLiekens
Oct 02 2015 21:05 UTC
oh and if you're wondering what files are conflicted then type git status
git add <conflictedfilepath> to mark a conflict as resolved
yeah I think that's about it
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 21:09 UTC
currently merging in the Vs2015 merge tool
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 21:46 UTC
OK
I'm not getting any errors anymore
and it has started to fix some warnings for itself
i still get "Rebuild All Failed", but everything is working as it should, so I'll ignore that one
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 21:59 UTC
ah, found the error
I borked some csproj merges
fixed that and now everything runs smooth
Steven Liekens
@StevenLiekens
Oct 02 2015 22:01 UTC
even code analysis?
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 22:01 UTC
yep
Steven Liekens
@StevenLiekens
Oct 02 2015 22:02 UTC
glad it's fixed now
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 22:02 UTC
and currently it's running and fixing some warnings
Steven Liekens
@StevenLiekens
Oct 02 2015 22:03 UTC
does it still warn for code generated by T4 templates?
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 22:03 UTC
which was generated again?
Steven Liekens
@StevenLiekens
Oct 02 2015 22:03 UTC
uhm well it only gets regenerated when you explicitly ask it to
Build | Transform All T4 Templates
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 22:04 UTC
ah ok
Steven Liekens
@StevenLiekens
Oct 02 2015 22:05 UTC
and you commit the generated files
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 22:05 UTC
As of my understanding it will only report the T4 templates, if they are not valid
since they get expanded to code that will be checked
so we ahve to check the templates temselves
Steven Liekens
@StevenLiekens
Oct 02 2015 22:06 UTC
I saw that it adds warnings for generated code
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 22:06 UTC
I get many warnings about double line breaks
and other warning in that direction
did you remove documentation from private fields?
Steven Liekens
@StevenLiekens
Oct 02 2015 22:07 UTC
the most useless ones yeah
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 22:08 UTC
Then we have to change the rules, but I like everything documented
Steven Liekens
@StevenLiekens
Oct 02 2015 22:08 UTC
I removed a lot of comments that added no value
a warning is better than a useless comment
I mean comments like <param name="serviceClient">The service client </param>
completely useless
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 22:10 UTC
still, it should be documented
don't assume anything
I grant you that we have bigger issues right now, but we should add it one by one if we have some spare time
I mean, the official style rules recommend documenting everything, and mostly the official source also documents the private items
Robert Logiewa
@Ruhrpottpatriot
Oct 02 2015 23:05 UTC
@StevenLiekens Boy... did your refactoring cause much work. Much more than in initially thought. I already fixed over 400 or so warnings and messages, but in the end I still have to fix over 1500 remaining.