These are chat archives for Ruhrpottpatriot/GW2.NET

4th
Feb 2016
ZedTheYeti
@ZedTheYeti
Feb 04 2016 03:01
Hello! I was wondering if anyone was working on implementing the V2 WvW API. If not I've been working with it in another project and would be willing to give it a go.
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 15:18
You are always welcome to implement the WvW Api and send us a pull request!
Currently I'm workling on a repository restructure, but seeing as WvW is a tad more complex it'll probably stay in the current for for a bit.
Steven Liekens
@StevenLiekens
Feb 04 2016 17:32
@Ruhrpottpatriot it would be better if you did that in public so we can see what's happening
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 17:33
I'm still experimenting with converters. There's some things that I need to experiment with. I'll upload some things this weekend though
Since we dropped ServiceManger, we need another converter on top of everything we have.
Steven Liekens
@StevenLiekens
Feb 04 2016 17:35
an actual converter or an object mapper?
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 17:37
A bit of botth. Currently I'm having a HttpResponseConverter (for a lack of better name), which extracts the content and headers. Then an injjected converter takes over and converts the data to actual objects we use. I'm just not sure how I should handle bulk and single responses.
Steven Liekens
@StevenLiekens
Feb 04 2016 17:38
are you still nesting converters?
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 17:38
If anything falls like I want it to, we don't need Bulk-, Reponse-, and PageResponse converter anymore
Only the data contract converters are needed
at least that is my goal
I sucessfully removed pages but that is more a result of restructuring the repositories.
Steven Liekens
@StevenLiekens
Feb 04 2016 17:40
but how will you know what collection type to deserialize as
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 17:41
That is the problem I'm, facing right now.
Steven Liekens
@StevenLiekens
Feb 04 2016 17:43
I think you can get rid of converters that know about HTTP metadata, but I don't think you can get rid of collection converters
but you can make them generic and pluggable
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 17:43
Probably
I wanted to build a flid interface for that but gave up on that
there is no way to make it generic
or at least I don't know of a way in c#
Haskell would be so much easier
Steven Liekens
@StevenLiekens
Feb 04 2016 17:44
the response format is the same across all endpoints, only the list items require specific converters
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 17:44
yep
Steven Liekens
@StevenLiekens
Feb 04 2016 17:47
that moment when someone closes your github issue and says it's "not an issue"
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 17:48
hey, it's not a bug, it's a feature
Steven Liekens
@StevenLiekens
Feb 04 2016 17:48
I'm like dude
if I can't use your code then there's an issue
dangrossman/bootstrap-daterangepicker#957 makes me sick
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 17:55
wait? His reason for closing this is, that UI wigets don't need to conform to a standard?
holy cow
Steven Liekens
@StevenLiekens
Feb 04 2016 17:57
yeah basically
and he doesn't know his own code
there's date parsing logic in his code but he says there isn't
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 18:03
I took the freedom to comment on it too
Steven Liekens
@StevenLiekens
Feb 04 2016 18:19
thanks
Steven Liekens
@StevenLiekens
Feb 04 2016 18:25
lol
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 18:25
his reply...
Steven Liekens
@StevenLiekens
Feb 04 2016 18:25
and then he locks the convo
no wonder there are 1600 forks
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 18:26
yeah
Steven Liekens
@StevenLiekens
Feb 04 2016 18:26
he refuses to fix his shit
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 18:26
yep
Steven Liekens
@StevenLiekens
Feb 04 2016 18:29
let's invent a new calendar with incremental dates
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 18:30
what do you mean by incremental dates?
Steven Liekens
@StevenLiekens
Feb 04 2016 18:30
integers
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 18:30
elaborate a bit more
Currently the repository looks like this to the outside
oh wait there is the base class missing
Steven Liekens
@StevenLiekens
Feb 04 2016 18:33
but where is the header metadata?
subcount and total count
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 18:34
wait a sec
OK, I updated the Gist
as for subtotal and total count
currently I don't support them. Adding them is easy though
I tried to reduce the options to the most essential
meaning: discover, single item, multiple items, multiple items filtered
Robert Logiewa
@Ruhrpottpatriot
Feb 04 2016 18:44
In my oppinion, pagination shouldn't be done by the user, but by us. And internally my curren code tries to use it
It's just not available to the user, since there is no benefit of using it.
As a better replacement I added filtering by a Func
Steven Liekens
@StevenLiekens
Feb 04 2016 18:56
or just give them the entire collection and let them filter it