Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Steven Liekens
@StevenLiekens
using MEF probably
Robert Logiewa
@Ruhrpottpatriot
seems reasonable
Steven Liekens
@StevenLiekens
they changed /v2/account/characters to simply /v2/characters
should probably rename the project
Robert Logiewa
@Ruhrpottpatriot
yup
shurne
@SamHurne
So what's the status of the changes required for the v1.2 build? I see Steven ("Steve" preferred?) added a couple bug fixes to the 1.0 branch. Are there any other changes required?
Steven Liekens
@StevenLiekens
I mailed updated nuget packages
both for 1.1 and 1.2
since 1.1 is unusable right now
I don't expect that anyone will still want to use 1.0 or 1.1 but it's bad form to skip a version
SteveN is fine btw
Steven Liekens
@StevenLiekens
@SamHurne what did you do to work around crashes in 1.0?
for g2wpao
Steven Liekens
@StevenLiekens
okay since we haven't pushed 1.2, I'm taking the liberty to make some improvements
and force push a new tag
Steven Liekens
@StevenLiekens
I'm changing GW2NET.Core package version restrictions to [$version$, 2.0)
from 1.2.0 onwards
which means "any version equal or greater than my version but less than 2.0"
so 1.2.0 will be able to use Core version 1.3.0 or 1.4.0 but not 2.0.0
Steven Liekens
@StevenLiekens
<dependency id="GW2NET.Core" version="[$version$,2.0)" />
Robert Logiewa
@Ruhrpottpatriot
Do I need to change the NuGet packages, or can I upload them as you mailed me?
Steven Liekens
@StevenLiekens
you can upload 1.1.0 but not 1.2.0
Robert Logiewa
@Ruhrpottpatriot
k
I'm currently looking into MEF and DI
Steven Liekens
@StevenLiekens
I'm making some last minute changes to 1.2.0
Robert Logiewa
@Ruhrpottpatriot
we might have a small problem with the way you proposed it, but I'm looking into a way to fix that
Steven Liekens
@StevenLiekens
bleh
I hate not knowing how to do something properly
Robert Logiewa
@Ruhrpottpatriot
hehe, go read it up :)
Steven Liekens
@StevenLiekens
if the problem is existing code then just throw it all out
I really want a proper bootstrapping and dependency management mechanism
Steven Liekens
@StevenLiekens
is one of the problems the fact that almost everything is internal?
crap
the guildwars2.com domain is blocked by my proxy
company proxy
well, it's good to know that the code handles it well
Steven Liekens
@StevenLiekens
forbidden.png
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot I pushed a new tag for 1.2.0 and this zip contains the packages for that commit
these packages have less strict version rules
so next time we find a bug in V2.Items or whatever, we only need to update V2.Items
instead of updating all packages
Robert Logiewa
@Ruhrpottpatriot
@StevenLiekens No, it has something to do with MEF by itself
@StevenLiekens You saw, that 1.20 does not build? see https://ci.appveyor.com/project/Ruhrpottpatriot/gw2-net
Steven Liekens
@StevenLiekens
missing packages
that's why
Robert Logiewa
@Ruhrpottpatriot
ah
Testing now, but I could be that MEF is not fully compatible with portable class libraries
Robert Logiewa
@Ruhrpottpatriot
Ok, we have a slight problem with MEF, while the PCL framework does support some of our needs, a few are sorely missing: a) we don't have re-composition, meaning after the parts have been discovered they stay that way for the application lifetime b) Importing custom collections is not possible c) we cannot import into fields or properties that are private. This means, we would have to make the imports publicy visible to everyone, of which I am not a fan.
Steven Liekens
@StevenLiekens
I don't mind c)