Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot I pushed a new tag for 1.2.0 and this zip contains the packages for that commit
these packages have less strict version rules
so next time we find a bug in V2.Items or whatever, we only need to update V2.Items
instead of updating all packages
Robert Logiewa
@Ruhrpottpatriot
@StevenLiekens No, it has something to do with MEF by itself
@StevenLiekens You saw, that 1.20 does not build? see https://ci.appveyor.com/project/Ruhrpottpatriot/gw2-net
Steven Liekens
@StevenLiekens
missing packages
that's why
Robert Logiewa
@Ruhrpottpatriot
ah
Testing now, but I could be that MEF is not fully compatible with portable class libraries
Robert Logiewa
@Ruhrpottpatriot
Ok, we have a slight problem with MEF, while the PCL framework does support some of our needs, a few are sorely missing: a) we don't have re-composition, meaning after the parts have been discovered they stay that way for the application lifetime b) Importing custom collections is not possible c) we cannot import into fields or properties that are private. This means, we would have to make the imports publicy visible to everyone, of which I am not a fan.
Steven Liekens
@StevenLiekens
I don't mind c)
but
is there no constructor injection in MEF?
or better
only use MEF at the boundaries between the bootstrapper and the individual service implementations
Steven Liekens
@StevenLiekens
and for the service implementation internals use a DI container
if that makes sense
like
we know everything about how to compose a ColorRepository for v1 and v2
so it wouldn't make sense to introduce MEF for composing it
we'd use a DI container for that
but the bootstrapper on the other hand knows what a ColorRepository is but not know how many versions of it are there
so that's where we'd use MEF to discover and load the correct version
Steven Liekens
@StevenLiekens
I hope my ramblings make sense
it does in my mind
Robert Logiewa
@Ruhrpottpatriot
MEF is a DI container in it's own right. However I only used MEF1 so far, and have to get into MEF2. And both are very different
Currently looking into autofac for DI and IoC
Most problems I face are bound to PCLs itself however, since we need to load the assemblies, but we only have Assembly.Load(), which does not allow loading from a path
Robert Logiewa
@Ruhrpottpatriot
@StevenLiekens You know how to get the path of the PC assembly?
Steven Liekens
@StevenLiekens
sorry, no
but
why do you need the path if you can't load from a path?
Robert Logiewa
@Ruhrpottpatriot
@/all See this blog post for commits
Robert Logiewa
@Ruhrpottpatriot
@/all Since I didn't want to talk about it all day, but also do something, you should read and comment on this pull request on the topic of JSON-Schemas: arenanet/api-cdi#93
This message was deleted
Steven Liekens
@StevenLiekens
looks good
but I'd rather wait for a response from ANet before commenting on it
because it's already a lot to take in and I don't want to overwhelm them
Steven Liekens
@StevenLiekens
btw what's the holdup for v1.1 / v1.2?
I don't know if I'm stressing this enough but our 1.0.1 packages are broken
Robert Logiewa
@Ruhrpottpatriot
I had an important talk with my Analysis Professor today. I'll upload the packages ASAP.
Robert Logiewa
@Ruhrpottpatriot
small thing: The current assembly version is set to 2.0, however we are releasing only 1.2, what is the reason for this?
Steven Liekens
@StevenLiekens
master branch is only for new developments -> 2.0
when you need to make changes to 1.x then you can create a new branch from the last v1.x.x tag and make your changes on there
bugfixes for v1 get merged back into master afterwards
but let's not write any new code for v1
we could, but that's gonna get confusing and difficult to merge
Steven Liekens
@StevenLiekens
oh anddddd