Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Steven Liekens
@StevenLiekens
so it wouldn't make sense to introduce MEF for composing it
we'd use a DI container for that
but the bootstrapper on the other hand knows what a ColorRepository is but not know how many versions of it are there
so that's where we'd use MEF to discover and load the correct version
I hope my ramblings make sense
it does in my mind
Robert Logiewa
@Ruhrpottpatriot
MEF is a DI container in it's own right. However I only used MEF1 so far, and have to get into MEF2. And both are very different
Currently looking into autofac for DI and IoC
Most problems I face are bound to PCLs itself however, since we need to load the assemblies, but we only have Assembly.Load(), which does not allow loading from a path
Robert Logiewa
@Ruhrpottpatriot
@StevenLiekens You know how to get the path of the PC assembly?
Steven Liekens
@StevenLiekens
sorry, no
but
why do you need the path if you can't load from a path?
Robert Logiewa
@Ruhrpottpatriot
@/all See this blog post for commits
Robert Logiewa
@Ruhrpottpatriot
@/all Since I didn't want to talk about it all day, but also do something, you should read and comment on this pull request on the topic of JSON-Schemas: arenanet/api-cdi#93
This message was deleted
Steven Liekens
@StevenLiekens
looks good
but I'd rather wait for a response from ANet before commenting on it
because it's already a lot to take in and I don't want to overwhelm them
Steven Liekens
@StevenLiekens
btw what's the holdup for v1.1 / v1.2?
I don't know if I'm stressing this enough but our 1.0.1 packages are broken
Robert Logiewa
@Ruhrpottpatriot
I had an important talk with my Analysis Professor today. I'll upload the packages ASAP.
Robert Logiewa
@Ruhrpottpatriot
small thing: The current assembly version is set to 2.0, however we are releasing only 1.2, what is the reason for this?
Steven Liekens
@StevenLiekens
master branch is only for new developments -> 2.0
when you need to make changes to 1.x then you can create a new branch from the last v1.x.x tag and make your changes on there
bugfixes for v1 get merged back into master afterwards
but let's not write any new code for v1
we could, but that's gonna get confusing and difficult to merge
Steven Liekens
@StevenLiekens
oh anddddd
the informational version contains a hyphen, indicating that it is prerelease
it's set to 2.0.0-0 (read as version 2.0.0, prerelease version 0)
should change it to 2.0.0-CI{build} in appveyor
so that it's like 2.0.0-CI1, 2.0.0-CI2, 2.0.0-CI3, ..., 2.0.0-CI100
Robert Logiewa
@Ruhrpottpatriot
If I understood you correctly, I need to build the NuGet Packages from the "Maintenance-1.0" branch?
Steven Liekens
@StevenLiekens
or any branch
as long as its based on tag v1.2.0
you can created branches from tags if you didn't know already
Steven Liekens
@StevenLiekens
that moment when you notice spelling mistakes after 5 minutes have passed and you're not allowed to edit
Steven Liekens
@StevenLiekens
so the main idea is to tag a commit when it is ready to publish
and only publish tagged commits
and when a release breaks, start a new branch from the tag that it was published from
Robert Logiewa
@Ruhrpottpatriot
@StevenLiekens Where did you put the release notes for version 1.1 and 1.2?
Steven Liekens
@StevenLiekens
commit history
it's less than 10 commits
nothing has changed for 1.1
it's the same changeset that was used to publish V2.Items 1.1.0
only you didn't publish the rest of the packages
making it impossible to update to 1.1
so no changes for 1.1.0 other than the ones that are already documented