Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Steven Liekens
@StevenLiekens
so that it's like 2.0.0-CI1, 2.0.0-CI2, 2.0.0-CI3, ..., 2.0.0-CI100
Robert Logiewa
@Ruhrpottpatriot
If I understood you correctly, I need to build the NuGet Packages from the "Maintenance-1.0" branch?
Steven Liekens
@StevenLiekens
or any branch
as long as its based on tag v1.2.0
you can created branches from tags if you didn't know already
Steven Liekens
@StevenLiekens
that moment when you notice spelling mistakes after 5 minutes have passed and you're not allowed to edit
Steven Liekens
@StevenLiekens
so the main idea is to tag a commit when it is ready to publish
and only publish tagged commits
and when a release breaks, start a new branch from the tag that it was published from
Robert Logiewa
@Ruhrpottpatriot
@StevenLiekens Where did you put the release notes for version 1.1 and 1.2?
Steven Liekens
@StevenLiekens
commit history
it's less than 10 commits
nothing has changed for 1.1
it's the same changeset that was used to publish V2.Items 1.1.0
only you didn't publish the rest of the packages
making it impossible to update to 1.1
so no changes for 1.1.0 other than the ones that are already documented
and then a few changes for 1.2.0 that are not yet documented outside of commit messages
Steven Liekens
@StevenLiekens
except that's a lie
I did update the package release notes for 1.2
Robert Logiewa
@Ruhrpottpatriot
hm
github does not show anything
Steven Liekens
@StevenLiekens
I haven't figured out how to add release notes to tags yet
but the packages that I zipped have release notes in their metadata
Steven Liekens
@StevenLiekens
@SamHurne I saw that you had concurrency issues with the mumble link layer
do you think this is something that should be handled by the library?
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot let's update the implementation progress table with new endpoints from this page https://api.guildwars2.com/v2
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot can you hide the restsharp package from search? it's not supported as of 1.0.0
there's no restsharp code anywhere in 1.0.0 or newer
and I still want us to drop the IServiceClient stuff and replace it with System.Net.Http stuff
Robert Logiewa
@Ruhrpottpatriot
Hiding the R# package is not possible I'll upload a small update that only changes the version requirement of the package to below 1.0 That should fix the problem.
Robert Logiewa
@Ruhrpottpatriot
As for release notes: If you add a release via GitHub itself you can set release notes. That is what we should do.
shurne
@SamHurne
About the mumble link concurrency issue: I guess I'm not really sure... it looks like you can read from the mumble link memory-mapped file at the same time as the client is writing to it, causing serialization issues. What should be the behavior of the library if that occurs? Catch it and try again? Catch it and return a null value? Catch it and re-throw?
Robert Logiewa
@Ruhrpottpatriot
I vote for a behaviour similar to Entitiy Framework: Throwing an exception. This is what I'd expect if I wanted to try to access an object already in use
@StevenLiekens I can't access the notes for the releases somehow
shurne
@SamHurne
Also, should we start creating Issues in Github to help track all these various topics? Some of them aren't necessarily "issues", but it's common to use Issues to keep track of general work items. Perhaps we should also move over some of the work items from codeplex?
Robert Logiewa
@Ruhrpottpatriot
sure we can do that
btw @SamHurne, did you see arenanet/api-cdi#93
shurne
@SamHurne
Yup, good PR. Knowing something is broken because the schema changed would definitely be an improvement.
Robert Logiewa
@Ruhrpottpatriot
Could you comment on it too? Seems a bit lonely there with only me and Iye :)
On a sidenote: When I query v2/commerce/listings/{id}, could you call the topmost result a tradingpostItem?
I.e. the result I get back when I call, e.g. https://api.guildwars2.com/v2/commerce/listings/24
shurne
@SamHurne
Yea, maybe "TradingPostItem", "ItemListings", or "ItemTradingPostListings"? If you call the topmost result of /v2/commerce/prices/{id} "ItemPrices", I'd name v2/commerce/listings/{id} "ItemListings"
or maybe TradingPostItemPrices and TradingPostItem... idk. It should probably be consistent/related for the 2 endpoints though
Robert Logiewa
@Ruhrpottpatriot
In the schema I called it tradingpostItem and the others listing and listingCollection
that seemed like a reasonable choice
shurne
@SamHurne
That seems fine to me
Robert Logiewa
@Ruhrpottpatriot
So v2/commerce/listings schema done
now the other two
Robert Logiewa
@Ruhrpottpatriot
damn the exchange schema was challenging.