Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Steven Liekens
@StevenLiekens
you might want to turn it down a bit
maybe int.MaxValue is a bad idea
shurne
@SamHurne
Yea, I'm going to do some measurements and testing -- had the same thought
Steven Liekens
@StevenLiekens

I'm getting a lot of these

GW2PAO.vshost.exe Warning: 0 : 2015-09-19 22:36:17.1721|WARN|GW2PAO.API.Data.ItemsDatabaseBuilder|Failed to retrieve items page 155 of 226.
GW2PAO.vshost.exe Warning: 0 : 2015-09-19 22:36:17.1911|WARN|GW2PAO.API.Data.ItemsDatabaseBuilder|Failed to retrieve items page 156 of 226.
GW2PAO.vshost.exe Warning: 0 : 2015-09-19 22:36:17.1911|WARN|GW2PAO.API.Data.ItemsDatabaseBuilder|Failed to retrieve items page 157 of 226.
GW2PAO.vshost.exe Warning: 0 : 2015-09-19 22:36:17.1911|WARN|GW2PAO.API.Data.ItemsDatabaseBuilder|Failed to retrieve items page 158 of 226.

which by the way has nothing to do with the actual page being requested
it's not page 155
it's whatever page would be the 155th page to complete
Steven Liekens
@StevenLiekens
actually that error is another client side thing
sockets timing out
A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond 64.25.47.16:443
Steven Liekens
@StevenLiekens
okay this is probably just me being stupid but I can't get NLog to log exceptions
shurne
@SamHurne
logger.Error("it blew up!", ex);?
Steven Liekens
@StevenLiekens
it definitely doesn't print them to the output window
where's the log file?
oh there's no file target?
shurne
@SamHurne
For the PAO, logs are thrown into a Logs folder next to the .exe
Steven Liekens
@StevenLiekens
ooooooooh
okay thanks
no still nothing
it logs the message but not the excepton
Steven Liekens
@StevenLiekens
NLog looks pretty broken to me
:D
shurne
@SamHurne
Hmmm, you can always do logger.Error("it blew up! {0}", ex.ToString());, but yea, I don't know why it's not just printing the exception like it says it will
Maybe it's an issue in the version I'm using - 3.2
Steven Liekens
@StevenLiekens
maybe
but I think it expects additional configuration
like you need to tell it how to format the exception
or it prints nothing at all
Steven Liekens
@StevenLiekens
ehh I give up
I don't know how to tamper with timeout values at the socket level
let's just all agree not to send 200 requests at the same time
shurne
@SamHurne
:thumbsup: Sounds good to me
Steven Liekens
@StevenLiekens
or let's switch to System.Net.Http.HttpClient and hope that it does not have the same problem
shurne
@SamHurne
Confirmed that NLog does not log the actual exception unless it's included in a target's layout, which it isn't by default (which is silly!)
Steven Liekens
@StevenLiekens
almost as silly as the fact that NLog.dll references System.Windows.Forms
wanna know why? to support the RichTextBox control in winfoms as a logging target
shurne
@SamHurne
Nice
So, I think I'm satisfied with the PR on the PAO at this point. Any other changes your making on it before I merge it in and set the limit to 20?
Steven Liekens
@StevenLiekens
yeah
shurne
@SamHurne
K
Steven Liekens
@StevenLiekens
logging the exception when task.IsFaulted
instead of logging meaningless page numbers
but, I still don't know how to configure NLog to do that
shurne
@SamHurne
Gotcha. I just commited the change required to the NLog.config file to make it actually log exceptions. So feel free to use the exception-logging methods
Steven Liekens
@StevenLiekens
ok hold on
Steven Liekens
@StevenLiekens
okay it should be good to go now
I stopped getting socket timeouts when I changed the connection limit to 20
I don't know what the default is... I think 2?
shurne
@SamHurne
Yea, must be something low like that
Steven Liekens
@StevenLiekens
hey I think you can control the degree of parallelism for Parallel.For by passing ParallelOptions