Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Steven Liekens
@StevenLiekens
how much gold do you guys have ingame?
I have about 500g cash and another 1000g in tradables but it's never enough
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot a lot of internal types need to be converted to public if we want to implement constructor injection
as well as a number of internal constructors (not sure what I was thinking there)
a lot of classes implement this anti-pattern
// default ctor, public
public Foo() : this(new Dependency1(), new Dependency2()) {};

// DI ctor, internal
internal Foo(IDependency dependency1, IDependency2 dependency2)
{
    ...
}
Robert Logiewa
@Ruhrpottpatriot
leave it for now. I'm thinking of a way to implement automatic conversion, so we don't need to clutter the repositories with converter references
Steven Liekens
@StevenLiekens
it's not just the converters
I just want to better organize the clutter
and move all initialization code to the bootstrapper
Steven Liekens
@StevenLiekens
btw are you not more worried about getting rid of IServiceClient?
I haven't had any problems with IConverter but I've had lots of problems with IServiceClient
Robert Logiewa
@Ruhrpottpatriot
In had no problems with IServiceClient
mafflerbach
@mafflerbach
i think in summery i have 20g ^^
Steven Liekens
@StevenLiekens
are we all using vs2015 community?
in other words can I use C# 6 features?
resharper keeps suggesting to use nameof()
I think that's an excellent suggestion
Robert Logiewa
@Ruhrpottpatriot
I currently use VS 2013
Steven Liekens
@StevenLiekens
why
Robert Logiewa
@Ruhrpottpatriot
because somewhen in the next few months I'll get VS2015 Enterprise from my Uni for free
Steven Liekens
@StevenLiekens
Robert Logiewa
@Ruhrpottpatriot
Will do. I got access to the wiki editing
mafflerbach
@mafflerbach
good night every one wave
Robert Logiewa
@Ruhrpottpatriot
If we want to get rid of the IService client, how would we deal with Mocks? We are not using them right now, but we should. Since you can't mock a web request and Response, we need to abstract it and that is the purpose of IServiceClient. This SO question deals with HttpWebRequest/HttpWebResponse, but the point still stands.
Steven Liekens
@StevenLiekens
you're thinking of the wrong classes
HttpClient can be mocked
and will replace ServiceClient
Steven Liekens
@StevenLiekens
so even though it has no interface and can't be mocked with conventional mocking frameworks, it's still testable
as opposed to HttpWebRequest/HttpWebResponse
HttpClient uses HttpRequestMessage and HttpResponseMessage
and a pipeline of message handlers that you can plug in to
it's a very flexible API
much better than what we have now
the only reason why I didn't use it in the first place is because it isn't in .NET 4
it's new in 4.5
we were still using 4.0 at the time
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot you don't really want to keep using something that I wrote instead of the base class library
trust me ;)
Robert Logiewa
@Ruhrpottpatriot
This message was deleted
Steven Liekens
@StevenLiekens
@SamHurne what do you think about my comment on #3
Steven Liekens
@StevenLiekens
anyone mind if I do a mass rename of "ConverterForXyz" to simply "XyzConverter"?
Robert Logiewa
@Ruhrpottpatriot
No
do it
I always wondered why you named them that way
wanted to open an issue, but i forgot about it
Steven Liekens
@StevenLiekens
I don't remember
anyway I'm changing it now
on my own branch