Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Steven Liekens
@StevenLiekens
annoying
Robert Logiewa
@Ruhrpottpatriot
is Unwrap() available. If not, we should code an extension method.
Steven Liekens
@StevenLiekens
or we could just fix the damn code :smile:
I'm writing integration tests that show where the problems are
because it's not obvious just by looking at the code
btw the real fix is to use await
do a search for task.Result and replace with await task
and mark the methods as async
that immediately fixes it
Robert Logiewa
@Ruhrpottpatriot
Unwrap() nearly does the same thing as await, it was intended that way :)
Steven Liekens
@StevenLiekens
I don't follow
well I just looked it up and it looks like something different
Robert Logiewa
@Ruhrpottpatriot
It's a side effect of the await Keyword. If you have a nested type in parralelism awaitcan unwrap those types.
Steven Liekens
@StevenLiekens
but the code is not using await
that's the problem
I'm not trying to unwrap a task result, I'm trying to unwrap an AggregateException that is thrown from code that tries to access task.Result and is itself running inside a task
I think words aren't helpful in trying to explain it :smile:
Steven Liekens
@StevenLiekens
that fiddle is a reproduction of what I'm seeing
if you look at the stack trace then you can see what's wrong
Steven Liekens
@StevenLiekens
oh man
I just found a way to use the API as a data source for data driven tests
like you can have a test method with a parameter (int id)
and then for every ID in the API, run that test
Steven Liekens
@StevenLiekens
downside is that the whole thing kinda falls apart as soon as the Discover() method stops working
Robert Logiewa
@Ruhrpottpatriot
maybe you should look at IClassFixture<T> and ICollectionFixture<T>
Steven Liekens
@StevenLiekens
I was wondering about that
right now I'm using [MemberDataAttribute("Discover")]
and I'm wondering how often the test runner calls the Discover() method
I know that fixtures are cached, but what about MemberData?
Steven Liekens
@StevenLiekens
public static IEnumerable<object[]> Discover()
{
    return repository.Discover().Select(o => new object[] { o });
}

[Theory]
[MemberData("Discover")]
public void FindAll(int identifier)
{
    var result = repository.Find(identifier);
    Assert.NotNull(result);
}
is there a better way?
using fixtures?
Steven Liekens
@StevenLiekens
I'm at work right now so I can't really do anything, but I'll try to send that PR today
there will be some new tests that always fail, but I want to reintegrate my changes back to master before attempting to fix the errors
Robert Logiewa
@Ruhrpottpatriot
I think we should seriously considering mocking the responses.
With that we are independent of the ANet servers
Steven Liekens
@StevenLiekens
that's the next step
right now I just want to have a set of end-to-end tests that show how reliable the library is as a whole
so no mocking of any sort
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot took me a little longer but here it is Ruhrpottpatriot/GW2.NET#14
the diff is completely messed up but please ask if you have any questions about the changes
Robert Logiewa
@Ruhrpottpatriot
@/all I'll look at the PR tomorrow, but a quick glance looks promising
I'll also (hopefully) add instructions on migrating away from StyleCop, which is not maintained very well, and towards Stylecop.Analyzers. The latter builds on Roslyn and is the new go to for code analysis.
Steven Liekens
@StevenLiekens
can we do something about the huge number of warnings about missing comments?
I don't think they belong in a build log
Steven Liekens
@StevenLiekens
for CI builds anyway
Robert Logiewa
@Ruhrpottpatriot
currently we can't. That's the way Stylecop works. When I got the move to the new Roslyn based Stylecop.Analyzers done we can set the output to a different level so they won't show up in a log.
Steven Liekens
@StevenLiekens
they're actually not stylecop messages
Steven Liekens
@StevenLiekens
"To disable in 'Project properties' go to Project properties -> Build > "Errors and warnings" (section), Suppress Warnings (textbox), add 1591 (comma separated list) –"