Ruhrpottpatriot/GW2.NET

Robert Logiewa

@Ruhrpottpatriot

oh god, this is sooo horrible

public async Task<ICollectionPage<ColorPalette>> FindPageAsync(int pageIndex, CancellationToken cancellationToken)
        {
            UrlEncodedForm formData = new UrlEncodedForm
            {
                { "lang", this.Culture.TwoLetterISOLanguageName },
                { "page", pageIndex.ToString() }
            };

            var request = new HttpRequestMessage(HttpMethod.Get, new Uri("v2/colors" + formData, UriKind.Relative));
            var response = await this.httpClient.SendAsync(request, cancellationToken).ConfigureAwait(false);
            return await this.pageResponseConverter.ConvertAsync(response, cancellationToken);
        }

well I'll think of something better later on

Steven Liekens

@StevenLiekens

I don't think it's horrible

Robert Logiewa

@Ruhrpottpatriot

yes, because I ahve it in every method and use magic string

I'll try to get something more compile safe

Steven Liekens

@StevenLiekens

there appears to be no way for a PCL library to search for assemblies outside itself

but PCL libs can still load assemblies by their fully qualified assembly name

I'm thinking that the bootstrapper should allow you to pass a list of assembly names

Robert Logiewa

@Ruhrpottpatriot

yeah

that sounds like a good way

So I got it more compile safe and it seems good

havn't run unit tests though

Steven Liekens

@StevenLiekens

@Ruhrpottpatriot are you good with algorithms?

Robert Logiewa

@Ruhrpottpatriot

Yup

Steven Liekens

@StevenLiekens

the computersciency ones

Robert Logiewa

@Ruhrpottpatriot

ohj

those

Steven Liekens

@StevenLiekens

wow that was fast

Robert Logiewa

@Ruhrpottpatriot

those algos

Somewhat

Steven Liekens

@StevenLiekens

don't worry I'm not gonna ask you to write a quicksort

Robert Logiewa

@Ruhrpottpatriot

QS is easy^^

especially in Haskell

so what's it about

Steven Liekens

@StevenLiekens

just gonna ask if you've ever written a circular buffer

Robert Logiewa

@Ruhrpottpatriot

nope

why?

Steven Liekens

@StevenLiekens

I need one

Robert Logiewa

@Ruhrpottpatriot

in C#?

Steven Liekens

@StevenLiekens

yeah

Robert Logiewa

@Ruhrpottpatriot

tried something like a LinkedList for that?

I mean that's totally basic

but it should work

Steven Liekens

@StevenLiekens

the buffer is fixed size

linkedlist sounds overkill

Robert Logiewa

@Ruhrpottpatriot

yeah

Steven Liekens

@StevenLiekens

I basically need a byte[] array and a way to remember how full the buffer is and where it begins or ends

it doesn't need to shrink or grow, ever

Robert Logiewa

@Ruhrpottpatriot

hmm

Steven Liekens

@StevenLiekens

the part that I'm stuck on is keeping track of where the head and tail are

Robert Logiewa

@Ruhrpottpatriot

Write your "own" Array class with two additional properties Start and End

We can safely assume that you always append after the last item

so we have no empty spaces

Steven Liekens

@StevenLiekens

problem is when head == tail, is the buffer full or empty?

Robert Logiewa

@Ruhrpottpatriot

Full, when the Length property equals the Size

otherwise empty

Where communities thrive

People

Repo info

Activity