Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Steven Liekens
@StevenLiekens
just gotta flip a bit every time a read or write operation wraps around the end of the array
if the head and tail are the same, the buffer is full when the bit is 1
otherwise it's empty
Robert Logiewa
@Ruhrpottpatriot
oh
well that is really easy
So the move to HttpClient goes along well
but it's much work
Since there are a lot of changes under the hood
Steven Liekens
@StevenLiekens
did you figure out how to handle query strings?
I know that nowhere in the HTTP spec does it say that query strings have to be name-value pairs
but it's weird to me that they don't provide a dictionary type interface for setting the query parameters
Robert Logiewa
@Ruhrpottpatriot
I have
I built a custom class which takes some inspiration fomr the HttpHeaderCollection class
I have a class where you can set the headers and then you call BuildQueryString, which you only need to append to the uri
Steven Liekens
@StevenLiekens
the codeplex link to github is broken
Robert Logiewa
@Ruhrpottpatriot
will fix it
thanks for the info
btw: does anybody here know how to make a cross platform console application in c#?
Robert Logiewa
@Ruhrpottpatriot
@StevenLiekens: Since you did more with NuGet, could you look into THIS Vs extension and tell me if this is applicable for us?
Steven Liekens
@StevenLiekens
I'd stay away from it
Robert Logiewa
@Ruhrpottpatriot
ok
Steven Liekens
@StevenLiekens
"To publish a new version of your package, bump the version number in the .nuspec file."
we don't set the version in the nuspec
Robert Logiewa
@Ruhrpottpatriot
ah ok
Steven Liekens
@StevenLiekens
you know appveyor supports packing and pushing nuget packages?
which is useful for prerelease packages
and maybe release packages if you're careful enough
Robert Logiewa
@Ruhrpottpatriot
I'll look into it later
Steven Liekens
@StevenLiekens
if we switch to implicit IRepository implementations then we must clearly document unsupported methods in the <summary> tag
though I would still recommend programming against IRepository instead of its implementations
and write code that handles NotSupportedException for any of its methods
Robert Logiewa
@Ruhrpottpatriot
I'll refactor IReposity, too. There is no need for IRepository to implement IDiscoverable and the other interfaces.
Robert Logiewa
@Ruhrpottpatriot
With that, the e.g. IBuild service now implements IDiscoverable. The IItemService implements IDiscoverService, ILocalizable, IFindService, IPageService, etc.
This gives us more control over the objects, and we don't need to throw NotSupported exceptions, since the repository in question does not implement the method at all.
Robert Logiewa
@Ruhrpottpatriot
OK, I'm halting the refactoring. I'm currently learning the new ASP.NET 5 project structure, which offers a much simpler and cleaner way to code, build and publish (NuGet) packages, while still maintaining cross platform compatibility and giving us more ways to code.
Steven Liekens
@StevenLiekens
is it just the project structure that changes?
or also the platforms that we (can) target?
Steven Liekens
@StevenLiekens
right now we target desktop apps (net452 or newer) and store apps (win8.1/wp8.1 or newer)
I'm not sure about Xamarin
I don't think Xamarin supports PCL profile 151, but that's a Mono issue
Robert Logiewa
@Ruhrpottpatriot
we can target more profiles
Steven Liekens
@StevenLiekens
heart of thorns is out
I'm just saying because they probably added new entity types to the API
maybe some new item types and recipe types
a new wvw map type
it's not too much effort to add those to 1.3 and call it 1.4
Robert Logiewa
@Ruhrpottpatriot
could you do it next week?
or @SamHurne
Steven Liekens
@StevenLiekens
let me see if I can list all changes that need to be implemented for HoT