Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Steven Liekens
@StevenLiekens
for me it's whatever
I just don't want to keep having to update old code for new game features
Robert Logiewa
@Ruhrpottpatriot
yeah I can understand that
Robert Logiewa
@Ruhrpottpatriot
damn, now that I know more about expression trees and IQueryable, I sort of want to implement it into GW2.NET...
Steven Liekens
@StevenLiekens
isn't the api too limited for what IQueryable can do?
Robert Logiewa
@Ruhrpottpatriot
not at all
the main benefit of IQuerable are Expressions and ExpressionTrees
Steven Liekens
@StevenLiekens
like how you can only query 200 ids at a time
and how you can't do an accurate .Skip() and .Take() because of how paging works
Robert Logiewa
@Ruhrpottpatriot
that is not a problem of IQueryable. Think of it as a possibility to construct lambdas and other expressions on the fly and then translate them into something else
you don't have to implement those methods
remember, those are extension methods
they are not built into the interface
ok
hm...
I need to get into this a bit more
but it should be possible
Steven Liekens
@StevenLiekens
items.Skip(49).Take(50)
can you?
I think you would have to do something like that
and then merge the collections
lol
it's definitely a challenge
Robert Logiewa
@Ruhrpottpatriot
yeah. That was pretty clear to me. However I'm currently writing my own parser for some strings and expressions trees are a neat way to do that.
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot I figured out what's up with #35
it wasn't an API change that causes it
it's a threading issue
there's a for-loop that increments the current pageIndex before the code in the body of the loop gets a chance to run
Steven Liekens
@StevenLiekens
but yeah I can fix it
Steven Liekens
@StevenLiekens
oh ffs
can they please stop updating the API
thanks
Robert Logiewa
@Ruhrpottpatriot
xD, yeah that is a problem
BTW: I think implementing IQueryable isn't a big problem. URL transformation is a bit work and error prone, so maybe make another push for them implementing OData?
Steven Liekens
@StevenLiekens
odata is never gonna happen
but I don't see how else you're gonna do this
there's millions of valid linq queries that are not supported by the API
from c in colors where c.Name == "Black" select c;
Steven Liekens
@StevenLiekens
I don't like IQueryable that much tbh
Robert Logiewa
@Ruhrpottpatriot
We don't have to support all. Throwing exceptions for queries that are not supported is a totally fine way to do with IQueryable
Steven Liekens
@StevenLiekens
it promises too much
Robert Logiewa
@Ruhrpottpatriot
It's a header interface after all
There is another way to do this:
We don't implement IQueryable, but write our own somewhat similar stuff
I'm doing something similar at the moment with a parser I'm writing
Expressions offer a unique way to build up queries
Steven Liekens
@StevenLiekens
there's no way that we can provide a usable IQueryable implementation without requiring that you read the API documentation to see what is supported or not
like for /v2/colors
Robert Logiewa
@Ruhrpottpatriot
See my other option