Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Robert Logiewa
@Ruhrpottpatriot
my algorithm, which is really a two liner, just calculates the page sizes and give them back as an array
thus we only request the items we need
btw:
The items endpoint, does not have an ids=all parameter
so we need to do it different
Steven Liekens
@StevenLiekens
with paging
Robert Logiewa
@Ruhrpottpatriot
yep
Steven Liekens
@StevenLiekens
ids=all is useless
Robert Logiewa
@Ruhrpottpatriot
i know
but it'd make querying easier for a FindAll()
Steven Liekens
@StevenLiekens
unless they ever add endpoints that support ids=all with more than 200 results, let's just stick with page requests
Robert Logiewa
@Ruhrpottpatriot
I propose:
  1. do a discover
  2. Pass all the ids to a suitable Find(identifiers) method and return
that's the easiest way
Actually, if the request is not a single item request I'm only using paging right now
Converters did change a bit, I'm experimenting a bit still, but I'm trying to make the converters type safe, but non generic so we can pass them around easier.
The goal is, that you only need to pass only the necessary converters, and not do stuff like pass the whole batch converters etc.
Higher order is a wunderful thing :P
Robert Logiewa
@Ruhrpottpatriot
I'd like partial function application too, but hey, C# not totally functional... I'd have to go with F# for that :)
Steven Liekens
@StevenLiekens
realistically how much refactoring do you think there is left before we can work on planned new features?
Steven Liekens
@StevenLiekens
I'm converting some of my smaller projects on github to aspnet5 class libraries
so I won't be completely clueless when we make that switch
OH happy new year by the way
Steven Liekens
@StevenLiekens
I'm having so many issues with line endings in git <> visual studio
it's not even funny
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot ping
Robert Logiewa
@Ruhrpottpatriot
You have to set the line ending handling in Git, see HERE fore more infos
Happy new year BTW
Also I'm currently refactoring the repositories to use HTTPClient and the new repository layout. Converters will stay the same for now. After those chances work fine we can tackle the converters itself
I'm also thinking of a very basic and small InMemory cache
Robert Logiewa
@Ruhrpottpatriot
help me out with this: The only time an item in the cache becomes stale is, if it implements ITimesensitive and the stored timestamp is outside of a set margin, or if a new build comes out, right?
Steven Liekens
@StevenLiekens
or if the cache header expires
well
what you said about ITimeSensitive
where the margin is set by a response header
Robert Logiewa
@Ruhrpottpatriot
So the date set in ITimeSensitive is the time the chache expires, right?
Steven Liekens
@StevenLiekens
not exactly
Robert Logiewa
@Ruhrpottpatriot
how do I have to treat it then?
Steven Liekens
@StevenLiekens
the date set in ITimeSensitive is the Date header
which is the server time when the response was generated
Robert Logiewa
@Ruhrpottpatriot
ah
Steven Liekens
@StevenLiekens
more recently they added cache headers that contains the expiry date for that response
Robert Logiewa
@Ruhrpottpatriot
So it'd be best to add to the ITimeSensitive header a property that tells us when it expires?
Steven Liekens
@StevenLiekens
so ITimeSensitive needs to be updated with an Expires : DateTimeOffset property
Robert Logiewa
@Ruhrpottpatriot
yeah thought so too
Steven Liekens
@StevenLiekens
apparently there was a big patch today
who knows what they changed this time :(
Robert Logiewa
@Ruhrpottpatriot
^^
Oh boy, was it DateTime or DateTimeOffset? The latter, right?
Steven Liekens
@StevenLiekens
yeah
Robert Logiewa
@Ruhrpottpatriot
Why do they even have to. As far as I understood it, DateTime was localized and DateTimeOffset not. Why not just implement one with a method to convert it to local time...
Steven Liekens
@StevenLiekens
DateTimeOffset is used to represent an instant
DateTime is used to represent a moment