Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Robert Logiewa
@Ruhrpottpatriot
help me out with this: The only time an item in the cache becomes stale is, if it implements ITimesensitive and the stored timestamp is outside of a set margin, or if a new build comes out, right?
Steven Liekens
@StevenLiekens
or if the cache header expires
well
what you said about ITimeSensitive
where the margin is set by a response header
Robert Logiewa
@Ruhrpottpatriot
So the date set in ITimeSensitive is the time the chache expires, right?
Steven Liekens
@StevenLiekens
not exactly
Robert Logiewa
@Ruhrpottpatriot
how do I have to treat it then?
Steven Liekens
@StevenLiekens
the date set in ITimeSensitive is the Date header
which is the server time when the response was generated
Robert Logiewa
@Ruhrpottpatriot
ah
Steven Liekens
@StevenLiekens
more recently they added cache headers that contains the expiry date for that response
Robert Logiewa
@Ruhrpottpatriot
So it'd be best to add to the ITimeSensitive header a property that tells us when it expires?
Steven Liekens
@StevenLiekens
so ITimeSensitive needs to be updated with an Expires : DateTimeOffset property
Robert Logiewa
@Ruhrpottpatriot
yeah thought so too
Steven Liekens
@StevenLiekens
apparently there was a big patch today
who knows what they changed this time :(
Robert Logiewa
@Ruhrpottpatriot
^^
Oh boy, was it DateTime or DateTimeOffset? The latter, right?
Steven Liekens
@StevenLiekens
yeah
Robert Logiewa
@Ruhrpottpatriot
Why do they even have to. As far as I understood it, DateTime was localized and DateTimeOffset not. Why not just implement one with a method to convert it to local time...
Steven Liekens
@StevenLiekens
DateTimeOffset is used to represent an instant
DateTime is used to represent a moment
Robert Logiewa
@Ruhrpottpatriot
so what's the difference then?
Steven Liekens
@StevenLiekens
where the first is absolute and the latter is relative
eg. noon is the moment when most people eat lunch
Robert Logiewa
@Ruhrpottpatriot
ah
Steven Liekens
@StevenLiekens
but it is relative to where you are
but if I say I'm eating lunch this instant
then that's a DateTimeOffset
:)
that signature sounds right, or did I miss something?
Steven Liekens
@StevenLiekens
besides the name?
Robert Logiewa
@Ruhrpottpatriot
yeah
Steven Liekens
@StevenLiekens
how do you look up values by key?
Robert Logiewa
@Ruhrpottpatriot
Via the Get(Func<T,bool>) method
sec
You could write var items = cache.Get(i => i.Id == someId)
or you could run a LINQ query on the Values property, but then you'd have to filter for a possible localized item
Steven Liekens
@StevenLiekens
you have to do that anyway
the unique key for any localized item is id + lang
Robert Logiewa
@Ruhrpottpatriot
Yeah, I just saw that too. I'm trying to do it that if I use the Get method only objects for the current repository langauge are returned and Value is used to acess the complete repository
Steven Liekens
@StevenLiekens
by the way can you pull from here https://github.com/StevenLiekens/GW2.NET
it's kind of a messy situation with changes happening in both master and maintenance
Steven Liekens
@StevenLiekens
Still have to change chat codes in maintenance :( the game client uses new header bytes
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot core.autocrlf "true" converts all line endings to LF when committing
then converts them back to CRLF when checking out
is that what we want?
Robert Logiewa
@Ruhrpottpatriot
yes