Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Steven Liekens
@StevenLiekens
who knows what they changed this time :(
Robert Logiewa
@Ruhrpottpatriot
^^
Oh boy, was it DateTime or DateTimeOffset? The latter, right?
Steven Liekens
@StevenLiekens
yeah
Robert Logiewa
@Ruhrpottpatriot
Why do they even have to. As far as I understood it, DateTime was localized and DateTimeOffset not. Why not just implement one with a method to convert it to local time...
Steven Liekens
@StevenLiekens
DateTimeOffset is used to represent an instant
DateTime is used to represent a moment
Robert Logiewa
@Ruhrpottpatriot
so what's the difference then?
Steven Liekens
@StevenLiekens
where the first is absolute and the latter is relative
eg. noon is the moment when most people eat lunch
Robert Logiewa
@Ruhrpottpatriot
ah
Steven Liekens
@StevenLiekens
but it is relative to where you are
but if I say I'm eating lunch this instant
then that's a DateTimeOffset
:)
that signature sounds right, or did I miss something?
Steven Liekens
@StevenLiekens
besides the name?
Robert Logiewa
@Ruhrpottpatriot
yeah
Steven Liekens
@StevenLiekens
how do you look up values by key?
Robert Logiewa
@Ruhrpottpatriot
Via the Get(Func<T,bool>) method
sec
You could write var items = cache.Get(i => i.Id == someId)
or you could run a LINQ query on the Values property, but then you'd have to filter for a possible localized item
Steven Liekens
@StevenLiekens
you have to do that anyway
the unique key for any localized item is id + lang
Robert Logiewa
@Ruhrpottpatriot
Yeah, I just saw that too. I'm trying to do it that if I use the Get method only objects for the current repository langauge are returned and Value is used to acess the complete repository
Steven Liekens
@StevenLiekens
by the way can you pull from here https://github.com/StevenLiekens/GW2.NET
it's kind of a messy situation with changes happening in both master and maintenance
Steven Liekens
@StevenLiekens
Still have to change chat codes in maintenance :( the game client uses new header bytes
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot core.autocrlf "true" converts all line endings to LF when committing
then converts them back to CRLF when checking out
is that what we want?
Robert Logiewa
@Ruhrpottpatriot
yes
that is what we want
it converts all to LF and checks out CRLF on windows
on OSX and Linux it keeps them at LF
Need yout input on something:
With the new repositories I first do a check if the items are in the cache (which does a check if they are stale), if they are i return the cached items.
However: What to do about the method that returns all items?
Possible Solutions:
  • Change the cache to include a property that stores all possible IDs indipendent from the objects stored). Then when doing the check, I do a complement operation on the IDs and request only the missing ids
  • Always do a full a request against the API bypassing the cache
Robert Logiewa
@Ruhrpottpatriot
Thoughts?
Steven Liekens
@StevenLiekens
hmm
third option
Robert Logiewa
@Ruhrpottpatriot
I'm listening
Steven Liekens
@StevenLiekens
actually nvm
first option is the way to go
Robert Logiewa
@Ruhrpottpatriot
the first would mean, that we are doing a discover if the cache is empty.
and set the stale timer for it separately
Steven Liekens
@StevenLiekens
so basically
get all IDs at most every 5 minutes (or whatever the expires header value is)
and only fetch items that are not already in the cache or stale