Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Robert Logiewa
@Ruhrpottpatriot
his reply...
Steven Liekens
@StevenLiekens
and then he locks the convo
no wonder there are 1600 forks
Robert Logiewa
@Ruhrpottpatriot
yeah
Steven Liekens
@StevenLiekens
he refuses to fix his shit
Robert Logiewa
@Ruhrpottpatriot
yep
Steven Liekens
@StevenLiekens
let's invent a new calendar with incremental dates
Robert Logiewa
@Ruhrpottpatriot
what do you mean by incremental dates?
Steven Liekens
@StevenLiekens
integers
Robert Logiewa
@Ruhrpottpatriot
elaborate a bit more
Currently the repository looks like this to the outside
oh wait there is the base class missing
Steven Liekens
@StevenLiekens
but where is the header metadata?
subcount and total count
Robert Logiewa
@Ruhrpottpatriot
wait a sec
OK, I updated the Gist
as for subtotal and total count
currently I don't support them. Adding them is easy though
I tried to reduce the options to the most essential
meaning: discover, single item, multiple items, multiple items filtered
Robert Logiewa
@Ruhrpottpatriot
In my oppinion, pagination shouldn't be done by the user, but by us. And internally my curren code tries to use it
It's just not available to the user, since there is no benefit of using it.
As a better replacement I added filtering by a Func
Steven Liekens
@StevenLiekens
or just give them the entire collection and let them filter it
Robert Logiewa
@Ruhrpottpatriot
I updated the text for #34 with more information. Discussion regarding repository layouts should go there from now on.
Robert Logiewa
@Ruhrpottpatriot
I published the changes I made. It is working, barely. There are almost no error checks and the Message handler needs some love, but this layout is where I'm aiming at.
ZedTheYeti
@ZedTheYeti
In working on implementing V2 for WvW, the V2 API exposes more (and in some cases different) information about objectives. That's all fine in good in the V2 ObjectiveNameDTO but when working with Objective and Objective name in GW2NET.Core they aren't written to handle the new/different information. I don't really want to change those as they're core classes and that'd mess with the V1 WvW implementation. Does anyone have suggestions/preferences on how to handle this?
Steven Liekens
@StevenLiekens
If the V1 result can be "molded" into a V2 format then I prefer that you change the core class for v2 and add change the v1 code to act like v2
But if not then it's probably fine if you delete the v1 code completely
Robert Logiewa
@Ruhrpottpatriot
I want to remove V1 sooner than later, at most with 3.0. For now keep them separate (i.e. create new classes instead of changing old ones).
Is there even an endpdoint which is only at V1?
Steven Liekens
@StevenLiekens
No
ZedTheYeti
@ZedTheYeti
Can do. Would you prefer same class name, different folder or same class name plus V2 i.e. ObjectiveV2.cs
Robert Logiewa
@Ruhrpottpatriot
Since Namespace changes are a breaking change and removing V1 is too, you can put them into a different folder. We'd move them around when we do housekeeping (since we can delete a lot of classes we don't need anymore when we drop V1).
Since I'm currently thinking about it... What's speaking against dropping V1 with 2.0? We should do a last sweep over the code to make sure V1 works in 1.x as it should and then release a 1.5 (if needed), which is the last version for code targeting the V1 api
Steven Liekens
@StevenLiekens
let's remove V1
it's no longer useful now that every v1 endpoint has a v2 equivalent
actually
that's problematic
okay whatever
Steven Liekens
@StevenLiekens
how about we support the latest enabled endpoint?
keep v1/guild_details until v2/guild is enabled
but go ahead and remove other v1 endpoints
Robert Logiewa
@Ruhrpottpatriot
That sounds reasonable. I'll try do make a new branch in the next days with the changes, between my exam study sessions.
Robert Logiewa
@Ruhrpottpatriot
another thing: Imo we should merge GW2NET.Newtonsoft and GW2NET.Compression into the core library. The first is now so widely accepted (and even used in official MS libraries), that we can assume that almost all people will use it.
The latter is so minimal that using a separate DLL will probably result in more overhead and less performance as if we have it in core directly.
Robert Logiewa
@Ruhrpottpatriot
So, I published the branch with the changes. I also did some additional, necessary, housekeeping. The (sole) V1.Guilds factory property was moved to the V2 factory, which was renamed to Services (and ServicesAuthorized respectively). This makes accessing the services much easier and less confusing.
The development-2.0 branch should be the branch where all changes for 2.0 go. I'll rebase my HttpClient branch and merge my changes later on.