Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Steven Liekens
@StevenLiekens
what if the Culture changes between calling the method and saving the Culture to a local variable?
:)
Robert Logiewa
@Ruhrpottpatriot
then the user will get all requests in the new culture
Steven Liekens
@StevenLiekens
the odds of that happening are probably measured in nanoseconds
Robert Logiewa
@Ruhrpottpatriot
yeah
irrelevant
Robert Logiewa
@Ruhrpottpatriot
We had retries in the ServiceClient implementation
did we set a fixed number or could the user choose?
Robert Logiewa
@Ruhrpottpatriot
Last update for today: I implemented authorisation and it works. I also implemented a basic message handler, which supports a variable number of retries
tomorrow I'll add missing authenticated endpoints
Steven Liekens
@StevenLiekens
oh sorry
yeah I hacked in retryable tasks after I noticed that some tasks were failing in GetAllPagesAsync
resulting in missing pages
IIRC you could set the max retries as a static property on Paginator
and I did it that way so that I wouldn't have to change the signature of GetAllPagesAsync
the default I believe is 3 max retries per page
which I think is enough to catch transient server errors (server "hiccups")
Robert Logiewa
@Ruhrpottpatriot
Retry in the new branch is done via a separate NuGet package. You have to do some stupid shit to get all the retry cases to work. Using another package mad this really easy.
Robert Logiewa
@Ruhrpottpatriot
Ok, I think I got a way to remove the converter interface and simplify conversion in general. I'd like your thoughts:
Data Models now implement IConvertible, which offers the virtual Func<TIn, TOut> Convert method. This method handles conversion from data model to local model. The IResponseConverter interface then just calls the method and conversion is done. If a user wants to customize the conversion he can either write a new DataModel or inherit from an existing one.
This means adding a new conversion is as easy as adding a new DataModel.
Erik Humphrey
@ErikHumphrey
i'm not very experienced in c#
if I want to display item icons from the gw2 api, what's the easiest way to go about doing that?
I really need some example code here; I can't even get the tribal bow example to show up
Robert Logiewa
@Ruhrpottpatriot
Sorry for the late reply
Can you post the code you have written already?
Erik Humphrey
@ErikHumphrey
figuratively no code
i've figured out how to get an item ID from a chat code
Erik Humphrey
@ErikHumphrey
Robert Logiewa
@Ruhrpottpatriot
I won’t give you a code example (you ahve to learn after all), but I’ll give you the way to do it
  1. Install the latest GW2.NET package from NuGet
  2. In your application create a new instance of the GW2Bootstrapper
  3. Select the appropriate factory property (FactoryForRendering) to access the service
  4. The property should return an IRenderService, which has multiple methods to retrive images from the API, based on the Renderable and the image format. The IRenderable is just an interface defining an arbitrary image file with the FileId and the File Signature. To retrive this, look up the wiki. You probably need to query another API service, but the approach is the same (just select another property)
To display images in c# you can use Google
Steven Liekens
@StevenLiekens
.NET Core RC2 will be published in a week or two and is expected to RTM by the end of june
it's a good time to switch to the new project system
Steven Liekens
@StevenLiekens
the developer experience is still a little wonky, but nuget finally has good support for netstandard1.x packages
Robert Logiewa
@Ruhrpottpatriot
I'll try to finish something I tested (didn't go well), and then try to switch in the week after pentecost.
Steven Liekens
@StevenLiekens
maybe wait for the final RC2
the nightly build still doesn't work right
Erik Humphrey
@ErikHumphrey
well i got the gw2.net from nuget part awhile back
This message was deleted
This message was deleted
but it can't find the namespace GW2Bootstrapper
so the fun stops there
Erik Humphrey
@ErikHumphrey
This message was deleted
GW2PAO doesn't even use GW2Bootstrapper
due to the lack of documentation i learn from that reverse engineering
Erik Humphrey
@ErikHumphrey
i got the icon to show up without using gw2.net
this is fine
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot I made a repo that contains samples for how to configure netstandard1.0 to netstandard1.5 libraries, netcoreapp1.0 console apps and netcoreapp1.0 xunit tests
using the lastest preview bits for .NET Core
I suspect that we will be able to use netstandard1.0 for everything except Mumble Link
Mumble Link will be the only library to not run on .NET Core