Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Steven Liekens
@StevenLiekens
for maximum compatibility
Robert Logiewa
@Ruhrpottpatriot
that'd be netcore?
Steven Liekens
@StevenLiekens
I think the lowest we can do is netstandard1.3
because HttpClient is 1.3
Robert Logiewa
@Ruhrpottpatriot
ah ok
ah
there's the explanation
Steven Liekens
@StevenLiekens
netstandard1.3.png
purple are the platforms we cannot support
Robert Logiewa
@Ruhrpottpatriot
ok
Steven Liekens
@StevenLiekens
I forgot to make Mono green
oh well
Robert Logiewa
@Ruhrpottpatriot
ok
seriously
native .NET compilation on almost every OS?
This message was deleted
AWESOME!
and it seems we can even compile it, so we don't need .NetCore installed
Steven Liekens
@StevenLiekens
yup
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot you can get 6 months of pluralsight for free with microsoft dev essentials
Steven Liekens
@StevenLiekens
@Ruhrpottpatriot it's official, RC2 is released https://www.microsoft.com/net/download#core
uninstall all dnu/dnx/dnvm crap first
Robert Logiewa
@Ruhrpottpatriot
thanks for the heads up
Darnell Williams
@Seeker1437
Hey guys I just joined this chat after discovering the GW2NET library
I have been spending the last 6 months wrapping APIs in .NET and im like loving the structure and cleaness of this library :O
@Ruhrpottpatriot you rock. I wanted to see if there was any way I could help with this project.
XD
Steven Liekens
@StevenLiekens
yes you can
there are a bunch of unsolved issues
and there is a LOT that still needs to be implemented
and somehow make sure that the stuff we implement stays up to date
because the API is constantly changing
Darnell Williams
@Seeker1437
Oh I can definately look at those
Hey I was curious
Why not keep all the DataTypes together?
Steven Liekens
@StevenLiekens
they are
and they have to be
because different APIs can link to each other
for example, recipes are linked to items (ingredients, output items) and recipe sheet consumable items are linked to recipes
if you don't put them together then you end up with circular references
Steven Liekens
@StevenLiekens
if you're wondering about the data contract classes: those classes are only used for converting between JSON and classes in the Core library
data contract objects have a very short lifespan
Darnell Williams
@Seeker1437
AH okay for me I normally just use JsonProperty and computed properties for conversions from string to Enums/DateTime and back
because if I have a class
public class Pie
{
    [JsonProperty("id)]
    public string Id {get; set;}

    [JsonProperty("info")]
    public PieInfo Info {get; set; }
}

public class PieInfo
{
    [JsonProperty("created_at")]
     private string _createdAt;

     public DateTime CreatedAt
     {
            get { return DateTimeHelper.FromIsoString(_createdAt);
            set { _createdAt = DateTimeHelper.ToIsoString(value);
     }
}
Steven Liekens
@StevenLiekens
then you're combining multiple concerns into a single class
A Pie should know how to be a pie but not how it is converted to a string representation (json)
the reason why we split them is because there might be a /v1/pie.json and a /v2/pie API that have different json schemas
Darnell Williams
@Seeker1437

Makes sense, yeah and because of that I have

*.V1.Types.Pie and *.V2.Types.Pie

I can see where that is not really desirable

Steven Liekens
@StevenLiekens
yeah so you'd have three classes