Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 24 18:06
    StevenLiekens commented #59
  • Mar 24 18:05
    StevenLiekens closed #59
  • Mar 24 18:05
    StevenLiekens commented #59
  • Mar 24 17:47
    StevenLiekens closed #58
  • Mar 24 17:47
    StevenLiekens commented #58
  • Mar 19 13:02
    Friesinator edited #59
  • Mar 19 13:01
    Friesinator opened #59
  • Mar 18 12:38
    StevenLiekens commented #58
  • Mar 15 15:19
    GHOSCHT commented #58
  • Mar 14 22:01
    Seeker1437 commented #58
  • Mar 14 20:08
    GHOSCHT commented #58
  • Mar 12 15:40
    StevenLiekens commented #58
  • Mar 10 15:46
    GHOSCHT opened #58
  • Apr 15 2018 16:43

    Ruhrpottpatriot on ServiceClient

    Remove superfluous compression … Add simple caching to Core proj… Move files into different folde… and 8 more (compare)

  • Apr 10 2018 21:09

    Ruhrpottpatriot on ServiceClient

    Add fluent api to create HttpRe… Fix Stylecop errors Remove dead code and 3 more (compare)

  • Mar 29 2018 13:11

    Ruhrpottpatriot on NetCore2.0

    Remove disabled and superseded … Delete unused leftover code fro… Move V1.Guild test to appropria… and 8 more (compare)

  • Mar 29 2018 12:17

    Ruhrpottpatriot on NetCore2.0

    Update .gitignore to exclude St… Add Api builder class (compare)

  • Feb 01 2018 09:33

    Ruhrpottpatriot on master

    Refactorize ServiceClient.GetHt… Merge pull request #57 from Kor… (compare)

  • Feb 01 2018 09:33
    Ruhrpottpatriot closed #57
  • Dec 27 2017 17:37
    Korjam opened #57
Robert Logiewa
@Ruhrpottpatriot
This message was deleted

I'm not aiming for an IQueryableimplementation, so the interface will be simple enough. As it stands, you can write Queries like this:

var builder = new QueryBuilder();
builder.AtLocation(() => this.Location).WithParameter(() => this.Parameter);

Then you'll get an expression tree which is converted into the proper request. You can also chain them as you like.

Steven Liekens
@StevenLiekens
so a fluent API
not really a DSL :)
oh
I shouldn't read from bottom to top :)
Robert Logiewa
@Ruhrpottpatriot
yeah, that can be a bit misleading :P
I need to revise the structure a bit, since at this moment we won't be needig extension methods anymore, as you just change parameters in the repository and do a query. The connector or the repository itself is going to piece the parts together.
Robert Logiewa
@Ruhrpottpatriot
You know, one should not dispose of HttpContent, when you are going to need it later...
Happened to me just now. I debugged the code and was trying to find out why the HttpContent was disposed, even though it wasn't in a using statement and I was not calling Dispose(). Turns out the cause of this was my serialisation of the Headers, which used the HttpContentin a using statement and I overlooked that method...
Silly me.
Robert Logiewa
@Ruhrpottpatriot
Ok, @StevenLiekens I need your input on this one, since you wrote it.
In the ISerializer<T> interface, the method Serialize(T value, Stream stream); returns void. It seems you did it that way, because JSON.Net does it that way. But depending on the stream we could have side effects here. Wouldn't it be better to return a completely new stream from the method instead of writing into the passed stream?
I added a comment in the interface, so we can revisit this at a later stage.
Steven Liekens
@StevenLiekens
Sorry I didn't read that until just now
Gitter is blocked at my current job 😤
I don't even know why there is a method that serializes instead of deserializes values
That doesn't sound right
Is it actually used anywhere?
RocketRacer
@RocketRacer
Well this was a long silence
I can't seem to find a Factory for Characters, so I assume I'm going to have to add one myself.
Steven Liekens
@StevenLiekens
I believe there is already a CharacterRepositoryFactory
Steven Liekens
@StevenLiekens
I'm running some tests to see how much has changed to existing APIs... it's quite a bit
will send a PR later
Robert Logiewa
@Ruhrpottpatriot
Yeah, I think we need to update quite a bit. I started a new branch with migrations to netcore2.0
We also should remove all V1 projects that are pretty much dead since the API is shut off
Steven Liekens
@StevenLiekens
agreed
Steven Liekens
@StevenLiekens
btw is creating file headers broken in stylecop for resharper?
I can only get it to generate copyright info, not class summary
Jiří Sejkora
@Sejsel
Hi, what is the current state of GW2NET.V2.Accounts.Characters? It doesn't seem to be included in any of the nuget packages.
Robert Logiewa
@Ruhrpottpatriot
@Sejsel It's not fully developed yet. I'm in the process to ditch most of the legacy code and replace it with a more robust HttpClient and TPL Dataflow pipeline. That takes a bit however, and I don't have much time right now.
Jiří Sejkora
@Sejsel
I ended up making a very simple library for myself using RestSharp for the few missing parts. If you are going to do a bigger rewrite including API changes, please try to only expose methods that can actually work, right now many methods will tell you that it is not supported for this endpoint, which makes it rather painful to use :)
Robert Logiewa
@Ruhrpottpatriot
Yes, that's the goal. Back when we released the current version most of the API had very similar methods exposed. This drastically changed when the authenticated endpoints came online. This is also a thing we need to consider while reworking the internals.