by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Bradley Miller
    @bnmnetp
    Hmm, maybe take a look at doctools.js and see if you have some kind of naming conflict, or maybe you are reusing a css class name that doctools is also using...
    Isaiah Mayerchak
    @flysaiah
    Will do.
    Bradley Miller
    @bnmnetp
    Or try using the debugger in the browser and setting a breakpoint on the code where you are setting the onclick function just to see if anything funky is happening
    Rather than button.onclick = function statement, you may want to use jquery’s click function.
    Isaiah Mayerchak
    @flysaiah
    Ok. We did try a bunch of console.log statements and it reaches the button.onclick statement fine and everything after it fine, but it never executes anything inside the function and according to the HTML editor the button doesn't even have an onclick attribute. We have tried the jquery click function and it's the same thing. We tried every type of way to set the onclick but it never worked.
    We didn't use any breakpoints though, so we'll try that next.
    Isaiah Mayerchak
    @flysaiah
    After more testing, I was wrong about doctools. The tabbedstuff.js/reveal.js files need to come before the assess.js file, so it's a dependency issue with our own files, which is troublesome. We'll work that out though. The problem with bookfuncs.js is that when our files come after it, our $(document).ready() functions aren't being called.
    Bradley Miller
    @bnmnetp
    Is something failing in one of the document.ready functions that come beforehand?
    Isaiah Mayerchak
    @flysaiah
    There are no errors in any of the document.ready functions that come up in the console; the only thing I see right off the bat is an uncaught reference error in bookfuncs.js that says that disableAcOpt() is not defined on line 162.
    Bradley Miller
    @bnmnetp
    So, that is a problem. Because whatever comes after line 162 is not going to run
    So, I see that inside a function that is getting called through the document.ready when this happens other document.ready functions that have been scheduled will not be called.
    Bradley Miller
    @bnmnetp
    I see that disableAcOpt is defined inside of activecode.js so there is a dependency that we don’t want there.
    Bradley Miller
    @bnmnetp
    Ah, actually, I was wrong again. I see you copied over activecode.js from my newac repository. And that function is not in activecode.js in that version, but it should be. There may be a few things missing from that version of activecode.js
    Bradley Miller
    @bnmnetp
    wanted to look at the tabbed stuff tests. But the testts.html that I have on the JsComponents branch does not match what you had this morning. Can you push the latest to that branch for me?
    Bradley Miller
    @bnmnetp
    Hey guys, I’m confused. I’m trying to use the riknos314/RunestoneComponents library to take a look at a couple of these problems. I thought I should probably use the jsComponents branch, but its weird because js folders are missing and init.py files are missing from activecode and codelens, which means the package doesn’t build correctly. Is there a different branch I should be using? Maybe there is a branch that one of you should push to the repo so I can see it.
    Bradley Miller
    @bnmnetp
    There is a new version of bookfuncs.js in my repo that uses login/logout events to provide better separation for functions that should be called when a user logs in or is logged out.
    instead of having a dependency between bookfuncs and some other function in another file individual modules should now use $(document).bind(“runestone:login”, myfunc) to schedule their own function to be called after login is confirmed. similarly for the event “runestone:logout"
    Isaiah Mayerchak
    @flysaiah
    Sorry, the notifications were somehow disabled for gitter for Kirby and I so we didn't see these messages until now. We're fixing the missing init.py files and js folders and should have them pushed momentarily, although our activecode.py is mostly untested so far.
    Isaiah Mayerchak
    @flysaiah
    Also, I just finished a working version 1 of the dragndrop component, if you would like to look at it and tell me what you think.
    Isaiah Mayerchak
    @flysaiah
    The file structures for activecode and codelens should be good now (we just reverted back to the old codelens for now because we haven't done any substantial work on that component).
    Isaiah Mayerchak
    @flysaiah
    We also just fixed the dependency issues for activecode--the Sphinx side works now (there were a few needed JS files missing for codemirror etc)
    Isaiah Mayerchak
    @flysaiah
    Also--I just realized that in order to make the testts.html work, you need to do a bower install of jquery and jquery-ui in the assess folder of runestone. This is where the testts.html is looking for jquery. Other than that, testts.html should work fine when you pull it from jsComponents.
    Isaiah Mayerchak
    @flysaiah
    We figured out what the problem is with reveal and tabbed stuff--before we were just copying the HTML of the nested components instead of appending them as child nodes. We fixed the logic in tabbedStuff and that works independent of order now and is pull request ready--reveal is almost ready too, there's just a problem with doing the appendChild method with its modal functionality, as the modal function takes a string and not child nodes, but we're working on it.
    Isaiah Mayerchak
    @flysaiah
    We just got it working--we'll have pull requests on both reveal and tabbedStuff shortly.
    Bradley Miller
    @bnmnetp
    I see the answer to my question on the issue was here. Thanks.
    I think I have a fully complete activecode.js now. I had to add in support for code coach, audiotours, and show in codelens. Have you guys done any work on the sphinx side?
    Isaiah Mayerchak
    @flysaiah
    Yes we have. We've done a few tests and it should work--let us know if something breaks after your new code and we'll look at it. We also just fixed the bug in reveal, so we're going to run just a few more tests then make a pull request on reveal/tabbedStuff.
    Bradley Miller
    @bnmnetp
    excellent
    Isaiah Mayerchak
    @flysaiah
    I added the changes you wanted to dragndrop. Let me know if you'd like anything more--if not, we'll make a pull request for that too.
    Bradley Miller
    @bnmnetp
    Go ahead and do a PR for dragndrop
    Kirby Olson
    @riknos314
    Could you clarify what exactly RunestoneBase is supposed to do? The only reason that it has been creeping into our code is because you had it at the beginning of your activecode example when we were trying to figure out how that worked. I just greped through all the code in our components branch, and the only mention of RunestoneBase is where we've put it there in our new code. So what is the purpose of RunestoneBase?
    Bradley Miller
    @bnmnetp

    after accepting the PR’s and init’ing a new project I still get:

    /Users/bmiller/src/Runestone/RunestoneComponents/test/_sources/overview.rst:473: ERROR: Unknown interpreted text role "textfield".

    on build.

    I’m guessing the fitb example in overview.rst needs to be updated?
    Isaiah Mayerchak
    @flysaiah
    The fitb directive is correct under the timed exam section, but the regular one is indeed incorrect. I'm not sure how we missed that one, but we'll update that when we do our pull request of Dragndrop.
    Bradley Miller
    @bnmnetp
    Could you do an update to the overview.rst doc and add an example for both the clickablearea and dragndrop components?
    Isaiah Mayerchak
    @flysaiah
    Yes.
    Isaiah Mayerchak
    @flysaiah
    After looking at overview.rst again, I found that the fitb example actually isn't incorrect--the error that you're getting on build is because there used to be a "textfield" role that was defined in textfield.py that we assumed was only used for fill in the blank questions--do we need to re-add this role or is it irrelevant now that we use the new fitb directive? We're updating overview now to include dragndrop and clickablearea.
    There is a "textfield" role being defined in overview.rst for an activecode demonstration--that's where the error is showing up.
    Bradley Miller
    @bnmnetp
    Aha, yes. So the textfield role should be put back into the python code for use with rst and Sphinx but there is no reason to worry about it from an RSE-0001 perspective.
    Isaiah Mayerchak
    @flysaiah
    Got it--we'll have a pull request ready with an updated overview.rst in a few minutes--we just have one small bug to iron out first.
    Isaiah Mayerchak
    @flysaiah
    The pull request has been made.
    Bradley Miller
    @bnmnetp
    @flysaiah on the drag and drop, the thing that I try to drag does not move when I drag. It drops when I let go of the mouse but that is not very intuitive. It used to drag...
    Bradley Miller
    @bnmnetp
    To clarify… the non-dragging behavior happens in Safari 9.0 but works fine in Chrome and Firefox… 9.0 is beta so if you could test it in your safari just to see...
    Question @flysaiah @riknos314 do the new dragndrop and clickablearea question types work inside the Timed Exam?
    If not, they should...
    Isaiah Mayerchak
    @flysaiah
    We'll look at the behavior in Safari, and getting both question types to work in Timed--currently it supports only MC and FITB.
    Isaiah Mayerchak
    @flysaiah
    Timed now supports the new components--however, in order to let it support them we either need to have timed.js loaded after all of its supported components' JS files, or we need a separate JS file that has the document.ready functions that will just be loaded after everything. We were leaning towards the second option, but we were wondering where we should put this separate auxiliary file, because it isn't really a part of any component and it depends on the other components, so common isn't really an intuitive place.
    Isaiah Mayerchak
    @flysaiah
    To clarify: timed.js needs to have all of the document.ready functions for all of its possible nested components inside timed.js, as well as having all of its possible nested components' respective JS files loaded before it, OR we need a separate JS file that just has the document.ready functions loaded after everything.
    Isaiah Mayerchak
    @flysaiah
    Also, we have confirmed that the dragged item is not being shown in Safari 8.0 as well. We're not sure why yet because Safari states that it supports HTML5 drag and drop functionality.
    Bradley Miller
    @bnmnetp
    Just as a thought, could the document.ready functions be triggered from a custom event that is created in timed.js ? Similar to what I did with the login/logout events? Is timed.js always loaded ? Or is it only loaded when the timed component is used?