These are chat archives for SHTOOLS/SHTOOLS

19th
Nov 2016
Mark Wieczorek
@MarkWieczorek
Nov 19 2016 09:26
@ioshchepkov I added a few comments to your PR. It looks good to me. The only important points for me are: 1. I think that we need to describe what the column numbers in usecols corresponds to. 2. I wonder if the "common" routine should be in utils, or if the single routine in utils should be moved up one level. 3. Perhaps it is too complicated to do, but I wonder if it is possible to read the coefficients and errors in a single call.
Ilya Oshchepkov
@ioshchepkov
Nov 19 2016 09:45
I agree about column names. I think I will remove use_cols completely and add errors options which can be either 'calibrated' or 'formal' or None
I thought all the common routines for IO operations can be placed in common.py inside shio, and utils is for all auxiliary routines. Now it indeed has only one submodule, but it can be changed in the future.
Ilya Oshchepkov
@ioshchepkov
Nov 19 2016 09:57
Of course, it is possible to read the coeffs and errors in one call and I see it may be more useful than two calls, I'll try to do it next week
Mark Wieczorek
@MarkWieczorek
Nov 19 2016 12:40
Should utils be a subpackage of shio, or just a subpackage of pyshtools? At some point we need to rename or remove the submodule/package "other" (there are only a couple routines now, and the name is stupid..), so we could perhaps move everythin to pyshtools.utils ?
Ilya Oshchepkov
@ioshchepkov
Nov 19 2016 12:53
Yes, that is exactly what I meant! :smile: pyshtools.utils for all common auxiliary functions, modules, etc.
Mark Wieczorek
@MarkWieczorek
Nov 19 2016 13:14
if you want to rename pyshtools.other to pyshtools.utils in this PR, do ahead and do it.