Specifically I need to set
padding
I chose to base the current design on mutable builders as a compromise, it's somewhat documented in the release notes here https://github.com/ScalablyTyped/Converter/releases/tag/v1.0.0-beta13
I just released 1.0.0-beta18 where
stExperimentalEnableImplicitOps is now the default encoding for creating objects. This means there will be some migration work to update, see changelog for beta13 https://github.com/ScalablyTyped/Converter/releases/tag/v1.0.0-beta13
@oyvindberg Ah great I'll upgrade - I enabled that setting and I've now got the expected setters and updated my code. It works well, except that there are some odd things like
KinkeyofCSSPropertiesstri which is Inlined {[ K in keyof react.react.CSSProperties ]: string | number | (tick? : any): string | number} but has only a huge apply without defaults so I can't use the same approach as CSSProperties. At the moment I'm building a CSSProperties and casting to KinkeyofCSSPropertiesstri, which works since I only need simple values rather than functions.
VictoryStyleObject is very similar
This is with:
"victory" -> "33.1.4",
"@types/victory" -> "33.1.4"
Aha @trepidacious . That type is computed in such a way that all its members end up being required, and required parameters still need to be provided to an
apply method before the Builder takes over to supply the optional parameters. I suppose this is a bug, will look into it
@an-tex true, I havent ported generation of scalajs-react components yet
I'm pretty sure there is some design work to be done there first
and that's great to hear, it was definitely my experience that it helped a lot as well
They don't even seem to run react-docgen, so I can't fall back to generating code from that
Check out the nivo demo I added to the slinky demos yesterday, that library looks really really good
I basically need "scientific" graphs, so a lot of the graphing libraries are coming at things from a different angle
Hi, I just ran into an issue with setter/getters that maybe someone else has seen.
The following typescript code:
public get minEmitBox(): Vector3 {
if ((<BoxParticleEmitter>this.particleEmitterType).minEmitBox) {
return (<BoxParticleEmitter>this.particleEmitterType).minEmitBox;
}
return Vector3.Zero();
}
public set minEmitBox(value: Vector3) {
if ((<BoxParticleEmitter>this.particleEmitterType).minEmitBox) {
(<BoxParticleEmitter>this.particleEmitterType).minEmitBox = value;
}
}gets converted into
def minEmitBox: Vector3 = js.native
def minEmitBox(value: Vector3): js.Any = js.nativeShould not the signature of a setter be def minEmitBox_=(value: Vector3): Unit ?
When calling the setter method, I get particleSystem.minEmitBox is not a function..
@an-tex there is actually, I need someone to sketch a design for a scalajs-react builder, much like https://github.com/ScalablyTyped/SlinkyTyped/blob/master/r/react/src/main/scala/typingsSlinky/StBuildingComponent.scala . I'll create an issue to track it soon
@trepidacious I'm not so familiar with graphing libraries, but there are many, I would be quite surprised if there wasn't a good library with types. Did you get anywhere with hacking on it?
@olofwalker that's a bug I'm sure. When I worked on it all setters and getters were gone from the generated .d.ts files after typescript compilation. I guess that has changed lately
@oyvindberg cool, Also noted that beta18 generates
no arguments allowed for nullary method for apply methods that have default values for all parameters when you try to create an object and supply a named value, ex. val r = typings.babylonjs.anon.RadiusX(subdivisions = 10) , beta17 does not, not sure why.
@oyvindberg Is that a bug with the plugin or somewhere else? if it is for the plugin, I can create an issue to track it...
@oyvindberg so far it’s been nice to work with, and the code seems well organised.
How would you use this library with scalajs-react? https://joshwcomeau.com/react/announcing-use-sound-react-hook/
Mhh.. ReactSound is forcing a render of things I don't want rendered as it changes... (siblings) these re-renders cause traffic between client and server which I don't want. So I tried using the use-sound react hook this way:
def playSound(soundUrlOpt: Option[String]): Callback = {
soundUrlOpt.fold(Callback.empty) { url =>
Callback { typings.useSound.mod.default(url) }
}
}But I get a react error:Uncaught Error: Invalid hook call. Hooks can only be called inside of the body of a function component.
If I can figure it out (which I don't know exactly what you mean by either conditionally, or functional component), I'm gathering that I'll end up in the same problem that I have with the re-render. Let me move the question to the scalajs-react channel, since it's really not directly related to ScalablyTyped.