In scalajs-react 1.x, Callback was in the main package react, not it's in react.callback.Callback. Not 100% sure how this works, but if you just use the "core" module, Callback is in the historic location. But if you use callback/core-bundle-cats_effect, it's in the new callback package. Is there a way to make the compiler see react.callback.Callback as react.Callback?
Think of it like a maven repo with transient libraries, where if they are not found the plugin will automatically rebuild them locally.
I guess if you're iterating and adding libraries it helps. My current approach is I have a separate project that contains all the sjs library facades that I plan to use in my downstream project. Since that doesn't change much, I'll just modify/recompile/republish any time I need to add/change libraries.
The advantage is that it is less work, than publishing a library, especially if you're not sitting with an internal repo already.
I'd prefer to your approach any day in an organization, but you're doing open source work or a hobby project remote cache is handy.
you can consume scala3 artifacts in scala 2.13 (see https://docs.scala-lang.org/scala3/guides/migration/compatibility-classpath.html)
Hi @oyvindberg, with the last beta, I am getting some errors. Any clue?
scalaVersion := "2.13.8"
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.10.0")
addSbtPlugin("org.scalablytyped.converter" % "sbt-converter" % "1.0.0-beta37")
polymorphic expression cannot be instantiated to expected type;
[error] found : [T]typings.reactstrap.components.SharedBuilder_UncontrolledDropdownProps1835145360[typings.reactstrap.mod.UncontrolledDropdown[T],T]
[error] required: japgolly.scalajs.react.vdom.html_<^.TagMod
[error] (which expands to) japgolly.scalajs.react.vdom.TagMod
[error] UncontrolledDropdown()(
type mismatch;
[error] found : String
[error] required: ? | scala.scalajs.js.Array[?]
[error] Route(RouteProps().setExact(true).setPath(s"${routeMatch.path}/register")).withKey("register")(RegisterPage.component()),/* The props of this component has an unsupported shape. You can use `set` manually to use it, but with no compiler support :/ . Couldn't find props for (typings.reactRouter.mod.RouteProps[Path, typings.reactRouter.mod.ExtractRouteParams[Path, java.lang.String]]) & (typings.reactRouter.mod.OmitNative[
T,
/ * keyof react-router.react-router.RouteProps<string, react-router.react-router.ExtractRouteParams<string, string>> * / typings.reactRouter.reactRouterStrings.location_ | typings.reactRouter.reactRouterStrings.component | typings.reactRouter.reactRouterStrings.render | typings.reactRouter.reactRouterStrings.children | typings.reactRouter.reactRouterStrings.path | typings.reactRouter.reactRouterStrings.exact | typings.reactRouter.reactRouterStrings.sensitive | typings.reactRouter.reactRouterStrings.strict]) because: IArray(Could't extract props from T because couldn't resolve ClassTree.) */
object Route {
def apply[T /* <: js.Object */, Path /* <: String */](
p: (RouteProps[Path, ExtractRouteParams[Path, String]]) with (OmitNative[
T,
/* keyof react-router.react-router.RouteProps<string, react-router.react-router.ExtractRouteParams<string, string>> */ location_ | typings.reactRouter.reactRouterStrings.component | render | children | path | exact | sensitive | strict
])
): Builder[T, Path] = new Builder[T, Path](js.Array(this.component, p.asInstanceOf[js.Any]))
@JSImport("react-router-dom", "Route")
@js.native
val component: js.Object = js.native
@scala.inline
class Builder[T /* <: js.Object */, Path /* <: String */] (val args: js.Array[Any])
extends AnyVal
with StBuildingComponent[typings.reactRouterDom.mod.Route[T, Path]]
implicit def make[T /* <: js.Object */, Path /* <: String */](companion: Route.type): Builder[T, Path] = new Builder[T, Path](js.Array(this.component, js.Dictionary.empty))()
}
nice, one of them has been solved, but I keep getting this error for the Route component... 😕
type mismatch;
[error] found : String
[error] required: ? | scala.scalajs.js.Array[?]
[error] Route(RouteProps().setExact(true).setPath(s"${routeMatch.path}/register")).withKey("register")(RegisterPage.component()),
but with the same versions, but different flavor
Flavour.Slinky the converter generate a different facade
/* The props of this component has an unsupported shape. You can use `set` manually to use it, but with no compiler support :/ . Could't extract props from T because couldn't resolve ClassTree. */
object Route {
def apply[T /* <: RouteProps */](p: T): Builder[T] = new Builder[T](js.Array(this.component, p.asInstanceOf[js.Any]))
@JSImport("react-router-dom", "Route")
@js.native
val component: js.Object = js.native
@scala.inline
class Builder[T /* <: RouteProps */] (val args: js.Array[Any])
extends AnyVal
with StBuildingComponent[tag.type, typings.reactRouterDom.mod.Route[T]]
implicit def make[T /* <: RouteProps */](companion: Route.type): Builder[T] = new Builder[T](js.Array(this.component, js.Dictionary.empty))()
}Hi @oyvindberg, I found the problem, yarn add @types/react-router-dom@5.1.2 transiently installs the @types/react-router@5.1.18 version, which generates a weird facade, it was necessary to explicitly set the version of @types/react-router to 5.1.2.
Another thing is that the stIgnore option apparently doesn't ignore if the version is added, right? because I was trying to exclude the wrong version and apparently it didn't work.
stIgnore ++= List("@types/react-router@5.1.18")
and I've seen that react-router problem. a lot of libraries like it have started to employ very advanced type-level patterns for things like this, it really should be simplified somehow during translation
just imagine, iirc it parses the route string (compile-time), extracts parameters names, and returns an object type you can dig into in code with those names set
Hey! I'm looking at https://scalablytyped.org/docs/plugin-no-bundler#implement-externalnpm , and I have a question about it.
If I use it as is (but with
npm install), the command runs on every compile, which takes quite some time, and outputs quite a bit of useless logs every time.
Instead, I opted to just have
externalNpm := baseDirectory.value.
And I run
npm install once before running sbt.
Is this bad?
@oyvindberg: Howdy! before I pop this on the issue (this one? ScalablyTyped/Converter#125), can you confirm that this code:
export type PascalCasedProperties<Value> = Value extends Function
? Value
: Value extends Array<infer U>
? Value
: {[K in keyof Value as PascalCase<K>]: Value[K]};which fails to parse with ScalablyTyped (Right(Parse error at 51.22 '']'' expected but 'as' found)) is broken for the same reason as the issue I linked?
Hey, I'm trying to convert a lib that I want to run using node and not the browser. This lib declares a browserify dependency: https://www.npmjs.com/package/buffer. I want the conversion to exclude this browserify dependency and use node buffer types instead, is that possible ?
Thank you for your help
I'm having a go with the mill scalably typed plugin, and getting this;
[error] 2022-05-19T18:54:30.269491Z Phase3Compile.scala:147 err Compiling std (1807 Scala sources)
Compiled std (2999ms)
[E] Unexpected error when compiling std: 'class dotty.tools.dotc.core.Symbols$NoSymbol$ cannot be cast to class dotty.tools.dotc.core.Symbols$ClassSymbol (dotty.tools.dotc.core.Symbols$NoSymbol$ and dotty.tools.dotc.core.Symbols$ClassSymbol are in unnamed module of loader java.net.URLClassLoader @4451e4fe)'
[E] Failed to compile 'std'
[id => std, thread => 250, phase => build, flavour => NormalFlavour]
[warn ] 2022-05-19T18:54:30.275106Z ScalablyTypedWorkerImpl.scala:269 td 15656
Failure: You might try to set:
def scalablyTypedIgnoredLibs = Seq("std")
std: Compilation failed: Compiled std (2999ms) (/Users/simon/Code/mill-full-stack/mill-full-stack/node_modules/typescript/lib)
1 targets failed
stModule.scalablyTypedImportTask java.lang.Exception
com.github.lolgab.mill.scalablytyped.worker.ScalablyTypedWorkerImpl.scalablytypedImport(ScalablyTypedWorkerImpl.scala:296)
com.github.lolgab.mill.scalablytyped.ScalablyTyped.$anonfun$scalablyTypedImportTask$2(ScalablyTyped.scala:56)
mill.define.Task$TraverseCtx.evaluate(Task.scala:380)
I'm not familiar enough with any of the projects, to have a real hint on what this is telling me. Is this likely to be misconfiguration? I'm was trying with scala 3.1.2 adn scalajs 3.10.0?
@redarqas_gitlab It's a bit complicated. You're importing a library (std) which contains that type, so it's translated. However, ~all references to that type will be rewritten to
scala.scalajs.js.typedarray.Uint8Array, given that https://scalablytyped.org/docs/conversion-options#stusescalajsdom is set to true (it is by default). The few cases where you'll see usage of the other types would be in inheritance clauses, as that is a much more complicated rewrite
Also note that you can safely cast between these types. It's ok to be a bit more liberal with casts when interfacing with javascript
@velvetbaldmime:matrix.org sorry about late answer. it's not the same issue, even though both issues involve the word
as :)
The thing you came across is (relatively) recent addition to typescript, where it renames members in an object type with a mapped type, typically it's used together with template strings. This is rather type austronauty and I haven't gotten around to implementing it yet. An easyish thing to do would be to extend the parser to recognize that
as token, and then ignore it with a warning