Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jun 01 21:50

    oyvindberg on v1.0.0-beta33

    (compare)

  • Jun 01 21:49

    oyvindberg on gh-pages

    Deploy website Deploy website … (compare)

  • Jun 01 21:07

    oyvindberg on support-abstract-new-syntax

    (compare)

  • Jun 01 21:06

    oyvindberg on master

    Support `abstract new` syntax (… (compare)

  • Jun 01 20:59

    oyvindberg on support-abstract-new-syntax

    Support `abstract new` syntax (compare)

  • Jun 01 20:45

    oyvindberg on dotty-support

    better erasure for this.type fixup `val a: Null = js.native` seems… and 2 more (compare)

  • May 29 07:56

    oyvindberg on dotty-support

    fork tests (compare)

  • May 29 07:00

    oyvindberg on dotty-support

    workaround for https://github.c… (compare)

  • May 29 06:51

    oyvindberg on dotty-support

    build snapshots (compare)

  • May 25 08:16

    oyvindberg on dotty-support

    scalafmt (compare)

  • May 25 08:08

    oyvindberg on dotty-support

    bump runtime (compare)

  • May 24 23:38

    oyvindberg on master

    Update sbt-mdoc to 2.2.21 (#306… (compare)

  • May 24 23:38

    oyvindberg on master

    Update scalatest to 3.2.9 (#307… (compare)

  • May 24 23:38

    oyvindberg on master

    Update os-lib to 0.7.7 (#308) … (compare)

  • May 24 23:32

    oyvindberg on master

    Minimization: Include what `Sho… (compare)

  • May 24 23:32

    oyvindberg on minimization-bugfix

    (compare)

  • May 24 23:07

    oyvindberg on poc-laminar

    scalafmt (compare)

  • May 24 22:52

    oyvindberg on poc-laminar

    laminar poc (compare)

  • May 24 21:02

    oyvindberg on minimization-bugfix

    Minimization: Include what `Sho… (compare)

  • May 24 21:01

    oyvindberg on master

    Update sourcecode to 0.2.7 (#30… (compare)

Øyvind Raddum Berg
@oyvindberg
@peterstorm why do you want to construct the icon so manually? in the two examples I gave you you get ready to use react components so you don't even have to say svg yourself
For things which can be T | Null you have to cast, at least until scala 3. I typically write some helper methods for it, but there is nothing in scala, scala.js or ST to make that smooth to work with for now.
btw if you're having problems with slinkys dom dsl (:= and friends) I can recommend to have a look inside typings.react.components, you will find all of a, button and so on using the same builder pattern as the ST components
Peter Storm
@peterstorm
@oyvindberg I honestly just knicked that piece of code from somewhere else, and I reckon it's because the bars are animating then? I 'm not really versed in stuff like that
Peter Storm
@peterstorm
I'm just gonna used the MatrialUI icons, I don't know why I didn't think about that, thank you again
Pascal Mengelt
@pme123

did you figure it out @pme123 ? seems like its coming from somewhere inside webpack?

Ok finally I found the time - started from scratch and it worked - I created a simple example project with all the nice stuff from the Slinky starter project and a working Scalably Plotly example: https://github.com/pme123/scalably-slinky-example

Øyvind Raddum Berg
@oyvindberg
cool @pme123 . in the meantime I also added this little demo https://github.com/ScalablyTyped/SlinkyDemos/blob/master/plotly/src/main/scala/demo/Main.scala
Peter Storm
@peterstorm
Is there a way I can force recompilation of certain npm dependencies? I'm trying to use recharts, but even though my code compiles I get errors like this:
Uncaught TypeError: Cannot read property 'ResponsiveContainer' of undefined
    at $c_Ltypings_recharts_components_ResponsiveContainer$.make__Ltypings_recharts_components_ResponsiveContainer$__sjs_js_Array (ResponsiveContainer.scala:40)
    at eval (OrderChart.scala:33)
    at $c_sjsr_AnonFunction1.apply__O__O (AnonFunctions.scala:27)
    at $c_Lslinky_core_FunctionalComponent$.slinky$core$FunctionalComponent$$$anonfun$apply$1__sjs_js_Object__F1__sr_ObjectRef__Lslinky_core_facade_ReactElement (FunctionalComponent.scala:108)
    at OrderChart (FunctionalComponent.scala:106)
    at renderWithHooks (react-dom.development.js:14803)
    at mountIndeterminateComponent (react-dom.development.js:17482)
    at beginWork (react-dom.development.js:18596)
    at HTMLUnknownElement.callCallback (react-dom.development.js:188)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:237)
I just took the SimpleLineChart from the MaterialUI example. And I got it to work on its own, afaik
Peter Storm
@peterstorm
And I just tried to build my project on my linux machine, and it complains that a certain type isn't part of the materialUICore package... but it works on my Windows Machine :D typings.materialUiCore.anon.PartialClassNameMapExpansDisabled works fine on windows, but not my linux machine :(
Øyvind Raddum Berg
@oyvindberg
that's weird. have you tried clean and all of that?
Peter Storm
@peterstorm
To which one of the errors? :D
Øyvind Raddum Berg
@oyvindberg
The latter
For the former you may want to turn off stReactEnableTreeShaking if you have that enabled for recharts
Peter Storm
@peterstorm
I dont have that enabled :(
Should I link my build file?
Peter Storm
@peterstorm
How I tried starting a whole new slinky project, and just importing the depencies for the MaterialUI project, and I have the same error... so weir :(
The recharts error :(
Peter Storm
@peterstorm
I guess I'll try to turn it on actually
Peter Storm
@peterstorm
That didnt work either :( Any other suggestions?
Øyvind Raddum Berg
@oyvindberg
@peterstorm I had a quick look on a computer now.
for recharts, first check that the slinky demo repo works for you. ResponsiveContainerworks there, so there is no particularly good reason why it shouldnt work in another project.
for the linux build issue if it doesnt go away with clean, sbt restart and so on I'll need more info. run show stConversionOptions in sbt, and also give me the full error message please
Peter Storm
@peterstorm
Ill try and clone the repo, thanks :)
Peter Storm
@peterstorm
I actually tried to just replace the type with a type without the Disabled at the end, even though the method said it needed that other type, and it worked! Weirdly 😅
But ill report back on the recharts stuff
5e weird thing is that it has worked before
Alexis Hernandez
@AlexITC
what's the recharts issue? I have one example working that I could share if you still need it
I do really wonder if the material-ui demo chart could be enough, I have been willing to try it for a while
Peter Storm
@peterstorm
Oh they have charts too?
I get the error from a little above, but basically undefined, when I try to render the SimpleLineChart from the materialUI demo project as standalone component. I got the Dashboard bit with the charts rendering last night fine, so I have no idea what’s happening.
Peter Storm
@peterstorm
Yeah, slinky material ui demo works fine, so weird. Is there some weird dependency in the Dashboard component maybe?
Peter Storm
@peterstorm
Nope, just put it somewhere else in the demo, and still worked fine.
Alexis Hernandez
@AlexITC
Peter Storm
@peterstorm
Yeah, that worked fine when i cloned and compiled that
Alexis Hernandez
@AlexITC
@oyvindberg apparently, reloading on a page other than the home doesn't work, was the fix that I pushed deployed? or it be that there is another change needed for the github pages side?
Peter Storm
@peterstorm
trying again, just deleted the dashboard folder I had, did a sbt clean, and gonna start over and see if taht was something weird
Alexis Hernandez
@AlexITC
Overall, such chart seems simpler that recharts, if that works for you, I'd stick to it

@oyvindberg apparently, reloading on a page other than the home doesn't work, was the fix that I pushed deployed? or it be that there is another change needed for the github pages side?

About this, I remember now, the webserver needs to be configured to serve the index when the file is not found, which I have no idea if can be done on gh pages with your current settings

from this issue, people claim that you can create a symlink from the 404.html page to your index, but that wouldn't work for many entrypoints which is how the demos work: isaacs/github#408
Peter Storm
@peterstorm
Yeah, still breaks in my project... so weird...
Alexis Hernandez
@AlexITC
I used to have breaking issues while integrating material-ui, most of those where related to wrong configuration, on sbt/webpack, what ended up working was to take the whole sbt/webpack config from material-ui demo, and bring my changes to that
Peter Storm
@peterstorm
I've basically been doing that :(
But yeah, it must be a config issue
Because it works fine when I run the demo repo
Peter Storm
@peterstorm
IT WORKS!
I deleted every single folder that didnt have anything to do with my code
did sbt clean
And then tried to do it all over again :D
Alexis Hernandez
@AlexITC
great!