ScalablyTyped/community

https://scalablytyped.org/docs/plugin

Øyvind Raddum Berg

@oyvindberg

For the former you may want to turn off stReactEnableTreeShaking if you have that enabled for recharts

Peter Storm

@peterstorm

I dont have that enabled :(

Should I link my build file?

Peter Storm

@peterstorm

How I tried starting a whole new slinky project, and just importing the depencies for the MaterialUI project, and I have the same error... so weir :(

The recharts error :(

Peter Storm

@peterstorm

I guess I'll try to turn it on actually

Peter Storm

@peterstorm

That didnt work either :( Any other suggestions?

Øyvind Raddum Berg

@oyvindberg

@peterstorm I had a quick look on a computer now.

for recharts, first check that the slinky demo repo works for you. ResponsiveContainerworks there, so there is no particularly good reason why it shouldnt work in another project.

for the linux build issue if it doesnt go away with clean, sbt restart and so on I'll need more info. run show stConversionOptions in sbt, and also give me the full error message please

Peter Storm

@peterstorm

Ill try and clone the repo, thanks :)

Peter Storm

@peterstorm

I actually tried to just replace the type with a type without the Disabled at the end, even though the method said it needed that other type, and it worked! Weirdly 😅

But ill report back on the recharts stuff

5e weird thing is that it has worked before

Alexis Hernandez

@AlexITC

what's the recharts issue? I have one example working that I could share if you still need it

I do really wonder if the material-ui demo chart could be enough, I have been willing to try it for a while

Peter Storm

@peterstorm

Oh they have charts too?

I get the error from a little above, but basically undefined, when I try to render the SimpleLineChart from the materialUI demo project as standalone component. I got the Dashboard bit with the charts rendering last night fine, so I have no idea what’s happening.

Peter Storm

@peterstorm

Yeah, slinky material ui demo works fine, so weird. Is there some weird dependency in the Dashboard component maybe?

Peter Storm

@peterstorm

Nope, just put it somewhere else in the demo, and still worked fine.

Alexis Hernandez

@AlexITC

Yes, see the dashboard from https://scalablytyped.github.io/SlinkyDemos/material-ui/

Peter Storm

@peterstorm

Yeah, that worked fine when i cloned and compiled that

Alexis Hernandez

@AlexITC

@oyvindberg apparently, reloading on a page other than the home doesn't work, was the fix that I pushed deployed? or it be that there is another change needed for the github pages side?

Peter Storm

@peterstorm

trying again, just deleted the dashboard folder I had, did a sbt clean, and gonna start over and see if taht was something weird

Alexis Hernandez

@AlexITC

Overall, such chart seems simpler that recharts, if that works for you, I'd stick to it

@oyvindberg apparently, reloading on a page other than the home doesn't work, was the fix that I pushed deployed? or it be that there is another change needed for the github pages side?

About this, I remember now, the webserver needs to be configured to serve the index when the file is not found, which I have no idea if can be done on gh pages with your current settings

from this issue, people claim that you can create a symlink from the 404.html page to your index, but that wouldn't work for many entrypoints which is how the demos work: isaacs/github#408

Peter Storm

@peterstorm

Yeah, still breaks in my project... so weird...

Alexis Hernandez

@AlexITC

I used to have breaking issues while integrating material-ui, most of those where related to wrong configuration, on sbt/webpack, what ended up working was to take the whole sbt/webpack config from material-ui demo, and bring my changes to that

Peter Storm

@peterstorm

I've basically been doing that :(

But yeah, it must be a config issue

Because it works fine when I run the demo repo

Peter Storm

@peterstorm

IT WORKS!

I deleted every single folder that didnt have anything to do with my code

did sbt clean

And then tried to do it all over again :D

Alexis Hernandez

@AlexITC

great!

Øyvind Raddum Berg

@oyvindberg

@AlexITC I'm struggling with the CI for the demo repo, the builder container doesn't have enough memory to build mui. What it means is that CI will be green if I run stPublishCache from my computer, but it's not able to publish itself. If you want to update the published demo you need to run dist in sbt and check in the results, which will be on the docs folder

nice @peterstorm :)

also @AlexITC an easy fix for missing history api on github pages would be to use hash routing instead.

Alexis Hernandez

@AlexITC

The CI is an issue I face in my repos as well, the hash routing is a nice idea

Øyvind Raddum Berg

@oyvindberg

I'm thinking to just publish mui core and icons to maven central

as long as its 3.9.3 it's not changing much anyway

and deal properly with it later

it's just a small handful of libraries which end up being so incredibly much source code anyway

I ran dist now and pushed it by the way

Alexis Hernandez

@AlexITC

that sounds reasonable to me, it will definitely help in some of our internal projects because the compile time will be reduced considerably

Øyvind Raddum Berg

@oyvindberg

But @AlexITC if you setup remote cache on s3, ci will be instant

Alexis Hernandez

@AlexITC

Agree, and I plan to do that, but the package maven library can certainly help to new devs because it is less configuration

Øyvind Raddum Berg

@oyvindberg

[warn ] 2020-11-16T00:52:31.544315Z Phase3Compile.scala:144  Built /home/olvind/.ivy2/local/org.scalablytyped.slinky/react_sjs1_3.0.0-M1/16.9-dt-20200711Z-805e37/jars/react_sjs1_3.0.0-M1.jar in 48664 ms [id => react, thread => 1, phase => build, flavour => SlinkyFlavour]

Where communities thrive

People

Repo info

Activity