These are chat archives for Semantic-Org/Semantic-UI-Angular

22nd
Apr 2016
Artus Kolanowski
@witrin
Apr 22 2016 01:34
@edcarroll I'm glad to hear that! Thanks for your work and making this happen! When this is becoming the official integration in a long term, I'm also absolutely willing to contribute...
Jack Lukic
@jlukic
Apr 22 2016 08:32
Let me know how i can help @edcarroll
<3
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 08:54
@jlukic We would like to hear you opinion in this situation. Should we build Angular 2 library ( components ) with or without jQuery dependency.
Jack Lukic
@jlukic
Apr 22 2016 08:55
I'm not sure how you'll integrate updates to SUI with a forked JS codebase
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 08:55
Advantage of using jQuery is that we are close to native SUI api, but it add jQuery as dependency on project ( which lot of people don't like these days )
@jlukic yes, that is disadvantage of going without jQuery
Jack Lukic
@jlukic
Apr 22 2016 08:56
i think its a maintainability question. If you're able to invest the time to support and update the forked codebase then I wouldnt hesitate to go for it
I think the most important thing is making a library that stays maintained with current standard SUI
otherwise from my experience it falls out of use
I do think the angular community has different needs though, so its a difficult choice
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 08:57
Yes, i can agree. Otherwise there will be a lot of double work.
Jack Lukic
@jlukic
Apr 22 2016 08:57
I think you'd probably have a lot better luck getting stars and contributors if you kept jquery and maintained version parity with SUI
but its not ideal
you have the advantage that development has slowed down a bit lately
so its easier to catch up :)
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 08:58
Haha :) it is not ideal for me too, all of us have jobs that generate money :)
Jack Lukic
@jlukic
Apr 22 2016 08:58
jquery it is then
haha
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 08:59
yes :), what is good with SUI, is that you use lot of css3 animations
Jack Lukic
@jlukic
Apr 22 2016 09:00
im very proud of transition
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 09:00
You can easily map all events ( from SUI ) to Angular 2 with Angular directives, and that remove jQuery deps
have you ever tried to implement some sort of light jQuery with SUI ?
Jack Lukic
@jlukic
Apr 22 2016 09:01
I'm hoping a few years from now there will be a clear path for how to handle this
But right now we're still in the murky period of web dev
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 09:02
You should think of removing jQuery anyway
Jack Lukic
@jlukic
Apr 22 2016 09:02
If i was doing SUI in pure js it wouldnt be possible
i'd either have to choose a framework like react or angular
or stick vanilla + jq
the pure JS version of sui would be many many more lines
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 09:02
can you point out something that is not solvable with pure js
yes i can agree
Jack Lukic
@jlukic
Apr 22 2016 09:03
The issue is that its a framework of components
and each component re-uses the same core functions
but are separate
I could write all components with additional functions that handle many of the things in JQ
but then it would increase the size of each component drastically
and provide a lot of code redundancy in components
If the framework was a monolith and required all components to function
then I could do that
but it allows the flexibility of using individual components
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 09:07
ok, i see your point
maybe someone should invest in some kind of transpiler from jquery to vanilla js
Artus Kolanowski
@witrin
Apr 22 2016 09:37
@vladotesanovic Are there other downsides beside the dependency of jQuery, when you reuse the SUI behaviors and make the AngularJS integration just as a wrapper? If not I would say go with the better maintainability! ...
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 09:39
@witrin no, only jQuery ( 84.3 kB ) + semantic.min.js ( 261.8 kB )
Artus Kolanowski
@witrin
Apr 22 2016 09:42
@vladotesanovic IMO Rewriting all components would be too expensive. Doing that would involve the danger that the AngularJS integration become a project with a short lifespan...
I would vote for reusing the SUI behaviors :)
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 09:46
@witrin I agree. Advantage of going without jQuery is that library will be more Angular 2 friendly. Lot of angular 2 developers ( and developers in general ) are going without jQuery nowadays. Using DOM events + css transition for everything.
Jack Lukic
@jlukic
Apr 22 2016 09:46
going without jq would be going without any of the existing js in the project
since its alll built with jq
so it'd be like saying, starting from scratch
and rebuilding sui..
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 09:47
But people who are current SUI users, and they want to go with Angular 2 as their framework, they will not complain
And to mention this: Fist choice of Angular 2 developers, will be Material framework , from many reasons
If we are targeting current SUI community, jQuery is preferred
Artus Kolanowski
@witrin
Apr 22 2016 09:48
:+1:
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 09:48
If we are targeting Angular 2 community, we should go without jQuery
that is how i look on things
Artus Kolanowski
@witrin
Apr 22 2016 09:50
And the risks going without jq is are too big imo
Artus Kolanowski
@witrin
Apr 22 2016 09:56
In detail:
  • always behind the SUI core components
  • higher chance of more bugs
  • higher chance of not fully functional identically with the SUI core components
  • very expensive to maintain
  • higher chance the project will die early
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 09:56
We are on same page.
What you think of having different branch ( one more branch ) in that Repository.
To summarize
Main repo to be with jQuery.
Second branch in main repo to be without jQuery
@edcarroll have energy and good ideas with his project
Artus Kolanowski
@witrin
Apr 22 2016 09:58
I also see the possibility to make the jQuery dependency less painful with a custom build, maybe not all features are required for the SUI core components
That's a very good idea!
Vlado Tesanovic
@vladotesanovic
Apr 22 2016 10:00
@jlukic If you confirm, we will go like that
Edward Carroll
@edcarroll
Apr 22 2016 11:41
Hey - yes actually reading through everything going with the jQuery as the primary one does seem like the best idea at the moment. I have made some good progress on rewriting the components in pure JS using Angular bindings, planning to release 3 new components tonight.
However I can foresee lots of Angular developers preferring the jQuery-less component library, even if we made a custom build - since not integrating them removes the capability to use things like ngmodel and various other Angular only features
What are people's thoughts on this?
Edward Carroll
@edcarroll
Apr 22 2016 11:49
And also to add to this - I'm going to be using my library in a production system over the next few months so it will be actively maintained and improved with that system :)
Artus Kolanowski
@witrin
Apr 22 2016 22:06
I think providing both approaches for the start is a very good idea! Let's see how the community will take on them ...