Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Pulkit Singhal
    @pulkitsinghal
    @pzurek join me here for any discussions
    about the vend sdk and i'll take up the suggestions you have
    i already tweaked the sdk for oauth usage
    Pulkit Singhal
    @pulkitsinghal
    @pzurek - i've added new consignment related endpoints to the SDK as I extract reporting data ... maybe down the line it will help me explain some API-consumption/rate-limiting issues via sample reports
    Pulkit Singhal
    @pulkitsinghal
    @pzurek - this api behaviour is quite interesting so I thought i'd throw it into the chat room for someone somewhere down the line to benefit from:
    1. product updates work when id is provided in the the JSON call: https://developers.vendhq.com/documentation/api/0.x/products.html#update
      {
      "id": "3aab7379-15a2-11e3-a415-bc764e10976c",
      "name": "Anokhi Queen Quilt 7 jul10 try1"
      }
    2. and they also work if both sku and handle are provided in the JSON call too!
      {
      "sku": "Afribeadsnecklace",
      "handle": "Afribeadsnecklace",
      "name": "Anokhi Queen Quilt 7 jul10 try2"
      }
    Pulkit Singhal
    @pulkitsinghal
    @armandcharad - thanks for your contribution
    @armandchard - thank you for your contribution
    Pulkit Singhal
    @pulkitsinghal
    What do you mean by "make an npm installer from this module" in pr#6?
    Are you asking perhaps that after code review and merge, I should publish the latest version to npmjs.com? If so then yes I'll do that. Otherwise, I might not have understood what is requested.
    Pulkit Singhal
    @pulkitsinghal

    @armandchard - i have added easy to read and very simple tests to the project now. Would you mind taking a peek at:

    1. https://github.com/ShoppinPal/vend-nodejs-sdk/blob/master/test/test.js
    2. and, https://github.com/ShoppinPal/vend-nodejs-sdk#tests

    to see if you can automagically understand and start writing your own after rebasing master onto your current fork ... or should I create a tutorial video?

    Pulkit Singhal
    @pulkitsinghal

    @armandchard - here's a video, you may just want to download and watch the 2nd part rather than the first ... or you may find value in watching both ... its up to you :)

    https://www.dropbox.com/sh/3c6bin73xens5r3/AACXKNOrktS10pzoo6WW-yZ8a?dl=0

    streaming directly from dropbox will be very poor quality and you'll miss out on a lot of typed text ... so i suggest downloading the videos before watching

    Pulkit Singhal
    @pulkitsinghal
    @armandchard - so far i'm done with light code review and I've created a list of all the test cases needed to validate your code checkins, if I forgot any features you added, please point them out:
            it('can create a product', function() {
                // TODO: implement it
            });
    
            it('can fetch a product that was just created', function() {
                // TODO: implement it
            });
    
            it('can upload product image', function() {
                // TODO: implement it
            });
    
            it('can fetch a register by ID', function() {
                // TODO: implement it
            });
    
            it('can fetch tags', function() {
                // TODO: implement it
            });
    
            it('can create a tag', function() {
                // TODO: implement it
            });
    
            it('can fetch an outlet by ID', function() {
                // TODO: implement it
            });
    
            it('can fetch product-types', function() {
                // TODO: implement it
            });
    
            it('can create a product-type', function() {
                // TODO: implement it
            });
    
            it('can fetch brands', function() {
                // TODO: implement it
            });
    
            it('can create a brand', function() {
                // TODO: implement it
            });
    
            it('can create a supplier', function() {
                // TODO: implement it
            });
    
            it('can create a tax', function() {
                // TODO: implement it
            });
    Armand
    @armandchard
    @pulkitsinghal Yes in pr#6 I asked you to publish the module on npmjs. So we'll can use npm install vend-nodejs-sk to ours node apps
    Pulkit Singhal
    @pulkitsinghal

    release 1.1.0 of vend-nodejs-sdk has been published:
    https://www.npmjs.com/package/vend-nodejs-sdk

    @meghay and @ysg410 and @armandchard - so congratulations you are famous! ... sort of :)
    you've been listed as contributors in package.json file

    Pulkit Singhal
    @pulkitsinghal
    @armandchard and any other people using this sdk, i found out that several endpoints are actually not implemented, and that is why their implementations in the SDK do not work. Here's a message from the vend api support team:
    ... got a bit carried away with the documentation.
    POST is actually not implemented yet.
    The only endpoint with most or less ready editing functionality is customers.
    I'll fix the docs up soon.
    ...
    OK, the docs are up to date now.
    had to remove POSTs for brands, suppliers and tags too.
    Sorry again for raising giving you false hope. :-)
    ...
    Also, I think you may find the wiki useful:
    https://github.com/vend/developer-wiki/wiki
    cc @pzurek
    Piotr Zurek
    @pzurek
    Oh, I see a bit of community grownig here. Brilliant.
    So, I want the wiki to become a bit of a source of less formal but very useful documentation.
    I'm also open to using the using the issues on that repo to handle bug reports or feature requests
    Pulkit Singhal
    @pulkitsinghal
    @pzurek - very good, i got the ball rolling vend/developer-wiki#1
    Brie Heutmaker
    @bornbrie
    Hi! Something to note is that the README still shows that this package is not available on npm when if fact it now is!
    Pulkit Singhal
    @pulkitsinghal
    wow you really read the README closely @bornbrie and that makes me happy! next chance i get i'll fix the comment inside the code snippet for Usage section
    i hope you get some good mileage out of this module