These are chat archives for SmingHub/Sming

10th
Jan 2016
Dmitry Kireev
@kireevco
Jan 10 2016 01:30
Sorry, very busy lately. I will look into this soon
alonewolfx2
@alonewolfx2
Jan 10 2016 06:21
@hreintke @raburton are you arround
riban-bw
@riban-bw
Jan 10 2016 07:58
I will revert the travis changes then add them to another branch. In this way, we can continue to process the api doc changes separate from automating them which was my original plan. Step-by-step :-)
alonewolfx2
@alonewolfx2
Jan 10 2016 08:14
@riban-bw very good :)
Richard Antony Burton
@raburton
Jan 10 2016 08:16
@alonewolfx2 yes, i am here
alonewolfx2
@alonewolfx2
Jan 10 2016 08:18
i am not good with gitter
how can i update repo with master on windows ?
Richard Antony Burton
@raburton
Jan 10 2016 08:22
assuming you already have it cloned (rather than downloaded as a zipped release)
just go into the directory
type git pull origin master
but if you've made any changes to your own copy, to avoid having merge commits, do git pull --rebase origin master
alonewolfx2
@alonewolfx2
Jan 10 2016 08:23
ok
Richard Antony Burton
@raburton
Jan 10 2016 08:23
that will undo your commits, update, then reapply your commits to the latest upstream version
riban-bw
@riban-bw
Jan 10 2016 08:23
I've reviewed the API doc layout and see that including author, copyright and licence with every page is not useful so will remote that content from the javadocs. I will add it to the main page so everyone sees it when landing on the API docs. Do we want to list all authors or none? (Latter is simpler - I won't have to search all the files to deduce who contributed.) I will leave all original comments in each header file so any references to authors that were put in by the author remain.
alonewolfx2
@alonewolfx2
Jan 10 2016 08:24
i cant create new pr every example added. if it merged i can make new but if it not merged its creating commit on last pr request
Richard Antony Burton
@raburton
Jan 10 2016 08:25
yes, if you want to avoid that you have to do it on separate branches
alonewolfx2
@alonewolfx2
Jan 10 2016 08:26
ok.
Richard Antony Burton
@raburton
Jan 10 2016 08:26
but just for the samples, don't worry about it, just keep adding them and i'll merge the commits periodically for you
doesn't matter if they go in individually or in batches
btw, thanks for doing these!
alonewolfx2
@alonewolfx2
Jan 10 2016 08:27
thank you. some examples need libraries thats why i am adding onr pr every example
thanks for your effort in all sming things
added ds1820 example
hreintke
@hreintke
Jan 10 2016 08:28
@alonewolfx2 :
Hi, I am just in. And also from me thanks for having libraries and examples converting
alonewolfx2
@alonewolfx2
Jan 10 2016 08:30
@hreintke Not important .thank you for base framework
I will add basic_tasks example for new task things. Is it OK?
Richard Antony Burton
@raburton
Jan 10 2016 08:32
i notice you had wrong case on the #include for the library path in the examples
i've enabled building all the samples for prs now, so you'll see the results when built on linux, and it should show up this kind of problem which you won't notice on windows
alonewolfx2
@alonewolfx2
Jan 10 2016 08:34
@raburton which example
riban-bw
@riban-bw
Jan 10 2016 08:34
@raburton Should I revert the rboot api doc changes in PR #542?
hreintke
@hreintke
Jan 10 2016 08:35
Ok for basic_tasks. Keep is simple. I did not much testing on how tasking will effect esp behavior
Richard Antony Burton
@raburton
Jan 10 2016 08:35
@alonewolfx2 temperature sample, it's in the app and the eclipse files
@riban-bw doesn't matter, it can simply be overwritten with the next update, i've put it in upstream now
i won't update until after your merge, so as not to create a conflict when you do
hreintke
@hreintke
Jan 10 2016 08:37
@alonewolfx2 Can you also try a basic_queues which uses the freertos queuing ?
riban-bw
@riban-bw
Jan 10 2016 08:38
@raburton I tweaked the javadocs a bit when I realised I could use "@{" "}@" to group comments in to the same group (module) which removes the need for individual "@ingroup" comments for each function. I intended to update the PR to rboot - but didn't find the time :-(
alonewolfx2
@alonewolfx2
Jan 10 2016 08:38
@hreintke ok @raburton soo make test target will make example for all platforms?
hreintke
@hreintke
Jan 10 2016 08:39
I will create an example where a arduino like loop is implemented.
Needs an update in appinit where a task will be started which calls the loop() function
but first want to finish the sming directory & include structure.
Richard Antony Burton
@raburton
Jan 10 2016 08:42
@alonewolfx2 it will build all the samples on whichever platform you are running on, so when travis does it it will be on linux
@riban-bw thanks, the pr is now merged, but if you do get time you can open another pr, i've tweaked a couple of things, so you'd want to compare against the latest version
@alonewolfx2 see https://travis-ci.org/hreintke/Sming_RTOS_POC for example
i've just merged your pr with the incorrect Libraries case, and it's found the problem on testing the samples, nice!
but in future you'll see that from the pr, without having to merge first
do you want me to quickly fix that for you?
hreintke
@hreintke
Jan 10 2016 08:47
@raburton : @alonewolfx2 :
I will remove the "-v" option in the compile, then there will be a clean output from the travis build.
Used that to clearly understand search path working & usages
Richard Antony Burton
@raburton
Jan 10 2016 08:49
that would look better
hreintke
@hreintke
Jan 10 2016 08:55
done
I am out for now, talk later
alonewolfx2
@alonewolfx2
Jan 10 2016 08:59
@raburton yes please fix it
alonewolfx2
@alonewolfx2
Jan 10 2016 10:01
@raburton @hreintke are library folder names need lower case?
alonewolfx2
@alonewolfx2
Jan 10 2016 11:07
ok. adafruit gfx and pcd8544 waiting. @raburton @hreintke can you merge dht library and i can push new others
robotiko
@robotiko
Jan 10 2016 11:13
Hi @alonewolfx2 .. great stuff :D
alonewolfx2
@alonewolfx2
Jan 10 2016 11:13
ups travis doesnt like lastest pr again
robotiko
@robotiko
Jan 10 2016 11:13
can you test RTOS HW_PWM?
alonewolfx2
@alonewolfx2
Jan 10 2016 11:16
@raburton ok but i dont have osilloscope
Richard Antony Burton
@raburton
Jan 10 2016 12:15
@alonewolfx2 sorry, was out
you seem to have closed the pr for dht, so i can't merge it
alonewolfx2
@alonewolfx2
Jan 10 2016 12:21
yes i closed. i will add in 5 minute
are you still here for 5 minute
Richard Antony Burton
@raburton
Jan 10 2016 12:22
yes, just about!
off for Sunday dinner shortly
alonewolfx2
@alonewolfx2
Jan 10 2016 12:23
ok i am adding dht now
hreintke
@hreintke
Jan 10 2016 12:27
@alonewolfx2 : I can let you merge PR's too but do just when travis returns OK
alonewolfx2
@alonewolfx2
Jan 10 2016 12:30
ok. i am fighting with travis but it seems i win :)
Richard Antony Burton
@raburton
Jan 10 2016 12:32
it's good and it's merged
alonewolfx2
@alonewolfx2
Jan 10 2016 12:32
ok. next is pcd8544 and gfx
Richard Antony Burton
@raburton
Jan 10 2016 12:33
so rtos libsming is pretty much up to date with nonos sming develop branch
few more samples to add, and it'll be essentially done! time to stop calling it poc!
alonewolfx2
@alonewolfx2
Jan 10 2016 12:34
i think yes
robotiko
@robotiko
Jan 10 2016 12:34
wow guys
assom
alonewolfx2
@alonewolfx2
Jan 10 2016 12:36
@raburton it failed hmm what is problem
Richard Antony Burton
@raburton
Jan 10 2016 12:38
what failed?
oh, the new one, i'll have a look
alonewolfx2
@alonewolfx2
Jan 10 2016 12:38
travis. but i find it
Richard Antony Burton
@raburton
Jan 10 2016 12:39
#include "../../Wiring/WiringFrameworkDependencies.h"
hreintke
@hreintke
Jan 10 2016 12:39
@raburton : Agree, with current status we are ready to leave POC and then get more people to use it
Richard Antony Burton
@raburton
Jan 10 2016 12:40
probably should be #include <sming/wiring/WiringFrameworkDependencies.h>
alonewolfx2
@alonewolfx2
Jan 10 2016 12:40
no. i fix it
now ready
hreintke
@hreintke
Jan 10 2016 12:41
@raburton : When I was busy I sometimes get include file not found when using < ... > and no problem when using " ..."
Richard Antony Burton
@raburton
Jan 10 2016 12:42
< > should be used for things on the include path
" " for things that you are referencing by path
alonewolfx2
@alonewolfx2
Jan 10 2016 12:42
@hreintke it seems "" tag seaching sming include folder <> searching sdk include path
@raburton but i had weird issue with ili9341 library
Richard Antony Burton
@raburton
Jan 10 2016 12:43
so samples should use < >, because they are separate to the headers and shouldn't assume their location, only use " " for files in same directory, your project, things that are deliberatly in the same include structure and will not be moved around
i plan to fixup the actual #includes at some point, once the new layout has been finished
so don't worry too much in the mean time
right, got to go...
alonewolfx2
@alonewolfx2
Jan 10 2016 12:45
@hreintke are you here ?
alon24
@alon24
Jan 10 2016 12:47
rtos does not have ssd1306 yet - right?
alonewolfx2
@alonewolfx2
Jan 10 2016 12:49
@alon24 almost have
alon24
@alon24
Jan 10 2016 12:50
:)
and websocket?
alonewolfx2
@alonewolfx2
Jan 10 2016 12:50
not yet but its todo list :D
alon24
@alon24
Jan 10 2016 12:51
gr8
alonewolfx2
@alonewolfx2
Jan 10 2016 12:51
firstly screens that i have
alon24
@alon24
Jan 10 2016 12:51
understandable - u can only test what uu have
alonewolfx2
@alonewolfx2
Jan 10 2016 12:53
yes
seems basically ssd1306 working
but i have issue
hreintke
@hreintke
Jan 10 2016 12:54
@alonewolfx2 : yes I am in
alonewolfx2
@alonewolfx2
Jan 10 2016 12:54
have you ssd1306
alon24
@alon24
Jan 10 2016 12:54
me? yes
hreintke
@hreintke
Jan 10 2016 12:54
@alon24 : websocket is in
alonewolfx2
@alonewolfx2
Jan 10 2016 12:55
@alon24 can you test nonos ssd1306 example and tell me "show circle" working or not?
alon24
@alon24
Jan 10 2016 12:56
this would be my first use of rtos sming, so I cloned the poc, and I cannot build it
I am on a mac
"No rule to make target build"
I just cloned, and placed in eclipse
hreintke
@hreintke
Jan 10 2016 12:57
use target all
alonewolfx2
@alonewolfx2
Jan 10 2016 12:57
@alon24 no please just test old nonos repo not rtos
alon24
@alon24
Jan 10 2016 12:58
@alonewolfx2 oh ok, jas
@hreintke 

14:58:28 **** Build of configuration Default for project Sming_RTOS ****
make all 
CC system/flashmem.c
In file included from include/user_config.h:4:0,
                 from system/flashmem.h:15,
                 from system/flashmem.c:1:
include/esp_systemapi.h:19:31: fatal error: espressif/c_types.h: No such file or directory
 #include <espressif/c_types.h>
                               ^
compilation terminated.
make: *** [build/system/flashmem.o] Error 1
hreintke
@hreintke
Jan 10 2016 13:00
did you set SDK_BASE correctly and downloaded rtos sdk ?
alon24
@alon24
Jan 10 2016 13:00
no, I used alt, as I said not done anything for rtos yet, link to sdk?
and is SDK_BASE new param in eclipse - I have ESP_HOME and SMING_HOME
hreintke
@hreintke
Jan 10 2016 13:05
https://github.com/espressif/ESP8266_RTOS_SDK.git
alt-sdk uses nonos sdk. keep your alt-sdk env and get rtos sdk from github
set SDK_BASE to the location where you put sdk
alonewolfx2
@alonewolfx2
Jan 10 2016 13:05
@hreintke @alon24 alt-sdk has rtos version too
@hreintke all check passed on travis and on hw. @alon24 ssd1306 added
alon24
@alon24
Jan 10 2016 13:07
@alonewolfx2 so i saw the circle
and then the sming framework text... in old ssd1305 non...
alonewolfx2
@alonewolfx2
Jan 10 2016 13:09
@alon24 I added library. Can you adopt your info screen example with rtos sdk?
alon24
@alon24
Jan 10 2016 13:10
@alonewolfx2 alt-sdk has only rtos 1.3 as I see https://bintray.com/kireevco/generic/esp-alt-sdk/view#files
alonewolfx2
@alonewolfx2
Jan 10 2016 13:10
Rtos 1.3 is latest
hreintke
@hreintke
Jan 10 2016 13:10
@alon24 : that is correct, numbering of nosos and rtos are different
alonewolfx2
@alonewolfx2
Jan 10 2016 13:10
*lastest
alon24
@alon24
Jan 10 2016 13:10
confusing :(
alonewolfx2
@alonewolfx2
Jan 10 2016 13:11
@hreintke can you help me for ili9341
alon24
@alon24
Jan 10 2016 13:11
download rtos 1.3, just place it, and show SDK_BASE to there?
robotiko
@robotiko
Jan 10 2016 13:12
@alon24 willign to give it a try?
if you install udk 209 .. it will contain it
and yes
alon24
@alon24
Jan 10 2016 13:13
I can try to compile it now, and maybe work in it in the eveninng
robotiko
@robotiko
Jan 10 2016 13:13
you have to point the sdk_base
alon24
@alon24
Jan 10 2016 13:13
and I am trying this on mac, so no udk
hreintke
@hreintke
Jan 10 2016 13:13
@alonewolfx2 : what help do you need
robotiko
@robotiko
Jan 10 2016 13:13
haaaa
ok
@alon24 you also have to set the SMING_HOME
alon24
@alon24
Jan 10 2016 13:15
SDK_BASE = /opt/esp-alt-sdk-v1.3.0-rtos.258-macos-x86_64 (in eclipse properties) still c_types.h error
robotiko
@robotiko
Jan 10 2016 13:15
to the sming folder of the rt repo
alon24
@alon24
Jan 10 2016 13:18
?
I think the alt (rtos) is missing stuff (compared to non rtos))
never mind, it builds (need to add /sdk)
so only do all, no need to run spiffy target?
hreintke
@hreintke
Jan 10 2016 13:20
spiffy is identical to nonos, if you want spiffs fs you need spiffy, otherwise not
all is not building spiffy, only framework
alon24
@alon24
Jan 10 2016 13:21
@alonewolfx2 where in the sming rtos is the ssd1306 code?
alonewolfx2
@alonewolfx2
Jan 10 2016 13:22
@hreintke hspi.h failing
alon24
@alon24
Jan 10 2016 13:22
15:22:17 **** Build of configuration Default for project Sming_RTOS ****
make spiffy 
make: Nothing to be done for `spiffy'.

15:22:17 Build Finished (took 72ms)
@hreintke I do not think the target is doing anything
alonewolfx2
@alonewolfx2
Jan 10 2016 13:23
and can you merge ssd1306 pr ?
alon24
@alon24
Jan 10 2016 13:24
should I be on master for rtos?
alonewolfx2
@alonewolfx2
Jan 10 2016 13:24
yes
but you need to compile spiffy
alon24
@alon24
Jan 10 2016 13:25
as I say, i do not think the spiffy compile task does anything, because I tried it after clean and it showed no work,so I do not know how to test if its ok
I have not run a prog yet
I will see what needs to be done for rtos in infoscreens when I see the ssd1306 code
does it NOT run on it?
I also set the SMING_HOME to /Users/iklein/docker/sming-docker/workspace/Sming_RTOS_POC/sming
alonewolfx2
@alonewolfx2
Jan 10 2016 13:32
@alon24 ok firstly clean everything
and try make all
hreintke
@hreintke
Jan 10 2016 13:38
@alonewolfx2 : Why is Adafruit_ILI9341 using a local hspi and not the one from sming
alonewolfx2
@alonewolfx2
Jan 10 2016 13:40
@hreintke sming havent yet harwdare spi when i port that lib and i used hspi.h and i didnt change it again
ups where is WifiAccessPoint class
alon24
@alon24
Jan 10 2016 13:42
@alonewolfx2 I did,. same same
(so spiff task seems to do nothing)
alonewolfx2
@alonewolfx2
Jan 10 2016 13:43
@alon24 can you try manual make in spiffy directory
alon24
@alon24
Jan 10 2016 13:45
@alonewolfx2 same message
does it work for u?
alonewolfx2
@alonewolfx2
Jan 10 2016 13:45
yes
make clean and make again in spiffy directory
alon24
@alon24
Jan 10 2016 13:47
@alonewolfx2 that worked
so it seems that rttos -clean, does NOT clean spiffy
(just checked this with manual clean in spiffy)
alonewolfx2
@alonewolfx2
Jan 10 2016 13:48
blob
it seems yes
open issue for this
?
alonewolfx2
@alonewolfx2
Jan 10 2016 13:49
yes
alon24
@alon24
Jan 10 2016 13:52
hreintke/Sming_RTOS_POC#34
i hope to work on ssd1306- infoscreens - tonight
alon24
@alon24
Jan 10 2016 14:04
I cannot flash using rtos
16:03:15 **** Build of configuration Sming for project ScreenOLED_SSD1306 ****
make flash 
(!) Spiffs support disabled. Remove 'DISABLE_SPIFFS' make argument to enable spiffs.
Killing Terminal to free /dev/tty.SLAB_USBtoUART
/opt/esp-alt-sdk-1.5.0.master/esptool/esptool.py -p /dev/tty.SLAB_USBtoUART -b 961000 write_flash -ff 40m -fm qio -fs 4m 0x00000 out/firmware/0x00000.bin 0x0a000 out/firmware/0x0a000.bin
Connecting...

A fatal error occurred: Failed to connect to ESP8266
make: *** [flash] Error 2

16:03:21 Build Finished (took 6s.367ms)
using alt-sdk
the esp-alt 1.3 does not have esptool and esptool2 in it
could this be a build (esp-alt) build issue
alonewolfx2
@alonewolfx2
Jan 10 2016 14:07
propably esp-alt-sdk issue
alon24
@alon24
Jan 10 2016 14:07
yes ( I copied 2 dirs and it started flashing ok)
hreintke
@hreintke
Jan 10 2016 14:11
@alonewolfx2 : wifiaccespoint was missing is smingcore.h now included.
beware not tested very well, look careful and report issues
alon24
@alon24
Jan 10 2016 14:13
tring to compile infoscreens :


16:12:47 **** Build of configuration Sming for project InfoScreens ****
make all 
C+ app/drivers/ILI9341_Driver.cpp
C+ app/drivers/PCD8544_Driver.cpp
C+ app/drivers/SSD1306_Driver.cpp
AR out/build/app_app.a
LD out/build/app.out
/Users/iklein/docker/sming-docker/workspace/Sming_RTOS_POC/sming/compiler/lib//libsming.a(user_main.o):(.text.user_init+0x14): undefined reference to `init()'
/Users/iklein/docker/sming-docker/workspace/Sming_RTOS_POC/sming/compiler/lib//libsming.a(user_main.o): In function `user_init':
/Users/iklein/docker/sming-docker/workspace/Sming_RTOS_POC/sming//appinit/user_main.cpp:25: undefined reference to `init()'
collect2: error: ld returned 1 exit status
make: *** [out/build/app.out] Error 1

16:12:48 Build Finished (took 826ms)
do I need to replace any make file or anyhting in my project old sming-> new rtos sming
robotiko
@robotiko
Jan 10 2016 14:14
@alon24 if you pointed SMING_HOME
alon24
@alon24
Jan 10 2016 14:14
I did
the ssd1306 example compiles and runs ok
robotiko
@robotiko
Jan 10 2016 14:15
hum i see it is infoscreens that fails
alon24
@alon24
Jan 10 2016 14:16
I use modules
robotiko
@robotiko
Jan 10 2016 14:16
makes sure that all referes to non nono
alon24
@alon24
Jan 10 2016 14:16
so I had to remoe app moodule
#Add your source directories here separated by space
MODULES = app/drivers
robotiko
@robotiko
Jan 10 2016 14:17
yes that it what I was thinking baout t
about
that you addded addtional build folders
alon24
@alon24
Jan 10 2016 14:17
is that supported in rtos?
robotiko
@robotiko
Jan 10 2016 14:17
and I'm not sure if that is supported yet
alon24
@alon24
Jan 10 2016 14:17
(sming current implementation)
robotiko
@robotiko
Jan 10 2016 14:18
all the environemtn and includes is new..
and was doen incrementally
@hreintke and @raburton can probably tell you
alon24
@alon24
Jan 10 2016 14:19
I'll wait
robotiko
@robotiko
Jan 10 2016 14:19
mainly @raburton
i guess
hreintke
@hreintke
Jan 10 2016 14:19
what is exactly the question ?
alon24
@alon24
Jan 10 2016 14:20
I have an extra module, how can I use it
MODULES = app/drivers
hreintke
@hreintke
Jan 10 2016 14:20
how did you do that in nonos ?
alon24
@alon24
Jan 10 2016 14:21
in Makefile-user.mk I added:
MODULES = app app/drivers

Now it does not like app there (it does not compile),. and it seems to not compile my code 
16:23:40 **** Build of configuration Sming for project InfoScreens ****
make rebuild 
C+ app/drivers/ILI9341_Driver.cpp
C+ app/drivers/PCD8544_Driver.cpp
C+ app/drivers/SSD1306_Driver.cpp
AR out/build/app_app.a
LD out/build/app.out
/Users/iklein/docker/sming-docker/workspace/Sming_RTOS_POC/sming/compiler/lib//libsming.a(user_main.o):(.text.user_init+0x14): undefined reference to `init()'
/Users/iklein/docker/sming-docker/workspace/Sming_RTOS_POC/sming/compiler/lib//libsming.a(user_main.o): In function `user_init':
/Users/iklein/docker/sming-docker/workspace/Sming_RTOS_POC/sming//appinit/user_main.cpp:25: undefined reference to `init()'
collect2: error: ld returned 1 exit status
make: *** [out/build/app.out] Error 1

16:23:41 Build Finished (took 1s.37ms)

I think its because of the app/drivers module
maybe???
I corrected the screen cap, it was not the error after I removed the app module
hreintke
@hreintke
Jan 10 2016 14:27
difference now is in makefile-project
nonos MODULES += app
rtos MODULES ?= app
alon24
@alon24
Jan 10 2016 14:28
#Add your source directories here separated by space
MODULES ?= app app/drivers

No good 


C+ app/InfoScreens.cpp
In file included from include/utils/MultiFunctionButton.h:11:0,
                 from include/InfoScreens.h:14,
                 from app/InfoScreens.cpp:7:
include/user_config.h:26:40: fatal error: espinc/c_types_compatible.h: No such file or directory
  #include <espinc/c_types_compatible.h>
                                        ^
compilation terminated.
make: *** [out/build/app/InfoScreens.o] Error 1

16:27:45 Build Finished (took 76ms)
hreintke
@hreintke
Jan 10 2016 14:29
c_types_compatible is not in rtos, should not be needed anymore.
Do you have an example from rtos repo or one of your own
alon24
@alon24
Jan 10 2016 14:30
SSD1306 example compiles, runs and ok,
it has the file in the user_config.h file (I copied it)
alonewolfx2
@alonewolfx2
Jan 10 2016 14:31
@alon24 just remove user config. H include in application. Cpp
alon24
@alon24
Jan 10 2016 14:32
include/utils/MultiFunctionButton.h:228:2: error: 'boolean' does not name a type
  boolean DCwaiting = false; // whether we're waiting for a double click (down)
  ^
include/utils/MultiFunctionButton.h:229:2: error: 'boolean' does not name a type
  boolean TCwaiting = false; // whether we're waiting for a tripple click (down)
  ^
include/utils/MultiFunctionButton.h:230:2: error: 'boolean' does not name a type
  boolean DConUp = false; // whether to register a double click on next release, or whether to wait and click
  ^
include/utils/MultiFunctionButton.h:231:2: error: 'boolean' does not name a type
  boolean TConUp = false; // whether to register a tripple click on next release, or whether to wait and click
  ^
include/utils/MultiFunctionButton.h:232:2: error: 'boolean' does not name a type
  boolean singleOK = true;    // whether it's OK to do a single click
  ^
include/utils/MultiFunctionButton.h:233:2: error: 'boolean' does not name a type
  boolean doubleOK = true;    // whether it's OK to do a double click
so change all boolean -> bool
alonewolfx2
@alonewolfx2
Jan 10 2016 14:33
Add # include <Sming Core.h>

include <SmingCore.h>

alon24
@alon24
Jan 10 2016 14:34
yes it changed
alonewolfx2
@alonewolfx2
Jan 10 2016 14:34
What is last result
alon24
@alon24
Jan 10 2016 14:35
infoscreens works ok, with rtos
now delivered to rtos branch
hreintke
@hreintke
Jan 10 2016 14:38
@alon24 @alonewolfx2 :
We are restructuring usage of user_config, is not completely finished yet.
The include in there from "system include files" like esp_systemapi.h will move to smingcore.h
robotiko
@robotiko
Jan 10 2016 14:40
@hreintke any decision about the wire being moved to core?
alonewolfx2
@alonewolfx2
Jan 10 2016 14:44
@hreintke and user specific defines in user config. H right?
hreintke
@hreintke
Jan 10 2016 14:51
@robotiko : no decision yet, but I expect we will move it.
@alonewolfx2 : yes, only user specific defines.
There will be a sming_config in the framework where the defaults are set, user_config can then override
robotiko
@robotiko
Jan 10 2016 14:54
@hreintke makes sense since it is being referred by many libs
hreintke
@hreintke
Jan 10 2016 14:55
which defines are reference by many libs
Richard Antony Burton
@raburton
Jan 10 2016 14:58
@hreintke in fact, since a user_config.h is no longer required by the sdk, the user can override sming_config.h defines anywhere (as long as it's before the sming_config.h is included), the convention of using user_config.h is no longer required
hreintke
@hreintke
Jan 10 2016 15:01
@raburton : Yes, that is true for all applications made by user.
I was thinking whether it would be a good idea to have a user_config.h with each example which shows the usage
Richard Antony Burton
@raburton
Jan 10 2016 15:02
maybe better to document it rather than example, otherwise it needs to be kept up to date with new options and duplicated in each sample
hreintke
@hreintke
Jan 10 2016 15:05
exactly that was also my "negative aspect". Not having "all those" identical user_config 's would be better
hreintke
@hreintke
Jan 10 2016 15:11
@raburton : where could I configure travis to compile a branch on which I am working.
When finalizing the restructuring I'd like to see whether all compiles on unix too
Richard Antony Burton
@raburton
Jan 10 2016 15:37
@hreintke not sure if you can do a branch directly, but you could create a pr to master from that branch and it will build the pr (which would work out the same)
does it not build all branches from the repo anyway?
hreintke
@hreintke
Jan 10 2016 16:00
@raburton : It was mentioned in a "beware remark" The travis file needs to be in each active branch.
I included it in the restructure branch and make sure that it will be deleted before merging.
Richard Antony Burton
@raburton
Jan 10 2016 16:02
in future it will be in any branches, i suppose the problem here was that you branched before travis was added to master
the other option, which you might need to do anyway before merging is to rebase on master, that would pull in the real travis file
looks like you need the newer makefile too
but if you've made changes to the one in the branch will need merging
hreintke
@hreintke
Jan 10 2016 16:05
@raburton : yes that was the issue. I branched just before the travis inclusion.
alonewolfx2
@alonewolfx2
Jan 10 2016 16:06
websocket server working fine
Richard Antony Burton
@raburton
Jan 10 2016 16:10
@hreintke do you want me to rebase the branch on master for you?
hreintke
@hreintke
Jan 10 2016 16:11
I will work on the restructuring on monday. Will find out which changes I need temporary in the travis/makefile in branch.
alonewolfx2
@alonewolfx2
Jan 10 2016 16:11
@raburton i am creating pr wait a minute please
hreintke
@hreintke
Jan 10 2016 16:12
@raburton : rebase would be great, working with rebasing/merging is one of my weak points. but only do it when not to much trouble
Richard Antony Burton
@raburton
Jan 10 2016 16:13
@alonewolfx2 won't touch your stuff, don't worry
Jim Sparkman
@jimsparkman
Jan 10 2016 16:16
@raburton thanks for the response, evaluating sming for potential usage in a small scale commercial product, we would of course contribute back all changes to libsming.a in accordance with LGPLv3 but I was concerned about project longevity but community seems active
alonewolfx2
@alonewolfx2
Jan 10 2016 16:18
websocketserver example added. tested on chrome-windows,edge-windows,chrome-android
Richard Antony Burton
@raburton
Jan 10 2016 16:35
@hreintke i've rebased on master, so it's all up to date with recent changes
however it looks like some of the recently added libraries need a little work for the new include structure
so i've pushed it to a new branch Restructure_Include_Sming2, if you check that out and continue to work in there you should be able to make a clean merge back to master, once the few new library issues are sorted out
Richard Antony Burton
@raburton
Jan 10 2016 16:43
i can squash the commits and neaten it up a little if you want me to, before making the final pull
hreintke
@hreintke
Jan 10 2016 16:47
OK, my understanding now is that I continue working on Restructure_Include_Sming2, when finalized and you and me agree you squash and then merge. Is that the idea ?
Richard Antony Burton
@raburton
Jan 10 2016 16:49
yeah, although squashing isn;t necessary, would just tidy it up a bit
i could squash now if you like, combine what you've done so far into one
hreintke
@hreintke
Jan 10 2016 16:54
I don't know the benefit of that. I think for me now working on the new branch it is no difference. If it is easier for you no problem of course
Richard Antony Burton
@raburton
Jan 10 2016 16:59
it's just considered good practice, rather than submit 20 commits for 1 feature, most of with are one line fixes, etc. keeps the repo history tidy and features in a single commit (imagine if you wanted to cherry pick this feature into another branch and it's in loads of separate commits)
but it's not critical
we used to ask people submitting prs to do this, if it started as multiple commits, or after changes from code reviews, but we were never strict about it
hreintke
@hreintke
Jan 10 2016 17:05
I know, I used the branch to show you the ideas that I had and subsequently added new stuff.
I thought the difference in the question above was :
now we have 10+ commits in the branch, there will come some more.
Option 1 : squash now, commit some more squash again, merge
Option 2 : commit some more, squash, merge
alonewolfx2
@alonewolfx2
Jan 10 2016 17:09
@raburton @hreintke do i need to work on new rbase branch for adding libraries and examples
?
Dmitry Kireev
@kireevco
Jan 10 2016 17:12
@jimsparkman imho esp8266 is not good yet for commercial.
@jimsparkman maybe only as a wifi/tcp stack
or quick prototyping
Richard Antony Burton
@raburton
Jan 10 2016 17:13
@alonewolfx2 no, just carry on master - @hreintke will have to fix up any new include issues you create!
maybe waiting till he's done would make most sense, but i don't want to put you off when you're making such good progress!
@kireevco it's true as a platform it's not mature, the underlying sdk isn't and so nothing on top of it can be considered to be either, but they have made a lot of progress over this last year, and the hardware seems to be pretty solid, so i think if it does what you need it to no reason not to go with it
waiting for a really mature product is likely to just mean being late to market
hreintke
@hreintke
Jan 10 2016 17:22
@alonewolfx2 : @raburton :
agree, It will be ready quick but I just need some "concentrated hours" to be sure not to break a lot when introducing.
Dmitry Kireev
@kireevco
Jan 10 2016 18:58
@raburton what pisses me off, that even if we struggle to hell, SDK libraries are still closed, and we can't fix them :)
Richard Antony Burton
@raburton
Jan 10 2016 19:02
@kireevco - agreed, i suppose a lot of their work is in the software, someone else could just got to xtensa and ask for the same cores to be put in chip for them to run the code if it was open source i guess
Dmitry Kireev
@kireevco
Jan 10 2016 19:02
probably
well, you know CTO of espressif used to work for xtensa/tenesilca:)
Richard Antony Burton
@raburton
Jan 10 2016 19:03
i didn't know that
robotiko
@robotiko
Jan 10 2016 19:24
@hreintke @raburton
any reason why the servo stuff and HW timer is not merged into develop?
SmingHub/Sming#471
and SmingHub/Sming#472
it was tested in HW working correctly
referring to Sming.. not smingRT
Richard Antony Burton
@raburton
Jan 10 2016 19:28
no idea sorry, they aren't prs i've ben involved with
probably no body has been
robotiko
@robotiko
Jan 10 2016 19:29
I think they got missing
Richard Antony Burton
@raburton
Jan 10 2016 19:29
i can't look at them now, but i'll see if i can get a chance to do so soon, unless someone else does first
robotiko
@robotiko
Jan 10 2016 19:29
we didnt include due to version stability
I tested them
I bet the only thing they will need now is to move the sample to the new folder
I will retest them now.. if all ok .. ready to merge or we are in frozen status (pre release)?
alonewolfx2
@alonewolfx2
Jan 10 2016 19:31
@robotiko if it will move sample directory i can merge it
it seems we missed that pr
robotiko
@robotiko
Jan 10 2016 19:31
I asked many times :D
but gitter is quite noisy sometimes
so we are all ok?
hreintke
@hreintke
Jan 10 2016 19:34
@alonewolfx2 : @robotiko :
alonewolfx2
@alonewolfx2
Jan 10 2016 19:35
@hreintke @robotiko :)
robotiko
@robotiko
Jan 10 2016 19:36
@alonewolfx2 you better listen :D
we probably did soemthing worng :D
hreintke
@hreintke
Jan 10 2016 19:36
What I already mentioned some time and is also in issue #519. I'd like to get out a V2.1 Sming release out so the bugfixes or in a released version. No response up till now but I stick to my opinion
No I was in chat mode instead of compose mode :smile:
robotiko
@robotiko
Jan 10 2016 19:38
so ..
no merge
alonewolfx2
@alonewolfx2
Jan 10 2016 19:38
@hreintke how about v2.01 bug fixes and v2.1 is new things
robotiko
@robotiko
Jan 10 2016 19:38
@alonewolfx2 doenst really matter that much I guess... in terma or waking up dead PRs
they cannot be merged anyway
hreintke
@hreintke
Jan 10 2016 19:38
Whatever we call the release, that is not the issue. It just needs to be done.
alonewolfx2
@alonewolfx2
Jan 10 2016 19:39
@hreintke we need to be quick
servo pr waiting
robotiko
@robotiko
Jan 10 2016 19:40
I already tested it 4 times :D
alonewolfx2
@alonewolfx2
Jan 10 2016 19:41
also rfid pr waiting on my side too
hreintke
@hreintke
Jan 10 2016 19:41
I know, I know. so I will push again, I cannot release on my own.
robotiko
@robotiko
Jan 10 2016 19:41
oook
I think i asked this before
what do you think if when about to close a release.. we add a list of all the PRs that should be included?
give a couple of days to merge/test.. and then go?
hreintke
@hreintke
Jan 10 2016 19:43
@kireevco : See the discussion above and issue #519. If we release, when can you update your download area ?
alonewolfx2
@alonewolfx2
Jan 10 2016 19:45
propably he is sleeping but @kireevco is always ready. he can
hreintke
@hreintke
Jan 10 2016 19:45
Before a PR is merged it should be tested OK. The time it is in develop is to make sure there is no interference between PR's, and will be used on multiple platforms.
robotiko
@robotiko
Jan 10 2016 19:47
@hreintke yes I'm aware. In this case this was tested and improved 2-3 times until we reached a good agreed version .. that was tested .. but never got merged
I recall a similar situation.. closed version ready to go.. better not merge
alonewolfx2
@alonewolfx2
Jan 10 2016 19:49
@hreintke i think we can merge it
robotiko
@robotiko
Jan 10 2016 19:50
@alonewolfx2 hey.. recall now we need to move to samples
Im testing that
alonewolfx2
@alonewolfx2
Jan 10 2016 19:51
ok test it please
robotiko
@robotiko
Jan 10 2016 19:53
@hreintke @alonewolfx2 the HW timer is ok to be merged? we splitted servo PR into HW timer and servo ..so we should merge that way too
hreintke
@hreintke
Jan 10 2016 19:55
@robotiko : we should merge into develop the moment we released V2.1
robotiko
@robotiko
Jan 10 2016 19:57
ok
then
nothing todo
Dmitry Kireev
@kireevco
Jan 10 2016 20:03
@hreintke what will be the link ot the new version? I'll add it
alonewolfx2
@alonewolfx2
Jan 10 2016 20:03
@hreintke version number changed so we can merge new pr's ?
robotiko
@robotiko
Jan 10 2016 20:17
@raburton probably not good moment but I was thinking about the GDB PR issues and Sming_rt
SmingHub/Sming#350
since the types references seem to be gone.. rpobably the GDB works in sming_rt if the same framework tweaks are introduced?
hreintke
@hreintke
Jan 10 2016 20:31
@alonewolfx2 : No, Not before Develop is merged into Master.
That is "The release moment"
It will be the same as 2.0.0 but then with 2.1.0 https://github.com/SmingHub/Sming/releases/tag/2.1.0
Dmitry Kireev
@kireevco
Jan 10 2016 20:40
@hreintke what will be the link?
hreintke
@hreintke
Jan 10 2016 20:41
see the line above
Dmitry Kireev
@kireevco
Jan 10 2016 20:41
oh, that was for me
hreintke
@hreintke
Jan 10 2016 20:42
Ai.. sorry didn't think of that
I'll put that link
laurentppol
@laurentppol
Jan 10 2016 20:44
it's no nos or rtos?
hreintke
@hreintke
Jan 10 2016 20:44
OK, great.
@laurentppol it is nonos
laurentppol
@laurentppol
Jan 10 2016 20:46
ups, link doesn't work, got 404 not found :(
url transformed to that: https://codeload.github.com/SmingHub/Sming/zip/2.1.0 then 404
alonewolfx2
@alonewolfx2
Jan 10 2016 20:48
@laurentppol zip file not ready yet
laurentppol
@laurentppol
Jan 10 2016 20:48
how to modify Makefile to have a target that does NOT flash spiffs? only app and (if needed bootloader)
ahh, ok
hreintke
@hreintke
Jan 10 2016 20:50
@laurentppol : If you it now, you can clone develop branch. That contains exactly V2.1 now
alonewolfx2
@alonewolfx2
Jan 10 2016 20:50
DISABLE_SPIFFS = 1 in makefile user
laurentppol
@laurentppol
Jan 10 2016 20:52
but I want spiffs to be still generated (it contains settings now), but have command line option not to flash it
"make flash_nospiffs"
laurentppol
@laurentppol
Jan 10 2016 20:58
OK, got it: cloned "flash:" section of Makefile-project, leaving only command used to flash w/o spiffs :)
Richard Antony Burton
@raburton
Jan 10 2016 20:59
ok, going to merge the new release
alonewolfx2
@alonewolfx2
Jan 10 2016 21:06
@raburton @hreintke lastest example on rtos is sdcard for today. i am out. have a good time
Richard Antony Burton
@raburton
Jan 10 2016 21:07
thanks
ok, merge done, develop resynced
@hreintke can you create the tags, etc.
alonewolfx2
@alonewolfx2
Jan 10 2016 21:09
btw @raburton is rboot working correctly on rtos?
laurentppol
@laurentppol
Jan 10 2016 21:21
now a bit more complicated question, about TCPServer:
I got (cloning "Telnet_TCPServer_TCPClient" example parts) to have working TCP server.
Now I want, when client is connected, to send some data from main part of program.
So, for my understanding of TCP/IP, I need some kind of list of connected clients, and invoke "sendString on one/all
how to get such list?
"onConnect/Disconnect" works, "onClientData" also
hreintke
@hreintke
Jan 10 2016 21:25
@raburton : @kireevco :
Created the Release (which includes the tags)
Richard Antony Burton
@raburton
Jan 10 2016 21:27
@alonewolfx2 yes, rBoot is working perfectly on rtos
hreintke
@hreintke
Jan 10 2016 21:28
@laurentppol :
The onConnect has a TcpClient parameter. That is the client which you can use for transmitting
laurentppol
@laurentppol
Jan 10 2016 21:30
ok, back to reading TcpServer.cpp source ;P
hreintke
@hreintke
Jan 10 2016 21:31
@laurentppol : You can see the callback in example
void tcpServerClientConnected (TcpClient* client)
{
    debugf("Application onClientCallback : %s\r\n",client->getRemoteIp().toString().c_str());
}
laurentppol
@laurentppol
Jan 10 2016 21:31
THIS works
but how to have client (list) in main program? not only in this callback?
for ONE connection I may set global variable...
but if I set it in this callback, only the LAST client will get data
hreintke
@hreintke
Jan 10 2016 21:41
The TcpServer doesn't keep a list of active clients (might be a nice addition so feel free to PR)
But for now, you would need to keep the list of active clients in the app. f.e. in a vector. On close you will also be informed with client parameter.
Or, of course this is C++ and with the delegate usage of the callback you can instantiate an object which handles the connection. Then all this communication can be done from within that object.
robotiko
@robotiko
Jan 10 2016 21:44
@hreintke so the deploy and merge is done.. we are ready for more merges now?
hreintke
@hreintke
Jan 10 2016 21:46
yes we are :smile:
laurentppol
@laurentppol
Jan 10 2016 21:46
don't know anything about delegates :(, so keeping client list sounds much simpler (realizable). Vector is variable size array? (I have Bjarne's book, but not have read "end-to-end")
robotiko
@robotiko
Jan 10 2016 21:46
great
so no issue now to merge?
I mean the hw timer pr?
hreintke
@hreintke
Jan 10 2016 21:50
@laurentppol : you can uses Vector<...> myvector. to define a vector of any type of object.
Use code completion on myvector to see the functions.
Richard Antony Burton
@raburton
Jan 10 2016 21:55
@kireevco i noticed you have alt rtos sdk packages available, created on myself the other day, buf i though if you have them, esp for non-linux platforms, would be easier to use them
but it looks like they don't actually have the sdk in them
hreintke
@hreintke
Jan 10 2016 21:56
@robotiko hwtimer can be merged, servo not. That has failing Travis CI
robotiko
@robotiko
Jan 10 2016 21:57
ok I have a look at servo
who merges?
the servo is working.. (however not in samples)
hreintke
@hreintke
Jan 10 2016 21:58
@raburton : thanks for the travis hint. I found the rebuild button on travis :smile:
robotiko
@robotiko
Jan 10 2016 21:58
the problem with travis and servos is environment related The command "wget https://bintray.com/artifact/download/kireevco/generic/esp-open-sdk-1.4-linux-x86_64.tar.gz" failed and exited with 8 during ."
hreintke
@hreintke
Jan 10 2016 21:59
@robotiko : I will merge the hwtimer.
Richard Antony Burton
@raburton
Jan 10 2016 21:59
sounds like the pr probably needs updating
robotiko
@robotiko
Jan 10 2016 21:59
@raburton for this servo stuff that needs to be moved to the samples
how to proceed? hwo did you do with teh other cases? push t the PR and then merge (don't knwo if possible since I'm not owner)
Richard Antony Burton
@raburton
Jan 10 2016 22:00
the pr will need rebasing on develop
robotiko
@robotiko
Jan 10 2016 22:00
or another pr+ merge and then close this?
Richard Antony Burton
@raburton
Jan 10 2016 22:01
probably pull to own copy, fixup and resubmit
robotiko
@robotiko
Jan 10 2016 22:01
resubmit to PR or develop?
Richard Antony Burton
@raburton
Jan 10 2016 22:02
only author will be able to update the pr, so best to create a new one, give me a sec...
robotiko
@robotiko
Jan 10 2016 22:02
you have done this to many other prs, rigth?
ok
roger that
hreintke
@hreintke
Jan 10 2016 22:09
@kireevco : If it is a download filename issue, how can #471 build correct and #472 not ?
Richard Antony Burton
@raburton
Jan 10 2016 22:10
@robotiko looks like it servo depends on hardware timer, that will need to be merged first, then pr #546 might build
robotiko
@robotiko
Jan 10 2016 22:11
yes there is such dependency
hreintke
@hreintke
Jan 10 2016 22:18
@raburton : As we were both in this discussion. Shall I merge #471 ?
robotiko
@robotiko
Jan 10 2016 22:18
@raburton I see you fixed and pushed .. ok
:D
@hreintke I dotn see any issue with it.. should be ready to go
I cna merge if you want
@raburton thanks
hreintke
@hreintke
Jan 10 2016 22:22
merged
robotiko
@robotiko
Jan 10 2016 22:23
ok so now just see if new PR pass travis and merge servo too
and finally enjoy and forget about this :D
laurentppol
@laurentppol
Jan 10 2016 22:26
@hreintke there is no code completion in Midnight Commander ;P :)
robotiko
@robotiko
Jan 10 2016 22:30
@raburton it is still flagged as failed.
how cna force travis to try again?
ok
is on the way
ok
completed ok
so mergeable
hreintke
@hreintke
Jan 10 2016 22:36
@robotiko : I just restarted.
I think you have also access rights https://travis-ci.org/SmingHub/Sming/builds/101470845
robotiko
@robotiko
Jan 10 2016 22:36
ok thanks
I didnt merge.. becuase didnt want to mess with your procedure
I will leave for a while (dinner time)
hreintke
@hreintke
Jan 10 2016 22:37
This is not for merging. Restarting travis
@laurentppol : Then you need use examples or wait until the documentation is online (there is a lot of activity in that at the moment)
laurentppol
@laurentppol
Jan 10 2016 22:43
@hreintke which example?
hreintke
@hreintke
Jan 10 2016 22:44
there is no specific example for vector as it is no real "sming functionality"
I know there is vector usage in the tcpserver example you are using