These are chat archives for SmingHub/Sming

1st
Mar 2017
riban-bw
@riban-bw
Mar 01 2017 10:25
The last commits (#988 & #989) seem to have broken my msys2 build environment. Before I investigate further / report a bug, can anyone confirm this works with both Windows and Linux builds?
slaff
@slaff
Mar 01 2017 10:33

msys2 build environment

I assume this is Windows. Do you have python in your OS?

can anyone confirm this works with both Windows and Linux builds?

Our CI tests can confirm this :)

riban-bw
@riban-bw
Mar 01 2017 16:16

Python 3.4.5 is installed within msys2 enviroment which is running on Windows 7 64-bit. Does CI build the examples? Sming builds fine but fails to build examples:

Traceback (most recent call last):
File "/D/PJ/SmingHub/Sming/Sming/../tools/memanalyzer.py", line 40, in <module> lines = response.split('\n')
TypeError: 'str' does not support the buffer interface

My friend Google says: If you use Python3x then string is not the same type as for Python 2.x, you must cast it to bytes
slaff
@slaff
Mar 01 2017 16:18
@riban-bw Can you create an issue with the description. I will take care to fix it.
riban-bw
@riban-bw
Mar 01 2017 16:18
So maybe this is a Python version compatibility issue. So the next question is, does this work for users with Python 3.4.5?
@slaff Sure!
riban-bw
@riban-bw
Mar 01 2017 16:38
Reported as: SmingHub/Sming#990. Just proved on my Linux machine that this passes with Python2 and fails with Python3. Good luck! I will see if I can install Python2 in my msys2 env to work around...
slaff
@slaff
Mar 01 2017 16:43
No need - the fix is here to test: SmingHub/Sming#991
riban-bw
@riban-bw
Mar 01 2017 16:59
Cheers slaff - much better service than I get from my business service providers :-)
slaff
@slaff
Mar 01 2017 17:00
Well, you we re lucky to get me during a "no-call-meeting-emergency" period ;)
Once the CI tests pass I will merge the PR.