These are chat archives for SmingHub/Sming

29th
Sep 2017
frankdownunder
@frankdownunder
Sep 29 2017 02:59
I think I have found a memory leak in libemqtt.c : mqtt_init_auth() -> username seems to get malloc'd repeatedly if the MQQT server is unreachable, and if using a username or password. Before I have a go at fixing it, I'd like to suggest that it might be a LOT cleaner to merge the code in libemqtt.c with MqttClient.cpp. We could get rid of calls to malloc snf strcpy for starters - Opinions?
slaff
@slaff
Sep 29 2017 05:18
@frankdownunder I would prefer not to merge the code at that time. The external library (libmqtt.c )may develop further and we should be able to get the latest version. But what you can do is send a PR with the recommended changes related to the memory leak.
frankdownunder
@frankdownunder
Sep 29 2017 05:19
@slaff OK, I'll ad the two missing lines, test it out and get back to you.
frankdownunder
@frankdownunder
Sep 29 2017 05:56
@slaff Are there some notes I can read on how to make a PR?