Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    tachyonics
    @tachyonics
    And hopefully final changes to SmokeFramework to optimise how we are using SwiftNIO ByteBuffers - amzn/smoke-framework#21
    tachyonics
    @tachyonics
    Add the ability to pass an existing eventLoopProvider for SmokeDynamoDb - amzn/smoke-dynamodb#6
    tachyonics
    @tachyonics
    I am going to be bumping our non-code-generator packages to 1.0.0 today.
    I have a small PR for an issue found in SmokeAWSCredentials - amzn/smoke-aws-credentials#5
    And a PR for latest interface changes in SmokeAWSGenerate - amzn/smoke-aws-generate#2
    tachyonics
    @tachyonics
    One pretty small PR today to use variable name rather than type as a parameter when converting to allow multiple parameters of the same type in a structure - amzn/service-model-swift-code-generate#3
    tachyonics
    @tachyonics
    Hi all! @tasanobu made a good point to me offline around how we want to keep track of tasks and assigned work. This will get more important as more people start contributing to these repositories. What do people think? Should we start using Github issues consistently to track work or use something else?
    Alex (Jae) Choi
    @asd2734
    Github issues would be an intuitive place for new people to look into, but I would be open to other solutions. Do we have anything else in mind?
    Kazunobu Tasaka
    @tasanobu
    Hello👋
    I'm Nobu from Japan. Thank you for inviting me to the group!
    Regarding tracking tasks, I agree with Alex's comment. GitHub issues would be easy to use for new people.
    Alex (Jae) Choi
    @asd2734
    @tasanobu Welcome to the group!
    Kazunobu Tasaka
    @tasanobu

    Hi!
    This is just a heads up.

    I was done with "Hello World" on smoke-framework and I've just started looking into smoke-aws to add the support for RDS.
    The way to use SmokeHTTPClient seems different from the way of NSURLSession which is the http client I'm familiar with.
    I'm now feeling that adding the RDS client is a good starter task for me😁

    tachyonics
    @tachyonics
    That’s great @tasanobu. Let us know if you run into any issues!
    Sounds like GitHub issues have the general consensus. Feel free to add issues for the things everyone is working on
    Kazunobu Tasaka
    @tasanobu
    @tachyonics
    Thanks! I really appreciate it!
    I have two questions about the way to set up the dev environment while developing the RDS client.
    I'd say an RDS instance should be accessed from an EC2 instance in the same VPC. In that case,
    1. What AMI should I use for an EC2 instance? Ubuntu instead of Amazon Linux?
    2. Is there any good tool to sync code between the EC2 instance and the laptop?
    I'd like to write code on my mac with Xcode so I'm wondering if there is a tool like ninja-dev-sync.
    Ronald V. Simmons
    @rvsrvs
    I've been trying to rehost smoke on top of NIO2 and Swift 5. Has anyone gotten this working? The changes seem relatively trivial, but when I make them, I see NIO2 handling the incoming request, but never invoking my service.
    ha. I see there is a milestone on it. Maybe I'll dive a little deeper this weekend.
    tachyonics
    @tachyonics
    @rvsrvs I haven’t tried this but like you I would have thought the changes would be fairly trivial. Can you trace through from NIO2 to see where the request is being lost?
    tachyonics
    @tachyonics
    @tasanobu I haven’t tried using an EC2 instance during development of the previous clients but used my laptop and IAM roles - this is possible using either static credentials or rotating credentials. I’ll send you some documentation how my team does it internally. Otherwise, Ubtuntu should be fine except Ubuntu 18:04. I don’t know of any code syncing tool but I would have to think it must exist.
    Ronald V. Simmons
    @rvsrvs
    @tachyonics Swift5 is trivial. mainly getting rid of the public declaration on functions that are declared to meet an already public protocol plus a couple of API renames. Everything just works doing that on NIO 1. Getting it to compile with NIO2 also seemed trivial, but then didn't work. Possibly related to the issue that @weissi posted, but more likely something a bit more subtle. I'll try to take a look in the next couple of days.
    Kazunobu Tasaka
    @tasanobu
    @tachyonics
    Thanks🙏 I'll check the documents you'll send! (I'm not in a rush. Please send them when you have time🙇‍♂️)
    I'd not like to use an EC2 during development if possible.
    Kazunobu Tasaka
    @tasanobu
    I’ve just checked emails and you’ve already sent it to me. Thanks! I’ll check the doc tonight!
    Kazunobu Tasaka
    @tasanobu

    Hi! Regarding RDS, I made the following pull request on smoke-aws-generate.
    amzn/smoke-aws-generate#3

    I'd appreciate it if you would take a look at it and give feedback.
    Thank you.

    tachyonics
    @tachyonics
    Thanks @tasanobu. I have reviewed your pull request and it all looks good. Thanks!
    Kazunobu Tasaka
    @tasanobu
    @tachyonics Thank you for taking a look! It looks like I don't have the permission to merge it. Please merge it when you have time🙏 If there is anything I should finish before merging it, please let me know.
    Alex (Jae) Choi
    @asd2734
    Looks good to me too! Merged. Thanks @tasanobu!
    Kazunobu Tasaka
    @tasanobu
    @asd2734 Thanks a lot!
    Kazunobu Tasaka
    @tasanobu
    Hi! I submitted a PR on smoke-aws to add RDS client. When you have time, please take a look 🙇‍♂️
    amzn/smoke-aws#19
    Kazunobu Tasaka
    @tasanobu
    I submitted another PR on smoke-aws-generate. It's like a small bug fix.
    amzn/smoke-aws-generate#4
    tachyonics
    @tachyonics
    Thanks @tasanobu. I have approved and commited both of them!
    Kazunobu Tasaka
    @tasanobu
    @tachyonics Thank you for reviewing and merging them!
    Kazunobu Tasaka
    @tasanobu
    Hi! I cut amzn/smoke-aws#20 on smoke-aws about the RDS-Data API. Is there any concers to work on it? If not, I'd like to work on it this weekend.
    tachyonics
    @tachyonics
    Thanks @tasanobu . I have no concerns. Feel free to take it up. Thanks!
    Kazunobu Tasaka
    @tasanobu
    Thanks! I’ll work on it!!
    Kazunobu Tasaka
    @tasanobu
    I found a problem when testing error handling of rds-data and described the detail in amzn/smoke-aws-generate#6.
    Please take a look when you have time.
    tachyonics
    @tachyonics
    I have a small PR to add Swift 5.0.1 CI Testing to SmokeHTTP - amzn/smoke-http#27
    Kazunobu Tasaka
    @tasanobu
    It looks good to me!
    tachyonics
    @tachyonics
    Thanks @tasanobu, I will merge it
    I have been looking into amzn/smoke-aws#14 where SmokeAWS can’t compile on Ubuntu 18.04 as it comes with OpenSSL 1.1 rather than 1.0. Looks like the easiest way to support systems with either OpenSSL 1.0 or 1.1 is to use an existing library that shims the differences. I have started testing with BlueCryptor from IBM here - https://github.com/amzn/smoke-aws/tree/swift_5_0_testing. Does anyone have any thoughts on this approach?
    tachyonics
    @tachyonics
    I also have a small PR for SmokeAWSCredentials to be more robust around credentials refresh failures - amzn/smoke-aws-credentials#9
    Kazunobu Tasaka
    @tasanobu
    Although I'm still not familiar with the implementation of the package, I looked through the changes and made one small comment. Please take a look and ignore it if I'm wrong.
    tachyonics
    @tachyonics
    Thanks @tasanobu. I will take a look at your comment
    tachyonics
    @tachyonics
    @tasanobu I agree with your comment and have made that change.
    A PR for Swift 5.0.1 CI Tests for smoke-framework - amzn/smoke-framework#23
    Kazunobu Tasaka
    @tasanobu
    Hi!
    I took a look at the PRs below and approved both!
    amzn/smoke-aws-credentials#9
    amzn/smoke-framework#23
    Kyle Ishie
    @kyleishie
    @tachyonics Here I am.
    tachyonics
    @tachyonics
    Hi @kyleishie. Thanks for your interest in the SmokeFramework and related repositories
    Alex (Jae) Choi
    @asd2734
    I have a PR for an issue in which SNS calls were failing when a single quote character was present in the message being published. Would appreciate it if anyone could take a look!
    amzn/smoke-aws#22
    tachyonics
    @tachyonics
    @asd2734 Looks good! Thanks
    Alex (Jae) Choi
    @asd2734
    @tachyonics Thanks for the quick response!